Lint accesses source sets information without dependencies [253219347]

Fixed

Bug

Status Update

No update yet.

Description

ga...@google.com

created issue #1

Oct 12, 2022 01:41PM

Lint access source set information in a way that does not capture dependency information. Androidx is hitting this with:

* What went wrong:
A problem was found with the configuration of task ':room:room-compiler-processing-testing:lintAnalyze' (type 'AndroidLintAnalysisTask').
  - Gradle detected a problem with the following location: '$OUT_DIR/androidx/room/room-compiler-processing-testing/build/test-config-copy'.
    
    Reason: Task ':room:room-compiler-processing-testing:lintAnalyze' uses this output of task ':room:room-compiler-processing-testing:copyTestConfiguration' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed.
    
    Possible solutions:
      1. Declare task ':room:room-compiler-processing-testing:copyTestConfiguration' as an input of ':room:room-compiler-processing-testing:lintAnalyze'.
      2. Declare an explicit dependency on ':room:room-compiler-processing-testing:copyTestConfiguration' from ':room:room-compiler-processing-testing:lintAnalyze' using Task#dependsOn.
      3. Declare an explicit dependency on ':room:room-compiler-processing-testing:copyTestConfiguration' from ':room:room-compiler-processing-testing:lintAnalyze' using Task#mustRunAfter.
    
    Please refer to https://docs.gradle.org/8.0-milestone-2/userguide/validation_problems.html#implicit_dependency for more details about this problem.

* Exception is:
org.gradle.internal.execution.WorkValidationException: A problem was found with the configuration of task ':room:room-compiler-processing-testing:lintAnalyze' (type 'AndroidLintAnalysisTask').
  - Gradle detected a problem with the following location: '$OUT_DIR/androidx/room/room-compiler-processing-testing/build/test-config-copy'.
    
    Reason: Task ':room:room-compiler-processing-testing:lintAnalyze' uses this output of task ':room:room-compiler-processing-testing:copyTestConfiguration' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed.
    
    Possible solutions:
      1. Declare task ':room:room-compiler-processing-testing:copyTestConfiguration' as an input of ':room:room-compiler-processing-testing:lintAnalyze'.
      2. Declare an explicit dependency on ':room:room-compiler-processing-testing:copyTestConfiguration' from ':room:room-compiler-processing-testing:lintAnalyze' using Task#dependsOn.
      3. Declare an explicit dependency on ':room:room-compiler-processing-testing:copyTestConfiguration' from ':room:room-compiler-processing-testing:lintAnalyze' using Task#mustRunAfter.
    
    Please refer to https://docs.gradle.org/8.0-milestone-2/userguide/validation_problems.html#implicit_dependency for more details about this problem.

BUILD FAILED in 25m 59s

The issue seems to be usage of non-provider based APIs here.

We should switch to SourceSet.getAllSource().getSourceDirectories().

Comments

sp...@google.com <sp...@google.com> #2Oct 14, 2022 07:39PM

Accepted by sp...@google.com.

This happens to me when using pattern+fingerprint on api 29 using 1.0.1

au...@google.com <au...@google.com> #3Oct 17, 2022 04:53PM

happens to me on Android P using 1.0.1

au...@google.com <au...@google.com> #4Oct 17, 2022 06:17PM

Is there any workaround for this? Can we expect this to be fixed?

au...@google.com <au...@google.com> #5Oct 21, 2022 01:00AM

I am facing the same problem too! Is there any solution to this problem?

au...@google.com <au...@google.com> #6Oct 21, 2022 01:15AM

Still seeing this issue on Android 10 Pixel 4.

au...@google.com <au...@google.com> #7Oct 21, 2022 01:28AM

Our team is facing this issue as well. What are the alternatives available right now apart from cloning the library and changing the behavior?

au...@google.com <au...@google.com> #8Oct 21, 2022 01:39AM

Biometric prompt is also not dismissed if user goes to different apps on API levels below 29. The same behavior is not true for API 29 and above. Is there any workaround for this?

sp...@google.com <sp...@google.com> #9Oct 21, 2022 04:55PM

Same issue for me. API 10 device during Fingerprint prompt.

sp...@google.com <sp...@google.com> #10Oct 21, 2022 11:30PM

Assigned to au...@google.com.

162013003

Bug_253219347_gradle_project_bug.zip

153 KB

Download

au...@google.com <au...@google.com> #11Oct 22, 2022 12:05AM

Have the same problem, Android 10, Mi 9T

bug.zip

163 KB

Download

sp...@google.com <sp...@google.com> #12Oct 22, 2022 04:03AM

Also happening with 1.2.0-alpha04.

bug_repro.zip

153 KB

Download

xa...@google.com <xa...@google.com> #13Oct 28, 2022 02:14AM

Reassigned to sp...@google.com.

Project: platform/frameworks/support
Branch: androidx-main
Author: Hao Dong <spdonghao@google.com>
Link: https://android-review.googlesource.com/3343432

Propogate cancel authentication in onStop() for all api levels.

Expand for full commit details

Propogate cancel authentication in onStop() for all api levels. 
 
Bug: 149770989 
Test: ./gradlew biometric:biometric:assemble 
 
Change-Id: I8c393f400d60f2b2af075671c4cf2727e63d82b8

Files:

M biometric/biometric/src/main/java/androidx/biometric/BiometricFragment.java

Hash: 302fab7c34832a989f434e43f16b146d37fa08b6
Date: Wed Nov 13 02:45:59 2024

sp...@google.com <sp...@google.com> #14Oct 28, 2022 03:07PM

re #13, no, we don't need to do anything in 7.4 after this fix in Gradle.

Leaving this bug open because there is room for improvement + will add a regression test in 8.0 branch.

au...@google.com <au...@google.com> #15Oct 28, 2022 04:23PM

In the gradle slack, they noted that we should be using a different API for this if we want java resources + classes. It might be best if you chat with jvandort@ about it.

sp...@google.com <sp...@google.com> #16Feb 15, 2023 08:47PM

Marked as fixed.

Fixed with this change.

na...@google.com <na...@google.com> #17Jul 26, 2023 05:21PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.emoji2:emoji2-emojipicker:1.4.0-rc01

Issue 253219347

Description

Issue summary

Comments

sp...@google.com <sp...@google.com> #2Oct 14, 2022 07:39PM

au...@google.com <au...@google.com> #3Oct 17, 2022 04:53PM

au...@google.com <au...@google.com> #4Oct 17, 2022 06:17PM

au...@google.com <au...@google.com> #5Oct 21, 2022 01:00AM

au...@google.com <au...@google.com> #6Oct 21, 2022 01:15AM

au...@google.com <au...@google.com> #7Oct 21, 2022 01:28AM

au...@google.com <au...@google.com> #8Oct 21, 2022 01:39AM

sp...@google.com <sp...@google.com> #9Oct 21, 2022 04:55PM

sp...@google.com <sp...@google.com> #10Oct 21, 2022 11:30PM

au...@google.com <au...@google.com> #11Oct 22, 2022 12:05AM

sp...@google.com <sp...@google.com> #12Oct 22, 2022 04:03AM

xa...@google.com <xa...@google.com> #13Oct 28, 2022 02:14AM

sp...@google.com <sp...@google.com> #14Oct 28, 2022 03:07PM

au...@google.com <au...@google.com> #15Oct 28, 2022 04:23PM

sp...@google.com <sp...@google.com> #16Feb 15, 2023 08:47PM

na...@google.com <na...@google.com> #17Jul 26, 2023 05:21PM

Add comment

Issue metadata