Lint accesses source sets information without dependencies [253219347]

Fixed

Bug

Status Update

No update yet.

Description

ga...@google.com

created issue #1

Oct 12, 2022 01:41PM

Lint access source set information in a way that does not capture dependency information. Androidx is hitting this with:

* What went wrong:
A problem was found with the configuration of task ':room:room-compiler-processing-testing:lintAnalyze' (type 'AndroidLintAnalysisTask').
  - Gradle detected a problem with the following location: '$OUT_DIR/androidx/room/room-compiler-processing-testing/build/test-config-copy'.
    
    Reason: Task ':room:room-compiler-processing-testing:lintAnalyze' uses this output of task ':room:room-compiler-processing-testing:copyTestConfiguration' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed.
    
    Possible solutions:
      1. Declare task ':room:room-compiler-processing-testing:copyTestConfiguration' as an input of ':room:room-compiler-processing-testing:lintAnalyze'.
      2. Declare an explicit dependency on ':room:room-compiler-processing-testing:copyTestConfiguration' from ':room:room-compiler-processing-testing:lintAnalyze' using Task#dependsOn.
      3. Declare an explicit dependency on ':room:room-compiler-processing-testing:copyTestConfiguration' from ':room:room-compiler-processing-testing:lintAnalyze' using Task#mustRunAfter.
    
    Please refer to https://docs.gradle.org/8.0-milestone-2/userguide/validation_problems.html#implicit_dependency for more details about this problem.

* Exception is:
org.gradle.internal.execution.WorkValidationException: A problem was found with the configuration of task ':room:room-compiler-processing-testing:lintAnalyze' (type 'AndroidLintAnalysisTask').
  - Gradle detected a problem with the following location: '$OUT_DIR/androidx/room/room-compiler-processing-testing/build/test-config-copy'.
    
    Reason: Task ':room:room-compiler-processing-testing:lintAnalyze' uses this output of task ':room:room-compiler-processing-testing:copyTestConfiguration' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed.
    
    Possible solutions:
      1. Declare task ':room:room-compiler-processing-testing:copyTestConfiguration' as an input of ':room:room-compiler-processing-testing:lintAnalyze'.
      2. Declare an explicit dependency on ':room:room-compiler-processing-testing:copyTestConfiguration' from ':room:room-compiler-processing-testing:lintAnalyze' using Task#dependsOn.
      3. Declare an explicit dependency on ':room:room-compiler-processing-testing:copyTestConfiguration' from ':room:room-compiler-processing-testing:lintAnalyze' using Task#mustRunAfter.
    
    Please refer to https://docs.gradle.org/8.0-milestone-2/userguide/validation_problems.html#implicit_dependency for more details about this problem.

BUILD FAILED in 25m 59s

The issue seems to be usage of non-provider based APIs here.

We should switch to SourceSet.getAllSource().getSourceDirectories().

Comments

sp...@google.com <sp...@google.com> #2Oct 14, 2022 07:39PM

Accepted by sp...@google.com.

Thank you for the report and the supplied dump with the reproduction. I can confirm that the NPE is also present on HEAD, and I will look into it.

Quite a few of the class files in the dump has malformed inner-class attribute, where R8 reports e.g.:

Info in /tmp/tmpo67ucguh/program.jar:ofifmwrrhhmodsc/ψξψξψξξ.class:
Malformed inner-class attribute:
	outerTypeInternal: ofifmwrrhhmodsc/ψξψξψξξ
	innerTypeInternal: ofifmwrrhhmodsc/ψξψξψξξ$ψξξψξξξ
	innerName: ψξψξψξξ$ψξξψξξξ

These are ignored, so they should not be the reason for the NPE, but something to also look into.

au...@google.com <au...@google.com> #3Oct 17, 2022 04:53PM

Project: r8
Branch: main

commit e59500ca4445f5fb5d2ccc1114acbf66df11d196
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 09:48:55 2023

Insert patched frame instructions in the right place

Fixes:

b/274337639

Change-Id: Iae204ed529f9af5bf5fa3eaacba45128dfa6fd9e

M src/main/java/com/android/tools/r8/graph/LazyCfCode.java
M src/test/java/com/android/tools/r8/cf/frames/InitBeforeNewInInstructionStreamTest.java

https://r8-review.googlesource.com/77390

au...@google.com <au...@google.com> #4Oct 17, 2022 06:17PM

Project: r8
Branch: main

commit 780c2e83c8c033e7594d61894fa1b3dbcad6630b
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 09:48:13 2023

Add reproduction of

b/274337639

Bug:

b/274337639

Change-Id: I7573883d6a649eed47b10d7bf0cdea2e11710268

M build.gradle
M src/main/java/com/android/tools/r8/cf/code/frame/UninitializedNew.java
A src/test/java/com/android/tools/r8/cf/frames/InitBeforeNewInInstructionStreamTest.java

https://r8-review.googlesource.com/77389

au...@google.com <au...@google.com> #5Oct 21, 2022 01:00AM

I will backport this to the 8.0 and 4.0 branches.

au...@google.com <au...@google.com> #6Oct 21, 2022 01:15AM

Thank you very much for taking a look at this!

Is this fix related to the nullpointer or the malformed inner-class attributes ?

Do you have a separated ticket for it? Could you share it?

au...@google.com <au...@google.com> #7Oct 21, 2022 01:28AM

Project: r8
Branch: 4.0

commit 6edb00fb23e41b28d4794cfa69d706d5c5aa3fba
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 16:55:01 2023

Version 4.0.56

Bug:

b/274337639

Change-Id: I88a20fc922ce892d38fa3a34f9a3f1f4714354ae

M src/main/java/com/android/tools/r8/Version.java

https://r8-review.googlesource.com/77447

au...@google.com <au...@google.com> #8Oct 21, 2022 01:39AM

Project: r8
Branch: 4.0

commit d9215af3b02f64d1207b9ebd63a6925229307b9d
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 16:54:50 2023

Insert patched frame instructions in the right place

Bug:

b/274337639

https://r8-review.googlesource.com/77446

sp...@google.com <sp...@google.com> #9Oct 21, 2022 04:55PM

Project: r8
Branch: 4.0

commit 4fda9b9062c871ba0e31cb68d1518b13b993692f
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 16:54:33 2023

Add reproduction of

b/274337639

Bug:

b/274337639

https://r8-review.googlesource.com/77445

sp...@google.com <sp...@google.com> #10Oct 21, 2022 11:30PM

Assigned to au...@google.com.

Project: r8
Branch: 8.0

commit 6686e7dffea83ea894438b496c065d0a18cda206
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 16:53:01 2023

Version 8.0.37

Bug:

b/274337639

Change-Id: I43a723a94638088d921cd3fb6e22ef6e41f07d5f

M src/main/java/com/android/tools/r8/Version.java

https://r8-review.googlesource.com/77444

Bug_253219347_gradle_project_bug.zip

153 KB

Download

au...@google.com <au...@google.com> #11Oct 22, 2022 12:05AM

Project: r8
Branch: 8.0

commit 57f55fb70aa678a61f9c7ff1826fbc695faeac7d
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 16:52:27 2023

Insert patched frame instructions in the right place

Bug:

b/274337639

https://r8-review.googlesource.com/77443

bug.zip

163 KB

Download

sp...@google.com <sp...@google.com> #12Oct 22, 2022 04:03AM

Project: r8
Branch: 8.0

commit cd00c053222b06bb27fdd90bbed56af9c9ef0744
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 16:51:57 2023

Add reproduction of

b/274337639

Bug:

b/274337639

https://r8-review.googlesource.com/77442

bug_repro.zip

153 KB

Download

xa...@google.com <xa...@google.com> #13Oct 28, 2022 02:14AM

Reassigned to sp...@google.com.

b/274337639

https://r8-review.googlesource.com/77446

sp...@google.com <sp...@google.com> #14Oct 28, 2022 03:07PM

Project: r8
Branch: 4.0

commit 4fda9b9062c871ba0e31cb68d1518b13b993692f
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 16:54:33 2023

Add reproduction of

b/274337639

Bug:

b/274337639

https://r8-review.googlesource.com/77445

au...@google.com <au...@google.com> #15Oct 28, 2022 04:23PM

Answer to #comment6. This fix only addresses the NPE.

The malformed inner-class attributes is an issue with the input class files, and they where not related to the NPE. You will have to contact the supplier of the library where they are present if you would like to get rid of the "Info" messages (you will have to run ./gradlew --info ... to see them). From what I can see the issue is that the innerName: ψξψξψξξ$ψξξψξξξ should have been innerName: ψξξψξξξ.

sp...@google.com <sp...@google.com> #16Feb 15, 2023 08:47PM

Marked as fixed.

Project: r8
Branch: 4.0

commit 49f738ff7377dacecf0fca39fec5146beb251ea3
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 18:14:15 2023

Version 4.0.57

Backport test to 4.0 test APIs.

Bug:

b/274337639

Change-Id: Iecf03a2ad9dcdbd53e6c572d2f08915248435682

M src/main/java/com/android/tools/r8/Version.java
M src/test/java/com/android/tools/r8/cf/frames/InitBeforeNewInInstructionStreamTest.java

https://r8-review.googlesource.com/77450

na...@google.com <na...@google.com> #17Jul 26, 2023 05:21PM

Project: r8
Branch: 8.0

commit c11ddf096e58245c2c67514dc9e5a2098dd8f705
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 18:16:54 2023

Version 8.0.38

Backport test to 8.0 test APIs.

Bug:

b/274337639

Change-Id: I35ae6d701fa92a6a7a734f9c0296d1383fed8e20

M src/main/java/com/android/tools/r8/Version.java
M src/test/java/com/android/tools/r8/cf/frames/InitBeforeNewInInstructionStreamTest.java

https://r8-review.googlesource.com/77451

Issue 253219347

Description

Issue summary

Comments

sp...@google.com <sp...@google.com> #2Oct 14, 2022 07:39PM

au...@google.com <au...@google.com> #3Oct 17, 2022 04:53PM

au...@google.com <au...@google.com> #4Oct 17, 2022 06:17PM

au...@google.com <au...@google.com> #5Oct 21, 2022 01:00AM

au...@google.com <au...@google.com> #6Oct 21, 2022 01:15AM

au...@google.com <au...@google.com> #7Oct 21, 2022 01:28AM

au...@google.com <au...@google.com> #8Oct 21, 2022 01:39AM

sp...@google.com <sp...@google.com> #9Oct 21, 2022 04:55PM

sp...@google.com <sp...@google.com> #10Oct 21, 2022 11:30PM

au...@google.com <au...@google.com> #11Oct 22, 2022 12:05AM

sp...@google.com <sp...@google.com> #12Oct 22, 2022 04:03AM

xa...@google.com <xa...@google.com> #13Oct 28, 2022 02:14AM

sp...@google.com <sp...@google.com> #14Oct 28, 2022 03:07PM

au...@google.com <au...@google.com> #15Oct 28, 2022 04:23PM

sp...@google.com <sp...@google.com> #16Feb 15, 2023 08:47PM

na...@google.com <na...@google.com> #17Jul 26, 2023 05:21PM

Add comment

Issue metadata