Status Update
Comments
pa...@hinge.co <pa...@hinge.co> #2
First of all thanks for this detailed issue.
This issue had been investigated thoroughly when it was first reported internally. The surprising detail in this report is that the issue is not reproducible before 1.7
. I will look into this.
The main problem with POBox is the fact that it is deprecated. Since 2021 Sony has been shipping new Xperia devices with Gboard pre-installed. Although we are aware that there is still a considerable amount of users still using POBox, the described behavior is caused by POBox's noncompliant behavior with InputConnection
and InputMethodManager
documentation. However, this is understandable since TextView
implementation was also not respecting the behavior that is expected from Editors.
Ultimately we have decided to enforce the documented behavior with specifically regards to when editors should call InputMethodManager.updateSelection
. Also, although unconfirmed, there were traces of possible custom code being included in Sony OEM images that changed how InputMethodManager was notified from TextView. If POBox also depended on something like this, it would be impossible for Compose code to replicate the same unknown behavior.
pa...@hinge.co <pa...@hinge.co> #3
Or is that option not available?
Even if the root cause is POBox, from the perspective of the app's customers, it looks like an app bug, so this issue is a blocker against updating Jetpack Compose.
kl...@google.com <kl...@google.com>
kl...@google.com <kl...@google.com> #4
Just to be sure, it is dangerous to replace Compose TextField with Android View EditText as a workaround for this issue.
Compose 1.7 has a bug that causes ANR when the focus is on EditText.
Another View-related bug in Compose 1.7 is that an Android View is focused by calling FocusManager.clearFocus().
Perhaps there is a lack of testing of Compose 1.7 in combination with Android View. There is also a possibility that there are other fatal bugs related to View.
In other words, the only options for apps targeting the Japanese market that require POBox support are to continue using Compose 1.6 or to use EditText in combination with various workarounds.
si...@google.com <si...@google.com>
kl...@google.com <kl...@google.com> #5
Project: platform/frameworks/support
Branch: androidx-main
Author: Halil Ozercan <
Link:
Fix POBox keyboard issue
Expand for full commit details
Fix POBox keyboard issue
Fix: 373743376
Fix: 329209241
Test: NullableInputConnectionWrapperTest
Change-Id: I94e0e598274fb88b255f977f9fbd50dfbbb1ecb1
Files:
- M
compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/text/input/NullableInputConnectionWrapperTest.kt
- M
compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/text/input/NullableInputConnectionWrapper.android.kt
Hash: 57f58c4b80d5d8470b2aca325dfdcd55f235231e
Date: Thu Oct 24 01:25:20 2024
kl...@google.com <kl...@google.com> #6
Many thanks again for this report. Especially for giving us a huge clue in terms of what could be going wrong. The fix is now merged and I will ask for a cherry-pick into a stable release.
kl...@google.com <kl...@google.com> #7
Do you have any concrete plan to cherry-pick the fix into current stable version (1.7.x)? We are currently waiting it.
ap...@google.com <ap...@google.com> #8
Yes, this fix is planned to be included in a future 1.7.x
release.
na...@google.com <na...@google.com> #9
Thanks for the fix. Sorry to follow up on this. is it possible for you to share specific release version/date for the stable version? We are waiting on this to decide on our direction.
ju...@google.com <ju...@google.com> #10
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.ui:ui-text-android:1.5.0-beta01
sv...@gmail.com <sv...@gmail.com> #11
Versions:
androidx.compose.ui:ui-text-android:1.5.1
androidx.compose.foundation:foundation:1.5.1
androidx.compose.ui:ui:1.5.1
androidx.compose.ui:ui-text:1.5.1
fu...@gmail.com <fu...@gmail.com> #12
fu...@gmail.com <fu...@gmail.com> #13
The issue is only fixed in URL redirection case but not custom action case, looks there will be
a LinkAnnotation
added in 1.7.0 for it.
In case anyone need solution now or unable to use newest compose version, might try these approaches:
Use customActions
instead of link
@OptIn(ExperimentalTextApi::class)
@Composable
fun TestInlineLink1() = Column(
modifier = Modifier.fillMaxWidth(),
verticalArrangement = Arrangement.Center,
horizontalAlignment = Alignment.CenterHorizontally,
) {
var result by remember { mutableStateOf("") }
fun action(tag: String) {
result = "Inline link [ $tag ] get clicked"
}
val text = buildAnnotatedString {
append("This is an example for ")
withAnnotation(tag = "link1", annotation = "link1") {
append("link1")
}
append(" and ")
withAnnotation(tag = "link2", annotation = "link2") {
append("link2")
}
}
ClickableText(
modifier = Modifier.semantics {
customActions = listOf(
CustomAccessibilityAction("link1") {
action("link1")
true
},
CustomAccessibilityAction("link2") {
action("link2")
true
},
)
},
text = text,
onClick = { offset ->
val tag = text.getStringAnnotations(offset, offset)
.singleOrNull()?.tag
tag?.let(::action)
}
)
Text(text = result)
}
Modify AccessibilityNodeInfo
@OptIn(ExperimentalTextApi::class)
@Composable
fun TestInlineLink2() = Column(
modifier = Modifier.fillMaxWidth(),
verticalArrangement = Arrangement.Center,
horizontalAlignment = Alignment.CenterHorizontally,
) {
var result by remember { mutableStateOf("") }
fun action(tag: String) {
result = "Inline link [ $tag ] get clicked"
}
val text = buildAnnotatedString {
append("This is an example for ")
withAnnotation(urlAnnotation = UrlAnnotation(url = "link1")) {
append("link1")
}
append(" and ")
withAnnotation(urlAnnotation = UrlAnnotation(url = "link2")) {
append("link2")
}
}
WrappingView {
ReplaceAccessibilityNodeInfoText(
text = text.toSpannableString(::action)
)
ClickableText(
text = text,
onClick = { offset ->
val tag = text.getUrlAnnotations(offset, offset)
.singleOrNull()?.item?.url
tag?.let(::action)
},
)
}
Text(text = result)
}
@Composable
private fun ReplaceAccessibilityNodeInfoText(
text: CharSequence,
) {
val view = LocalView.current
val defaultDelegate = ViewCompat.getAccessibilityDelegate(view)
val newDelegate = object : AccessibilityDelegateCompat() {
override fun onInitializeAccessibilityNodeInfo(
host: View,
info: AccessibilityNodeInfoCompat,
) {
defaultDelegate?.onInitializeAccessibilityNodeInfo(host, info)
info.text = text
}
}
ViewCompat.setAccessibilityDelegate(view, newDelegate)
}
/**
* use AndroidView to create an AndroidComposeView,
* aim to prevent modify accessibilityDelegate of outer view.
*/
@Composable
private fun WrappingView(
modifier: Modifier = Modifier,
content: @Composable () -> Unit,
) {
AndroidView(
modifier = modifier,
factory = { context ->
ComposeView(context).apply {
setContent(content)
}
}
)
}
@OptIn(ExperimentalTextApi::class)
private fun AnnotatedString.toSpannableString(
action: (String) -> Unit
) = buildSpannedString {
append(this@toSpannableString)
getUrlAnnotations(0, length).forEach { (item, start, end, _) ->
setSpan(
object : ClickableSpan() {
override fun onClick(widget: View) {
action(item.url)
}
},
start, end, SPAN_INCLUSIVE_EXCLUSIVE
)
}
}
Description
- Jetpack Compose component used: ClickableText with AnnotatedString including UrlAnnotation
- Android Studio Build: Android Studio Chipmunk | 2021.2.1 Patch 2
Build #AI-212.5712.43.2112.8815526, built on July 10, 2022
- Kotlin version: 1.7.20
- Devices/Android versions reproduced on: Android 30, 33 on Pixel 4As
- Keyboard (i.e. Gboard, Samsung, etc): Stock Google keyboard
If this is a bug in the library, we would appreciate if you could attach:
- Sample project to trigger the issue:
- A screenrecord or screenshots showing the issue (if UI related). This is included with the sample project but I attached it again here.
- Stack trace (if applicable) - N/A
There is a bug where the recently introduced UrlAnnotation is read correctly by Talkback, but the onClick is not called, so the link is not opened.
Steps to Reproduce:
1. Turn on Talkback in Accessibility settings
2. Run app
3. App will display a single line of text
4. Part of this text will be a URLAnnotation containing a link
5. Open the Talkback action menu per the prompt
6. Select "Links" in Talkback menu
7. Select the link to trigger the onClick method call, which opens the browser.
Expected:
1.Talkback correctly recognizes the link in the text
2. Talkback shows the link in the Talkback menu
3. When the link is selected in the Talkback menu, the onClick is called in ClickableText and the user is navigated to the browser.
Actual:
1. The onClick for the ClickableText is never called. Note that it is not the browser navigation that is broken. This can be confirmed using the logs in the sample app provided.