SupportSQLiteQueryBuilder selection() should use Array<out Any?>? to prevent unnecessary casts [253531073]

Fixed

Bug

Status Update

No update yet.

Description

ia...@gmail.com

created issue #1

Oct 14, 2022 03:13AM

Component used: Sqlite

Version used: 2.3.0-beta01

ContentProviders have methods of the signature:

override fun query(
    uri: Uri,
    projection: Array<String>?,
    selection: String?,
    selectionArgs: Array<String>?,
    sortOrder: String?
): Cursor? {

You'll note that the type of the selectionArgs is Array<String>?.

If you try to pass that to SupportSQLiteQueryBuilder.builder's selection method, you get the following error:

Type mismatch.
  Required:
    Array<Any?>?
  Found:
    Array<String>?

However, String is a subtype of Any?, so this should work without any casting, but selection is defined as

fun selection(selection: String?, bindArgs: Array<Any?>?)

Which means the only valid type is exactly Array<Any?>?.

Can you change it to

fun selection(selection: String?, bindArgs: Array<out Any?>?)

So that subtypes of Any? can also be accepted?

That would mean I could remove this hacky workaround:

// Convert from an Array<String>? to an Array<Any?>?
// without an unsafe cast
qb.selection(selection, selectionArgs?.toList()?.toTypedArray())

Comments

da...@google.com <da...@google.com> #2Oct 14, 2022 02:28PM

For Kotlin 2.0 and KSP 2.0 the Cannot change attributes of configuration ':composeApp:debugFrameworkIosX64' after it has been locked for mutation really seems like a KSP issue. You should file a bug in their repository with a sample app if possible.

If you downgrade to Kotlin 1.9 then things 'should' work, there are example apps out there with such configuration, like the following one: https://github.com/realityexpander/KMP_Room/tree/main

ap...@google.com <ap...@google.com> #3Oct 18, 2022 12:12PM

Yes this does seem like a KSP issue however it only starts happening when room is added to the project. As the template project compiles just fine.

Will try to use the example provided by you to check if it fixes the issue.

da...@google.com <da...@google.com> Oct 18, 2022 12:15PM

Marked as fixed.

na...@google.com <na...@google.com> #4Nov 9, 2022 06:28PM

Note that this issue happens when applying the Compose, KSP and Room Plugin together in Kotlin 2.0.x, the workaround for now is to not use the Room Gradle Plugin and instead specify the schema location vis KSP arguments:

// In the build.gradle
ksp {
    arg("room.schemaLocation", "${projectDir}/schemas")
}

pr...@google.com <pr...@google.com> #5Mar 22, 2023 08:24PM

Hi, I encountered a similar problem and was able to resolve it by updating the dependencies

room = "2.7.0-alpha08"
ksp = "2.0.20-1.0.25"

compose-plugin = "1.6.11"
kotlin = "2.0.20"

pr...@google.com <pr...@google.com> #6Oct 18, 2023 08:42PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.sqlite:sqlite:2.4.0
androidx.sqlite:sqlite-framework:2.4.0

Issue 253531073