SupportSQLiteQueryBuilder selection() should use Array<out Any?>? to prevent unnecessary casts [253531073]

Fixed

Bug

Status Update

No update yet.

Description

ia...@gmail.com

created issue #1

Oct 14, 2022 03:13AM

Component used: Sqlite

Version used: 2.3.0-beta01

ContentProviders have methods of the signature:

override fun query(
    uri: Uri,
    projection: Array<String>?,
    selection: String?,
    selectionArgs: Array<String>?,
    sortOrder: String?
): Cursor? {

You'll note that the type of the selectionArgs is Array<String>?.

If you try to pass that to SupportSQLiteQueryBuilder.builder's selection method, you get the following error:

Type mismatch.
  Required:
    Array<Any?>?
  Found:
    Array<String>?

However, String is a subtype of Any?, so this should work without any casting, but selection is defined as

fun selection(selection: String?, bindArgs: Array<Any?>?)

Which means the only valid type is exactly Array<Any?>?.

Can you change it to

fun selection(selection: String?, bindArgs: Array<out Any?>?)

So that subtypes of Any? can also be accepted?

That would mean I could remove this hacky workaround:

// Convert from an Array<String>? to an Array<Any?>?
// without an unsafe cast
qb.selection(selection, selectionArgs?.toList()?.toTypedArray())

Comments

da...@google.com <da...@google.com> #2Oct 14, 2022 02:28PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019

Change the way to detect mismatch between POJO and query

This fixes cursor mismatch warnings with expandProjection.

Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8

M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt

https://android-review.googlesource.com/1123258

https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1

ap...@google.com <ap...@google.com> #3Oct 18, 2022 12:12PM

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6093116828680192/#/cherrypickHistory/all)
Created: 2019-10-14 17:23:42.610596+00:00
Changes: aosp/1123258

da...@google.com <da...@google.com> Oct 18, 2022 12:15PM

Marked as fixed.

na...@google.com <na...@google.com> #4Nov 9, 2022 06:28PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020

Re-factor how errors are dismissed when query is re-written

This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (

b/140759491

).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.

This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.

Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f

M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt

https://android-review.googlesource.com/1288456

pr...@google.com <pr...@google.com> #5Mar 22, 2023 08:24PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.room:room-ktx:2.6.0-alpha01
androidx.room:room-runtime:2.6.0-alpha01
androidx.sqlite:sqlite:2.4.0-alpha01
androidx.sqlite:sqlite-framework:2.4.0-alpha01

pr...@google.com <pr...@google.com> #6Oct 18, 2023 08:42PM