When open/close keyboard animation is shaking in compose BottomSheetScaffold [254446195]

Fixed

Bug

Status Update

No update yet.

Description

al...@mc2soft.ru

created issue #1

Oct 19, 2022 06:43PM

Jetpack Compose version:
1.2.1

Jetpack Compose component(s) used:
BottomSheetScaffold

Android Studio Build:
Android Studio Dolphin | 2021.3.1 RC 1

Kotlin version:
1.6.10

Steps to Reproduce or Code Sample to Reproduce:
When the keyboard opens or closes, there is an animation of shaking.

Sample code here:

https://github.com/ShurikuS57/ComposeBottomSheetBug

Video in attach

bug1.webm

7.4 MB

Download

Comments

ma...@google.com <ma...@google.com> #2Feb 1, 2023 12:45PM

Reassigned to jo...@google.com.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 23a7d960caf43390a554700d3c56ada189a9d10e
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Mon Aug 10 15:11:36 2020

IconButton / IconToggleButton API scrub

Test: ./gradlew updateApi
Bug:

b/161809385

Bug:

b/161807956

Relnote: "Adds enabled parameter to IconButton, and reorders parameters in IconToggleButton"
Change-Id: I0a9419b1a631cadad451395302ad87b7f9214f96

M ui/ui-material/api/current.txt
M ui/ui-material/api/public_plus_experimental_current.txt
M ui/ui-material/api/restricted_current.txt
M ui/ui-material/src/commonMain/kotlin/androidx/compose/material/IconButton.kt

https://android-review.googlesource.com/1394868

jo...@google.com <jo...@google.com> #3Feb 6, 2023 01:04PM

This will be addressed with the Swipeable V2 migration :)

ap...@google.com <ap...@google.com> #4Feb 7, 2023 12:55PM

Project: platform/frameworks/support
Branch: androidx-main

commit 782309ea04a9712abcfa7e2b8ff8c6187d40a748
Author: Jossi Wolf <jossiwolf@google.com>
Date: Mon Aug 22 18:09:13 2022

Migrate BottomSheetScaffold.kt to Swipeable V2

Test: Existing tests
Relnote: Incorporated changes in the Swipeable APIs in `BottomSheetScaffold`. `BottomSheetState`'s `confirmStateChange` param has been renamed to `confirmValueChange`. `progress` is now exposed as a float value. `animateTo` and `snapTo` are internal. Use `expand()` and `collapse()` instead. `direction` and `overflow` have been removed. `offset` has been replaced with `requireOffset()`.
Bug: 254446195, 239672689, 239207288, 221094909, 203683941, 202868798, 199562360, 194425016

Change-Id: I323b4ebe42e5a3817f27759749d72ad222ac084b

M compose/material/material/api/public_plus_experimental_1.4.0-beta01.txt
M compose/material/material/api/public_plus_experimental_current.txt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/BottomSheetScaffoldTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/BottomSheetScaffold.kt

https://android-review.googlesource.com/2191920

ap...@google.com <ap...@google.com> #5Mar 31, 2023 03:24PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 8bc84c03b64403daca308e3da3d1148d4bfe1f68
Author: Jossi Wolf <jossiwolf@google.com>
Date: Fri Mar 31 09:47:10 2023

[M2] Snap opportunistically in BottomSheetScaffold

See aosp/2440691. This optimizes layout animations in BottomSheetScaffold.

Test: Manual test
Relnote: Animated sheet content (e.g. Modifier.animateContentSize on sheet content) in BottomSheetScaffold has been optimized and now works smoothly.
Fixes: 270518202
Fixes: 254446195
Change-Id: Ia913cf9c75949c25a5cc1a6f6dc2b650c95793b9

M compose/material/material/src/commonMain/kotlin/androidx/compose/material/BottomSheetScaffold.kt

https://android-review.googlesource.com/2517255

pr...@google.com <pr...@google.com> #6Apr 19, 2023 06:13PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.material:material:1.5.0-alpha03

Issue 254446195