Function rememberPickerState is returning same instance of PickerState after recomposition, even when the input has changed.

It looks like the issue is because rememberPickerState is not passing its parameters (initialNumberOfOptions, initiallySelectedOption and repeatItems) to rememberSaveable function in this line.

Component used: rememberPickerState

Version used: 1.0.2

Devices/Android versions reproduced on: N/A

If this is a bug in the library, we would appreciate if you could attach:

Sample project to trigger the issue.
A screenrecord or screenshots showing the issue (if UI related).

I've added unit tests in this commit showing the issue and a proposed solution: https://github.com/luizgrp/horologist/blob/2be07856616edd7a3f833b96b706339897da10ab/sample/src/androidTest/java/androidx/wear/compose/material/PickerTest.kt

testOriginalFunction test shows that after changing the value of viewModel. _selectedOption, MyComposable does NOT show the new value.
testFunctionWithFix shows that after changing the value of viewModel. _selectedOption, MyComposableFixed shows the new value. rememberPickerStateFixed is the proposed fix for this issue.

This issue was reported by a Googler while using Horologist's TimePicker. The value displayed on the TimePicker is not changing after the values are changed in the ViewModel. To demonstrate that on a simple screen, please see the video attached.

A simple composable displays the hash code value of two PickerState objects when the input value is changed, after recomposition. The first line uses the current rememberPickerState and the hash code does not change. The second line uses rememberPickerStateFixed and the hash code changes.

Issue 255323197

Links (4)

Issue metadata