IssueTracker

Project: platform/frameworks/support
Branch: androidx-main

commit e7b7f8c2f098dd2623e7a7ce45259048963409a7
Author: Chris Craik <ccraik@google.com>
Date:   Thu Oct 20 12:50:37 2022

    Safe by default shell commands
   
    Fixes: 255402908
    Bug: 253094958
    Test: Tests in benchmark-common, benchmark-macro, benchmark-junit4 # API 23 26 31 (emulators) 33 (device)
   
    Require caller to specify if they want stdout or stderr, and validate
    empty if they are not used.
   
    This will incur a performance penalty for every command changed in
    this way, but gives us much greater safety in avoiding ignored shell
    commands leaving the test/device in an undefined state. By default,
    this was a significant regression in shell execution, so selectively
    used unsafe variant, and optimized the script to avoid a chmod and
    multiple kotlin-side file deletes.
   
    This also fixes the script command to capture all stderr, instead of
    that from just the last command.
   
    For simplicity, removed argument support from scripts, and hard code
    perfetto port. This could be fixed by adding back arg support if
    needed.
   
    Relnote: "Improved safety of all internal shell commands by validating
    all output/errors."
   
    Change-Id: I5984d1f7f176e47445264998250add7c27c5418c

M       benchmark/benchmark-common/src/androidTest/java/androidx/benchmark/OutputsTest.kt
M       benchmark/benchmark-common/src/androidTest/java/androidx/benchmark/ShellBehaviorTest.kt
M       benchmark/benchmark-common/src/androidTest/java/androidx/benchmark/ShellTest.kt
M       benchmark/benchmark-common/src/androidTest/java/androidx/benchmark/perfetto/AtraceTagTest.kt
M       benchmark/benchmark-common/src/main/java/androidx/benchmark/Profiler.kt
M       benchmark/benchmark-common/src/main/java/androidx/benchmark/PropOverride.kt
M       benchmark/benchmark-common/src/main/java/androidx/benchmark/Shell.kt
M       benchmark/benchmark-common/src/main/java/androidx/benchmark/perfetto/PerfettoCapture.kt
M       benchmark/benchmark-common/src/main/java/androidx/benchmark/perfetto/PerfettoCaptureWrapper.kt
M       benchmark/benchmark-common/src/main/java/androidx/benchmark/perfetto/PerfettoHelper.kt
M       benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/CompilationModeTest.kt
M       benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/MacrobenchmarkScopeTest.kt
M       benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/perfetto/PerfettoSdkHandshakeTest.kt
M       benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/perfetto/PerfettoTraceProcessorTest.kt
M       benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/BaselineProfiles.kt
M       benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/CompilationMode.kt
M       benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/MacrobenchmarkScope.kt
M       benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/Metric.kt
M       benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/PowerRail.kt
M       benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/ProfileInstallBroadcast.kt
M       benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/perfetto/PerfettoTraceProcessor.kt
M       benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/perfetto/server/PerfettoHttpServer.kt
M       benchmark/integration-tests/macrobenchmark/src/androidTest/java/androidx/benchmark/integration/macrobenchmark/CompilationModeTest.kt
M       benchmark/integration-tests/macrobenchmark/src/androidTest/java/androidx/benchmark/integration/macrobenchmark/PerfettoTraceProcessorBenchmark.kt

https://android-review.googlesource.com/2267992