Stabilise overscroll APIs [255554340]

Fixed

Feature Request

Status Update

No update yet.

Description

lp...@google.com

created issue #1

Oct 25, 2022 02:58PM

Overscroll APIs should be made stable, and scroll-related APIs (lazy list / scrollable / verticalScroll / etc) should have a reasonable public API story with regards to overscroll customization / behaviour.

Ongoing tasks / areas to explore:

Removing enabled from the API surface, and changing it so that things that dispatch overscroll delta (such as scrollable) only dispatch delta if they are at the edge of the list (i.e, the overscroll is enabled) - overscroll shouldn't own this state
Splitting the 'controller' and the 'effect' into two parts, to separate responsibilities between the state machine and the visual effect that is drawn, which may be drawn in different bounds to the actual scrollable component that handles deltas

Comments

ap...@google.com <ap...@google.com> #2Nov 18, 2022 02:35PM

Can you please attach a minimal repro, and provide more information about the system (device etc.) The fonts in the screenshots are different and I do not know how to reproduce the error.

ap...@google.com <ap...@google.com> #3Jan 16, 2023 03:42PM

Hello!

I created a small sample to replicate the issue. It looks like the font family selector is not able to pick the correct weight when the medium font is in the family. I used the Butler to replicate the issue, but I could get the same behaviour with many proprietary fonts with ExtraLigth weight.

It looks like the issue is not present in Android 10 and 11.

lp...@google.com <lp...@google.com> #4Oct 10, 2024 11:31PM

Project: platform/frameworks/support
Branch: androidx-main

commit f6fd709160fbc240e49710c9b248cd14394f64e2
Author: haoyu <haoyuchang@google.com>
Date: Fri Feb 05 17:28:12 2021

Fix: font weight might not work under API 28

Bug: 177423444
Test: ./gradlew test
Test: ./gradlew compose:ui:ui-text:connectedAndroidTest
RelNote: "FontSpan and FontWeigthStyleSpan are no longer used and removed."
Change-Id: Ie5b5611883bc6a44577ae47572754f3d988526ba

M compose/ui/ui-text/api/current.txt
M compose/ui/ui-text/api/public_plus_experimental_current.txt
M compose/ui/ui-text/api/restricted_current.txt
M compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/platform/AndroidParagraphTest.kt
A compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/platform/SpannableExtensionsTest.kt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/platform/extensions/SpannableExtensions.kt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/platform/extensions/TextPaintExtensions.kt
D text/text/src/androidTest/java/androidx/compose/ui/text/android/style/FontSpanTest.kt
D text/text/src/androidTest/java/androidx/compose/ui/text/android/style/FontWeightStyleSpanTest.kt
D text/text/src/main/java/androidx/compose/ui/text/android/style/FontSpan.kt
D text/text/src/main/java/androidx/compose/ui/text/android/style/FontWeightStyleSpan.kt

https://android-review.googlesource.com/1579109

ap...@google.com <ap...@google.com> #5Oct 17, 2024 02:13PM

In which version that fix is available? That issue appears on version 1.0.5.

ap...@google.com <ap...@google.com> #6Oct 17, 2024 02:13PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Louis Pullen-Freilich <lpf@google.com>
Link: https://android-review.googlesource.com/3310015

Adds OverscrollFactory and LocalOverscrollFactory

Expand for full commit details

Adds OverscrollFactory and LocalOverscrollFactory

These APIs allow configuring the overscroll used by components within a hierarchy.

Also adds rememberOverscrollEffect to remember an OverscrollEffect from the current provided OverscrollFactory.

Bug: b/255554340
Bug: b/234451516
Test: OverscrollTest
Relnote: "Adds OverscrollFactory and LocalOverscrollFactory APIs to allow configuring overscroll within a hierarchy. The value provided through LocalOverscrollFactory will be used by default to create an OverscrollEffect. To create and remember an effect from the current provided factory, use rememberOverscrollEffect()."
Change-Id: I51ca476f3efcf0249640873f74cf7d40beebb788

Files:

M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/OverscrollTest.kt
M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/AndroidOverscroll.android.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Overscroll.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/gestures/Scrollable.kt
M compose/foundation/foundation/src/commonStubsMain/kotlin/androidx/compose/foundation/DesktopOverscroll.commonStubs.kt

Hash: bbd406abf997857a050498d58bc85880832599aa
Date: Tue Oct 15 17:10:01 2024

ap...@google.com <ap...@google.com> #7Oct 30, 2024 05:03PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Louis Pullen-Freilich <lpf@google.com>
Link: https://android-review.googlesource.com/3303961

Changes OverscrollEffect Modifier API to a DelegatableNode

Expand for full commit details

Changes OverscrollEffect Modifier API to a DelegatableNode 
 
This is more consistent with other APIs such as IndicationNodeFactory, and enables future performance optimizations. 
 
Test: OverscrollTest 
Bug: b/255554340 
Relnote: "Changed the effectModifier property on OverscrollEffect to be node: DelegatableNode, consistent with other APIs." 
Change-Id: Ic0b46a80aa7d9426ced0731531b3492093e1654e

Files:

M compose/foundation/foundation/api/current.ignore
M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/restricted_current.ignore
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/integration-tests/lazy-tests/src/androidTest/kotlin/androidx/compose/foundation/BaseLazyLayoutTestWithOrientation.kt
M compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/OverscrollSample.kt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/OverscrollTest.kt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/ScrollTest.kt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/ScrollingContainerTest.kt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/anchoredDraggable/AnchoredDraggableOverscrollTest.kt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/pager/PagerTest.kt
M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/AndroidOverscroll.android.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Overscroll.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Scroll.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/ScrollingContainer.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/lazy/LazyDsl.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/lazy/grid/LazyGridDsl.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/lazy/staggeredgrid/LazyStaggeredGridDsl.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/pager/Pager.kt

Hash: 64e9712c422f704b87f198d578261622b7e0f224
Date: Fri Oct 11 00:23:56 2024

ap...@google.com <ap...@google.com> #8Oct 31, 2024 04:12PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Louis Pullen-Freilich <lpf@google.com>
Link: https://android-review.googlesource.com/3325574

Removes OverscrollConfiguration, adds rememberPlatformOverscrollFactory

Expand for full commit details

Removes OverscrollConfiguration, adds rememberPlatformOverscrollFactory 
 
Bug: b/255554340 
Fixes: b/234451516 
Test: updateApi 
Relnote: "Removes OverscrollConfiguration and LocalOverscrollConfiguration, and adds rememberPlatformOverscrollFactory to create an instance of / customize parameters of the default overscroll implementation. To disable overscroll, instead of `LocalOverscrollConfiguration provides null`, use `LocalOverscrollFactory provides null`. To change the glow color / padding, instead of `LocalOverscrollConfiguration provides OverscrollConfiguration(myColor, myPadding)`, use `LocalOverscrollFactory provides rememberPlatformOverscrollFactory(myColor, myPadding)`." 
Change-Id: Ie71f9a016face13262f4fe16ac56c40a0d6f9712

Files:

M compose/foundation/foundation/api/current.ignore
M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/restricted_current.ignore
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/integration-tests/lazy-tests/src/androidTest/kotlin/androidx/compose/foundation/lazy/grid/LazyGridTest.kt
M compose/foundation/foundation/integration-tests/lazy-tests/src/androidTest/kotlin/androidx/compose/foundation/lazy/staggeredgrid/LazyStaggeredGridInLookaheadTest.kt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/pager/BasePagerTest.kt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/pager/SingleParamBasePagerTest.kt
M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/AndroidOverscroll.android.kt
D compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/OverscrollConfiguration.android.kt
M compose/ui/ui-test/src/androidInstrumentedTest/kotlin/androidx/compose/ui/test/ComposeUiTestTest.kt
M compose/ui/ui-test/src/androidUnitTest/kotlin/androidx/compose/ui/test/RobolectricComposeTest.kt
M wear/compose/compose-foundation/build.gradle
M wear/compose/compose-foundation/src/androidTest/kotlin/androidx/wear/compose/foundation/rotary/RotaryTest.kt

Hash: 5556a50c11b544d5638bd88b1a3a20097e8d1152
Date: Wed Oct 30 19:30:40 2024

ap...@google.com <ap...@google.com> #9Nov 1, 2024 05:00PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main
Author: Louis Pullen-Freilich <lpf@google.com>
Link: https://android-review.googlesource.com/3328184

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling

Expand for full commit details

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling 
 
These APIs allow overscroll to have events dispatched to it by one component, and rendered in a separate component. 
 
Fixes: b/266550551 
Fixes: b/204650733 
Fixes: b/255554340 
Fixes: b/229537244 
Test: OverscrollTest 
Relnote: "Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling APIs - these APIs create a wrapped instance of the provided overscroll effect that doesn't draw / handle events respectively, which allows for rendering  overscroll in a separate component from the component that is dispatching events. For example, disabling drawing the overscroll inside a lazy list, and then drawing the overscroll separately on top / elsewhere." 
Change-Id: Idbb3d91546b49c1987a041f959bce4b2b09a9f61

Files:

M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/OverscrollDemo.kt
M compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/OverscrollSample.kt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/OverscrollTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Overscroll.kt

Hash: f64e25b7a473c757d080521e7dd97b3f6670f60d
Date: Fri Nov 01 18:43:56 2024

na...@google.com <na...@google.com> #10Nov 13, 2024 06:19PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.foundation:foundation:1.8.0-alpha06
androidx.compose.foundation:foundation-android:1.8.0-alpha06
androidx.compose.foundation:foundation-jvmstubs:1.8.0-alpha06
androidx.compose.foundation:foundation-linuxx64stubs:1.8.0-alpha06
androidx.compose.ui:ui-test:1.8.0-alpha06
androidx.compose.ui:ui-test-android:1.8.0-alpha06
androidx.compose.ui:ui-test-jvmstubs:1.8.0-alpha06
androidx.compose.ui:ui-test-linuxx64stubs:1.8.0-alpha06
androidx.wear.compose:compose-foundation:1.5.0-alpha06

Issue 255554340

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2Nov 18, 2022 02:35PM

ap...@google.com <ap...@google.com> #3Jan 16, 2023 03:42PM

lp...@google.com <lp...@google.com> #4Oct 10, 2024 11:31PM

ap...@google.com <ap...@google.com> #5Oct 17, 2024 02:13PM

ap...@google.com <ap...@google.com> #6Oct 17, 2024 02:13PM

ap...@google.com <ap...@google.com> #7Oct 30, 2024 05:03PM

ap...@google.com <ap...@google.com> #8Oct 31, 2024 04:12PM

ap...@google.com <ap...@google.com> #9Nov 1, 2024 05:00PM

na...@google.com <na...@google.com> #10Nov 13, 2024 06:19PM

Add comment

Issue metadata