Stabilise overscroll APIs [255554340]

Fixed

Feature Request

Status Update

No update yet.

Description

lp...@google.com

created issue #1

Oct 25, 2022 02:58PM

Overscroll APIs should be made stable, and scroll-related APIs (lazy list / scrollable / verticalScroll / etc) should have a reasonable public API story with regards to overscroll customization / behaviour.

Ongoing tasks / areas to explore:

Removing enabled from the API surface, and changing it so that things that dispatch overscroll delta (such as scrollable) only dispatch delta if they are at the edge of the list (i.e, the overscroll is enabled) - overscroll shouldn't own this state
Splitting the 'controller' and the 'effect' into two parts, to separate responsibilities between the state machine and the visual effect that is drawn, which may be drawn in different bounds to the actual scrollable component that handles deltas

Comments

ap...@google.com <ap...@google.com> #2Nov 18, 2022 02:35PM

We have some support in androidx.compose.ui.autofill

Leaving this bug open in case Ralston wants to add more info

ap...@google.com <ap...@google.com> #3Jan 16, 2023 03:42PM

I found an example here. One problem is that it only works with the Google autofill service. When using any other service like Microsoft Authenticator or OneKey, the following error is shown:

D/Autofill Status: Autofill popup isn't shown because autofill is not available.
    
    Did you set up autofill?
    1. Go to Settings > System > Languages&input > Advanced > Autofill Service
    2. Pick a service
    
    Did you add an account?
    1. Go to Settings > System > Languages&input > Advanced
    2. Click on the settings icon next to the Autofill Service
    3. Add your account

Is this a bug on your side or do the app developers of these password managers need to change their implementation?

lp...@google.com <lp...@google.com> #4Oct 10, 2024 11:31PM

Another problem I am facing with autofill is that it won't save my credentials. I tried forcing to finish the context as described here, but it won't do that either although I filled in the username with the one provided by the Google autofill service.

ap...@google.com <ap...@google.com> #5Oct 17, 2024 02:13PM

deleted

ap...@google.com <ap...@google.com> #6Oct 17, 2024 02:13PM

Facing the same issue here, Google autofill service seems to work. Zero documentation on adding support for Autofill framework on jetpack compose.

ap...@google.com <ap...@google.com> #7Oct 30, 2024 05:03PM

Hello, I am trying to implement the same thing - it seems like there's no way for current password managers like 1Password or Bitwarden, to automatically pick up the fields. Is there a possible solution?

ap...@google.com <ap...@google.com> #8Oct 31, 2024 04:12PM

I setup this modifier:

@OptIn(ExperimentalComposeUiApi::class)
fun Modifier.autofill(
    autofillTypes: List<AutofillType>,
    onFill: ((String) -> Unit),
) = composed {
    val autofill = LocalAutofill.current
    val autofillNode = AutofillNode(onFill = onFill, autofillTypes = autofillTypes)
    LocalAutofillTree.current += autofillNode

    this.onGloballyPositioned {
        autofillNode.boundingBox = it.boundsInWindow()
    }.onFocusChanged { focusState ->
        autofill?.run {
            if (focusState.isFocused) {
                requestAutofillForNode(autofillNode)
            } else {
                cancelAutofillForNode(autofillNode)
            }
        }
    }
}

And use it like this:

val emailState = remember { EmailState() }
Email(
    modifier = Modifier.autofill(
        autofillTypes = listOf(
            AutofillType.Username,
            AutofillType.EmailAddress
        ),
        onFill = { emailState.text = it },
    ),
    emailState = emailState,
    onImeAction = { onForgotPasswordSubmitted(emailState.text) }
)

With these steps, autofill works for me.

ap...@google.com <ap...@google.com> #9Nov 1, 2024 05:00PM

Marked as fixed.

@lo...@gmail.com comment#8

what version of compose are you using? I'm using latest alpha and the above doesn't work for me. 😭

na...@google.com <na...@google.com> #10Nov 13, 2024 06:19PM

Works perfectly fine on the latest stable and alpha versions. Did you check in my second comment if you enabled everything?