UIAutomator 2.2 By.text and multiline text issue [255787130]

Fixed

Bug

Status Update

No update yet.

Description

to...@gmail.com

created issue #1

Oct 27, 2022 07:26AM

Artifact used (ex. androidx.appcompat:appcompat:1.0.0-alpha1): UIAutomator Version used: 2.2.0

I have a simple Compose UI with a Text(text = "$title\n ")

UIAutomator dump says: <node index="0" text="All albums
 " resource-id="" ...

This element can't be find with the current By.textContains and By.textStartsWith. I'm not regex expert but I think the $ without enabling multiline in the regexp is the cause.

Comments

pe...@google.com <pe...@google.com> #2Nov 2, 2022 12:04AM

Status: Won't Fix (Intended Behavior)

I simpler example would be appreciated. I tried to download the pull request and build it but it relies on, for example, `rustc` to be installed which I don't have installed on my compose development machine.

Does the program work without the compiler switch. That is, is `"-P", "plugin:androidx.compose.compiler.plugins.kotlin:experimentalStrongSkipping=true",` required to reproduce or is just changing the runtime enough?

to...@gmail.com <to...@gmail.com> #3Nov 2, 2022 07:49AM

Yeah, changing compiler switch(enable/disable StrongSkipping, enable/disable nonSkippingGroup) has no effect, only changing runtime make sense.
Sorry for that, I will try to extract an example when I'm free.

ap...@google.com <ap...@google.com> #4Nov 3, 2022 01:16AM

I have find a sample code to reproduce that

        setContent {
            val dialogState = remember { DialogState() }
            dialogState.Intercept()
            LaunchedEffect(Unit) {
                delay(1000)
                dialogState.bgWork {
                    delay(5000)
                }
                dialogState.showSelectActions {
                    onSelect("a") {

                    }
                    onSelect("b") {

                    }
                }
            }
        }

You can find implementation of DialogState here https://github.com/FooIbar/EhViewer/blob/ef16bdeb755ae888c74eaa4a337bd5b708fcc97e/app/src/main/kotlin/com/hippo/ehviewer/ui/tools/Dialog.kt#L92
https://github.com/FooIbar/EhViewer/blob/main/app/src/main/kotlin/com/hippo/ehviewer/util/Progress.kt Launch that Activity, wait 6 seconds and it will crash

pe...@google.com <pe...@google.com> #5Nov 3, 2022 01:19AM

Marked as fixed.

Let me sort it out

The first crash
Reproduce: navigate to a gallery and navigate back
The reason is we have some code assume the forget order of RememberObserver(DisposableEffect), and 52835066c9044647a65dfb566f03131aab46e793 changed the order. Seems this is a intended behaviour.
I will fix it from my side. My bad

The second crash
Reproduce: #4 comment
StackTrace: https://bin.kv2.dev/~65d5c6175de7ed6bfdbdf1bd
We got a wrong object from SlotTable during recompose

to...@gmail.com <to...@gmail.com> #6Nov 3, 2022 07:47AM

And interestingly, if we insert delay(1000) between two dialog suspend usage

                dialogState.bgWork {
                    delay(5000)
                }
                delay(1000)
                dialogState.showSelectActions {
                    onSelect("a") {

                    }
                    onSelect("b") {

                    }
                }

It will not crash

na...@google.com <na...@google.com> #7Jan 11, 2023 08:11PM

Can you use "Build/Analyze APK..." and let me know what module version is reported for the compose related modules?

As for the order of `onForgotten`, it may be you are seeing and issue that I fixed in a subsequent version as this, for the snapshot builds, was broken for a few weeks when using the non-skipping group optimization even indirectly.

Issue 255787130