Leanback RowsSupportFragment when moving to another activity [255822479]

Assigned

Bug

Status Update

No update yet.

Description

mo...@gmail.com

created issue #1

Oct 27, 2022 10:30AM

Component used: RowsSupportFragment Version used: 1.0.0 Devices/Android versions reproduced on: The problem appears on Crashlytics on all different devices. For all android versions.

BRAVIA 4K GB ATV3 (Android 10) BRAVIA VH1 (Android 10) AFTSSS (Android 9) AFTSS (Android 9) And many many other Android TV devices

If this is a bug in the library, we would appreciate if you could attach:

Steps to reproduce.

Create an activity
Add a RowsSupprtFragment
Start a new activity
Release, and monitor the app in Crashlytics
This bug shows up.

I'm sorry I couldn't reproduce the bug reliably.

Fatal Exception: java.lang.NullPointerException: Attempt to invoke virtual method 'void androidx.recyclerview.widget.RecyclerView$Recycler.unscrapView(androidx.recyclerview.widget.RecyclerView$ViewHolder)' on a null object reference
       at androidx.recyclerview.widget.RecyclerView$ViewHolder.unScrap(RecyclerView.java:11596)
       at androidx.recyclerview.widget.RecyclerView$Recycler.tryGetViewHolderForPositionByDeadline(RecyclerView.java:6347)
       at androidx.recyclerview.widget.RecyclerView$Recycler.getViewForPosition(RecyclerView.java:6300)
       at androidx.recyclerview.widget.RecyclerView$Recycler.getViewForPosition(RecyclerView.java:6296)
       at androidx.leanback.widget.GridLayoutManager.getViewForPosition(GridLayoutManager.java:1143)
       at androidx.leanback.widget.GridLayoutManager.fastRelayout(GridLayoutManager.java:2041)
       at androidx.leanback.widget.GridLayoutManager.onLayoutChildren(GridLayoutManager.java:2316)
       at androidx.recyclerview.widget.RecyclerView.dispatchLayoutStep2(RecyclerView.java:4309)
       at androidx.recyclerview.widget.RecyclerView.dispatchLayout(RecyclerView.java:4012)
       at androidx.recyclerview.widget.RecyclerView.onLayout(RecyclerView.java:4578)
       at android.view.View.layout(View.java:20672)
       at android.view.ViewGroup.layout(ViewGroup.java:6194)
       at android.widget.FrameLayout.layoutChildren(FrameLayout.java:323)
       at android.widget.FrameLayout.onLayout(FrameLayout.java:261)
       at android.view.View.layout(View.java:20672)
       at android.view.ViewGroup.layout(ViewGroup.java:6194)
       at android.widget.FrameLayout.layoutChildren(FrameLayout.java:323)
       at android.widget.FrameLayout.onLayout(FrameLayout.java:261)
       at android.view.View.layout(View.java:20672)
       at android.view.ViewGroup.layout(ViewGroup.java:6194)
       at android.widget.FrameLayout.layoutChildren(FrameLayout.java:323)
       at android.widget.FrameLayout.onLayout(FrameLayout.java:261)
       at android.view.View.layout(View.java:20672)
       at android.view.ViewGroup.layout(ViewGroup.java:6194)
       at android.widget.FrameLayout.layoutChildren(FrameLayout.java:323)
       at android.widget.FrameLayout.onLayout(FrameLayout.java:261)
       at android.view.View.layout(View.java:20672)
       at android.view.ViewGroup.layout(ViewGroup.java:6194)
       at android.widget.FrameLayout.layoutChildren(FrameLayout.java:323)
       at android.widget.FrameLayout.onLayout(FrameLayout.java:261)
       at android.view.View.layout(View.java:20672)
       at android.view.ViewGroup.layout(ViewGroup.java:6194)
       at android.widget.FrameLayout.layoutChildren(FrameLayout.java:323)
       at android.widget.FrameLayout.onLayout(FrameLayout.java:261)
       at android.view.View.layout(View.java:20672)
       at android.view.ViewGroup.layout(ViewGroup.java:6194)
       at android.widget.FrameLayout.layoutChildren(FrameLayout.java:323)
       at android.widget.FrameLayout.onLayout(FrameLayout.java:261)
       at android.view.View.layout(View.java:20672)
       at android.view.ViewGroup.layout(ViewGroup.java:6194)
       at android.widget.LinearLayout.setChildFrame(LinearLayout.java:1812)
       at android.widget.LinearLayout.layoutVertical(LinearLayout.java:1656)
       at android.widget.LinearLayout.onLayout(LinearLayout.java:1565)
       at android.view.View.layout(View.java:20672)
       at android.view.ViewGroup.layout(ViewGroup.java:6194)
       at android.widget.FrameLayout.layoutChildren(FrameLayout.java:323)
       at android.widget.FrameLayout.onLayout(FrameLayout.java:261)
       at com.android.internal.policy.DecorView.onLayout(DecorView.java:753)
       at android.view.View.layout(View.java:20672)
       at android.view.ViewGroup.layout(ViewGroup.java:6194)
       at android.view.ViewRootImpl.performLayout(ViewRootImpl.java:2817)
       at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:2318)
       at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:1465)
       at android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:7211)
       at android.view.Choreographer$CallbackRecord.run(Choreographer.java:949)
       at android.view.Choreographer.doCallbacks(Choreographer.java:761)
       at android.view.Choreographer.doFrame(Choreographer.java:696)
       at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:935)
       at android.os.Handler.handleCallback(Handler.java:873)
       at android.os.Handler.dispatchMessage(Handler.java:99)
       at android.os.Looper.loop(Looper.java:193)
       at android.app.ActivityThread.main(ActivityThread.java:6718)
       at java.lang.reflect.Method.invoke(Method.java)
       at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
       at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:858)

Comments

th...@gmail.com <th...@gmail.com> #2Apr 11, 2024 03:44AM

IMPORTANT! Please note that if you released your library to stable with these calls, the APIs must maintain binary compatibility moving forward.

That means the restricted APIs need to be made public or @RestrictTo(LIBRARY_GROUP_PREFIX) (e.g. effectively public for the purposes of compatibility).

You CANNOT simply remove the call to the restricted API.

gm...@gmail.com <gm...@gmail.com> #3Nov 20, 2024 08:20AM

Sorry, additional point of clarification. These bugs have been filed against the call sites, but the issue really applies to both the restricted API and the call site.

For the call site: the call may be safely removed, however if the call went out in a stable release then that release will crash if the restricted API is removed.

If the restricted API should be maintained to ensure binary compatibility with your library, please forward this issue to the component for the restricted API and continue reading.

For the restricted API: this bug was filed because your API was used outside of your library group. The API must now be tracked for binary compatibility. You may make the API public or LIBRARY_GROUP_PREFIX visibility.

mo...@gmail.com <mo...@gmail.com> #4Nov 20, 2024 09:30AM

No, moved on to another project.

Issue 255822479

Description

Issue summary

Comments

th...@gmail.com <th...@gmail.com> #2Apr 11, 2024 03:44AM

gm...@gmail.com <gm...@gmail.com> #3Nov 20, 2024 08:20AM

mo...@gmail.com <mo...@gmail.com> #4Nov 20, 2024 09:30AM

Add comment

Issue metadata