Placeholder modifier order matters - add docs and sample [256583229]

Fixed

Task

Status Update

No update yet.

Description

jn...@google.com

created issue #1

Oct 31, 2022 11:57AM

The order of Modifier.placeholder() and Modifier.placeholderShimmer() matters when applied to the same component as they are both drawing on the foreground of the component and if they are in the wrong order then the shimmer will not be visible.

Add a sample and make it clear in the documentation that the order matters to help developers.

Comments

jn...@google.com <jn...@google.com> Oct 31, 2022 01:57PM

Accepted by jn...@google.com.

ap...@google.com <ap...@google.com> #2Oct 31, 2022 04:14PM

Project: platform/frameworks/support
Branch: androidx-main

commit 6ebe664e0db444d2602f67a75a4deada37d0a72f
Author: stevebower <stevebower@google.com>
Date: Wed Oct 13 15:26:27 2021

Update transition handling in SwipeDismissableNavHost.

Transitions should reach Lifecycle.State.RESUMED
when animations are complete.

Test: androidx.wear.compose.navigation.

Bug: 202863359

Relnote: "Update transition handling in
SwipeDismissableNavHost"

Change-Id: I1cbe09cd902f785dcb68f11f098b340e4da1e55a

M wear/compose/compose-navigation/build.gradle
M wear/compose/compose-navigation/src/main/java/androidx/wear/compose/navigation/SwipeDismissableNavHost.kt
M wear/compose/compose-navigation/src/androidTest/kotlin/androidx/wear/compose/navigation/SwipeDismissableNavHostTest.kt
M wear/compose/compose-navigation/src/main/java/androidx/wear/compose/navigation/WearNavigator.kt

https://android-review.googlesource.com/1857639

jn...@google.com <jn...@google.com> Nov 1, 2022 11:38AM

Marked as fixed.

na...@google.com <na...@google.com> #3Nov 9, 2022 06:27PM

Project: platform/frameworks/support
Branch: androidx-main

commit d65ce67f974132fad4f26a3f72de6a3b3be2ec0d
Author: stevebower <stevebower@google.com>
Date: Fri Oct 15 09:48:16 2021

Wrap transition handling in SideEffect.

State outside this composable should be
updated in one of the Effect APIs
(as per late comments in aosp/1857639).

Test: androidx.wear.compose.navigation.

Bug: 202863359

Relnote: "Update transition handling in
SwipeDismissableNavHost in a SideEffect"
Change-Id: I04994074e7d024dcf857c156c8c265b57e3769f8

M wear/compose/compose-navigation/src/main/java/androidx/wear/compose/navigation/SwipeDismissableNavHost.kt

https://android-review.googlesource.com/1859213

na...@google.com <na...@google.com> #4Aug 21, 2024 07:55PM

Heads up - I ended up using repeatOnLifecycle(state = Lifecycle.State.STARTED) in some code because repeatOnLifecycle(state = Lifecycle.State.RESUMED) wasn't firing, and Alex mentioned this one.

Will provide a repro offline.

Issue 256583229