Fixed
Status Update
No update yet.
Comments
jn...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 04127ef27c0ff32515f0069bd8a5b86f3786c312
Author: John Nichol <jnichol@google.com>
Date: Mon Oct 31 14:01:51 2022
Placeholder - Add documentation and a sample about placeholder/placeholderShimmer modifier ordering
Spell out in documentation and a sample that the order of the placeholder and placeholderShimmer modifiers is important when applied to the same composable.
Bug: 256583229
Test: ./gradlew :wear:compose:compose-material:connectedCheck --info --daemon
Relnote: "We have added documentation and a sample to placeholders to show the correct ordering for Modifier.placeholder and Modifier.placeholderShimmer when applied to the same composable."
Change-Id: Ie96f47734d5ffe91cfbd1f92e1b67543534be41f
M wear/compose/compose-material/samples/src/main/java/androidx/wear/compose/material/samples/PlaceholderSample.kt
M wear/compose/compose-material/src/commonMain/kotlin/androidx/wear/compose/material/Placeholder.kt
M wear/compose/integration-tests/demos/src/main/java/androidx/wear/compose/integration/demos/MaterialDemos.kt
https://android-review.googlesource.com/2277807
Branch: androidx-main
commit 04127ef27c0ff32515f0069bd8a5b86f3786c312
Author: John Nichol <jnichol@google.com>
Date: Mon Oct 31 14:01:51 2022
Placeholder - Add documentation and a sample about placeholder/placeholderShimmer modifier ordering
Spell out in documentation and a sample that the order of the placeholder and placeholderShimmer modifiers is important when applied to the same composable.
Bug: 256583229
Test: ./gradlew :wear:compose:compose-material:connectedCheck --info --daemon
Relnote: "We have added documentation and a sample to placeholders to show the correct ordering for Modifier.placeholder and Modifier.placeholderShimmer when applied to the same composable."
Change-Id: Ie96f47734d5ffe91cfbd1f92e1b67543534be41f
M wear/compose/compose-material/samples/src/main/java/androidx/wear/compose/material/samples/PlaceholderSample.kt
M wear/compose/compose-material/src/commonMain/kotlin/androidx/wear/compose/material/Placeholder.kt
M wear/compose/integration-tests/demos/src/main/java/androidx/wear/compose/integration/demos/MaterialDemos.kt
jn...@google.com
na...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.wear.compose:compose-material:1.1.0-rc01
na...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.wear.compose:compose-material:1.4.0-rc01
Description
The order of Modifier.placeholder() and Modifier.placeholderShimmer() matters when applied to the same component as they are both drawing on the foreground of the component and if they are in the wrong order then the shimmer will not be visible.
Add a sample and make it clear in the documentation that the order matters to help developers.