Placeholder modifier order matters - add docs and sample [256583229]

Fixed

Task

Status Update

No update yet.

Description

jn...@google.com

created issue #1

Oct 31, 2022 11:57AM

The order of Modifier.placeholder() and Modifier.placeholderShimmer() matters when applied to the same component as they are both drawing on the foreground of the component and if they are in the wrong order then the shimmer will not be visible.

Add a sample and make it clear in the documentation that the order matters to help developers.

Comments

jn...@google.com <jn...@google.com> Oct 31, 2022 01:57PM

Accepted by jn...@google.com.

ap...@google.com <ap...@google.com> #2Oct 31, 2022 04:14PM

A couple of questions:

1. Have you saw crash in real device or only in simulators?
2. Do you use dynamic feature for language ID?

jn...@google.com <jn...@google.com> Nov 1, 2022 11:38AM

Marked as fixed.

na...@google.com <na...@google.com> #3Nov 9, 2022 06:27PM

Tested on Android 12 Emulator with custom executor, but cannot repro this issue.

na...@google.com <na...@google.com> #4Aug 21, 2024 07:55PM

Second crash in the description is from a real device. Experienced it myself on two different Xiaomi phones, plus lots of crashes from users in the Google Play console.
Dynamic features are not used in the application.

As a wild guess, I have downgraded build tools from 31.0.0 to 30.0.3, compileSdk from 31 to 30, and moved all work with Language ID to the service in a separate process (just to be sure that crash can kill secondary process instead of main). This combination is in beta for 2 days by now and I don't see any SIGSEGV crashes.

Issue 256583229