Dex merging error related to global synthetics after upgrading AS Canary 6 to 7 [257488927]

Fixed

Bug

Status Update

No update yet.

Description

cj...@gmail.com

created issue #1

Nov 5, 2022 11:11AM

Build: AI-222.4345.14.2221.9228443, 202210280044, 

AI-222.4345.14.2221.9228443, JRE 17.0.4.1+0-17.0.4.1b469.62-9127311x64 JetBrains s.r.o., OS Mac OS X(aarch64) v13.0, screens 4112.0x2658.0; Retina

AS: Flamingo | 2022.2.1 Canary 7
Kotlin plugin: 222-1.7.20-release-AS3739.54
Android Gradle Plugin: 8.0.0-alpha07
Gradle: 7.5.1
Gradle JDK: Azul Zulu version 17.0.5
NDK: from local.properties: (not specified), latest from SDK: (not found)
CMake: from local.properties: (not specified), latest from SDK: (not found), from PATH: (not found)

Seeing an error updating from AS Canary 06 -> Canary 07

> Task :sampleapp:mergeDebugGlobalSynthetics FAILED
ERROR:D8: com.android.tools.r8.internal.Fd: Dex file with version '37' cannot be used with min sdk level 'L'.
com.android.builder.dexing.DexArchiveMergerException: Error while merging dex archives: 
	at com.android.builder.dexing.D8DexArchiveMerger.getMergingExceptionToRethrow(D8DexArchiveMerger.java:159)
	at com.android.builder.dexing.D8DexArchiveMerger.mergeDexArchives(D8DexArchiveMerger.java:147)
	at com.android.build.gradle.internal.tasks.DexMergingWorkAction.merge(DexMergingTask.kt:893)
	at com.android.build.gradle.internal.tasks.DexMergingWorkAction.run(DexMergingTask.kt:837)
	at com.android.build.gradle.internal.profile.ProfileAwareWorkAction.execute(ProfileAwareWorkAction.kt:74)
	at org.gradle.workers.internal.DefaultWorkerServer.execute(DefaultWorkerServer.java:63)
	at org.gradle.workers.internal.NoIsolationWorkerFactory$1$1.create(NoIsolationWorkerFactory.java:66)
	at org.gradle.workers.internal.NoIsolationWorkerFactory$1$1.create(NoIsolationWorkerFactory.java:62)
	at org.gradle.internal.classloader.ClassLoaderUtils.executeInClassloader(ClassLoaderUtils.java:100)
	at org.gradle.workers.internal.NoIsolationWorkerFactory$1.lambda$execute$0(NoIsolationWorkerFactory.java:62)
	at org.gradle.workers.internal.AbstractWorker$1.call(AbstractWorker.java:44)
	at org.gradle.workers.internal.AbstractWorker$1.call(AbstractWorker.java:41)
	at org.gradle.internal.operations.DefaultBuildOperationRunner$CallableBuildOperationWorker.execute(DefaultBuildOperationRunner.java:204)
	at org.gradle.internal.operations.DefaultBuildOperationRunner$CallableBuildOperationWorker.execute(DefaultBuildOperationRunner.java:199)
	at org.gradle.internal.operations.DefaultBuildOperationRunner$2.execute(DefaultBuildOperationRunner.java:66)
	at org.gradle.internal.operations.DefaultBuildOperationRunner$2.execute(DefaultBuildOperationRunner.java:59)
	at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:157)
	at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:59)
	at org.gradle.internal.operations.DefaultBuildOperationRunner.call(DefaultBuildOperationRunner.java:53)
	at org.gradle.internal.operations.DefaultBuildOperationExecutor.call(DefaultBuildOperationExecutor.java:73)
	at org.gradle.workers.internal.AbstractWorker.executeWrappedInBuildOperation(AbstractWorker.java:41)
	at org.gradle.workers.internal.NoIsolationWorkerFactory$1.execute(NoIsolationWorkerFactory.java:59)
	at org.gradle.workers.internal.DefaultWorkerExecutor.lambda$submitWork$2(DefaultWorkerExecutor.java:205)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at org.gradle.internal.work.DefaultConditionalExecutionQueue$ExecutionRunner.runExecution(DefaultConditionalExecutionQueue.java:187)
	at org.gradle.internal.work.DefaultConditionalExecutionQueue$ExecutionRunner.access$700(DefaultConditionalExecutionQueue.java:120)
	at org.gradle.internal.work.DefaultConditionalExecutionQueue$ExecutionRunner$1.run(DefaultConditionalExecutionQueue.java:162)
	at org.gradle.internal.Factories$1.create(Factories.java:31)
	at org.gradle.internal.work.DefaultWorkerLeaseService.withLocks(DefaultWorkerLeaseService.java:249)
	at org.gradle.internal.work.DefaultWorkerLeaseService.runAsWorkerThread(DefaultWorkerLeaseService.java:109)
	at org.gradle.internal.work.DefaultWorkerLeaseService.runAsWorkerThread(DefaultWorkerLeaseService.java:114)
	at org.gradle.internal.work.DefaultConditionalExecutionQueue$ExecutionRunner.runBatch(DefaultConditionalExecutionQueue.java:157)
	at org.gradle.internal.work.DefaultConditionalExecutionQueue$ExecutionRunner.run(DefaultConditionalExecutionQueue.java:126)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:64)
	at org.gradle.internal.concurrent.ManagedExecutorImpl$1.run(ManagedExecutorImpl.java:48)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
	at java.base/java.lang.Thread.run(Thread.java:833)
Caused by: com.android.tools.r8.CompilationFailedException: Compilation failed to complete
	at Version.fakeStackEntry(Version_8.0.13-dev.java:0)
	at com.android.tools.r8.internal.lk.a(R8_8.0.13-dev_bb509a332302ce14b741440237b3ab159c593fe1d96de33a4c0b36c664cebf5f:74)
	at com.android.tools.r8.internal.lk.a(R8_8.0.13-dev_bb509a332302ce14b741440237b3ab159c593fe1d96de33a4c0b36c664cebf5f:27)
	at com.android.tools.r8.internal.lk.a(R8_8.0.13-dev_bb509a332302ce14b741440237b3ab159c593fe1d96de33a4c0b36c664cebf5f:26)
	at com.android.tools.r8.internal.lk.b(R8_8.0.13-dev_bb509a332302ce14b741440237b3ab159c593fe1d96de33a4c0b36c664cebf5f:2)
	at com.android.tools.r8.D8.run(R8_8.0.13-dev_bb509a332302ce14b741440237b3ab159c593fe1d96de33a4c0b36c664cebf5f:11)
	at com.android.builder.dexing.D8DexArchiveMerger.mergeDexArchives(D8DexArchiveMerger.java:145)
	... 38 more
Caused by: com.android.tools.r8.internal.Fd: Dex file with version '37' cannot be used with min sdk level 'L'.
	at com.android.tools.r8.dex.c.a(R8_8.0.13-dev_bb509a332302ce14b741440237b3ab159c593fe1d96de33a4c0b36c664cebf5f:125)
	at com.android.tools.r8.dex.a.b(R8_8.0.13-dev_bb509a332302ce14b741440237b3ab159c593fe1d96de33a4c0b36c664cebf5f:18)
	at com.android.tools.r8.dex.a.b(R8_8.0.13-dev_bb509a332302ce14b741440237b3ab159c593fe1d96de33a4c0b36c664cebf5f:44)
	at com.android.tools.r8.dex.c.a(R8_8.0.13-dev_bb509a332302ce14b741440237b3ab159c593fe1d96de33a4c0b36c664cebf5f:40)
	at com.android.tools.r8.dex.c.a(R8_8.0.13-dev_bb509a332302ce14b741440237b3ab159c593fe1d96de33a4c0b36c664cebf5f:9)
	at com.android.tools.r8.dex.c.a(R8_8.0.13-dev_bb509a332302ce14b741440237b3ab159c593fe1d96de33a4c0b36c664cebf5f:8)
	at com.android.tools.r8.D8.a(R8_8.0.13-dev_bb509a332302ce14b741440237b3ab159c593fe1d96de33a4c0b36c664cebf5f:29)
	at com.android.tools.r8.D8.d(R8_8.0.13-dev_bb509a332302ce14b741440237b3ab159c593fe1d96de33a4c0b36c664cebf5f:17)
	at com.android.tools.r8.D8.b(R8_8.0.13-dev_bb509a332302ce14b741440237b3ab159c593fe1d96de33a4c0b36c664cebf5f:1)
	at com.android.tools.r8.internal.lk.a(R8_8.0.13-dev_bb509a332302ce14b741440237b3ab159c593fe1d96de33a4c0b36c664cebf5f:23)
	... 41 more

It goes away if I disable the globalSynthetics task via android.enableGlobalSyntheticsGeneration=false

Comments

cj...@gmail.com <cj...@gmail.com> #2Nov 6, 2022 10:34AM

The snapshot shows that it's coming from calling getFiles on the FileCollection returned by the scoped artifacts (here).

I think the issue may be due to how we build these file collection and how we filter things from it to list of Directory or REgularFile.

ku...@google.com <ku...@google.com> Nov 7, 2022 10:54PM

Assigned to an...@google.com.

sg...@google.com <sg...@google.com> Nov 8, 2022 08:31AM

Reassigned to sg...@google.com.

ze...@google.com <ze...@google.com> #3Nov 8, 2022 08:39AM

Actually these transforms are only ~40% of the time spend in there, but it's still a hot spot that we should resolve by not using a FileCollection

sg...@google.com <sg...@google.com> #4Nov 8, 2022 01:12PM

Reassigned to bi...@google.com.

xav@ could you assign this bug to someone to make sure it gets fixed?

cj...@gmail.com <cj...@gmail.com> #5Nov 8, 2022 01:31PM

Jerome will do that for you :)

cj...@gmail.com <cj...@gmail.com> #6Nov 20, 2022 02:42AM

Bingran, can you have a look at this asap. thx !

bi...@google.com <bi...@google.com> Nov 22, 2022 06:06PM

Accepted by bi...@google.com.

bi...@google.com <bi...@google.com> #7Nov 22, 2022 08:29PM

To make sure I analyze the "buildOnServer-7.5-rc-2-2022-07-01-shutdown.snapshot" correctly, I attached a screenshot of how I find the concerning point. From the picture, the MergeGeneratedProguardFilesCreationAction takes 1924ms. Is that the right way to check your snapshot file? If so, what is the expected time for that creation action in a config cached build?

bi...@google.com <bi...@google.com> Nov 22, 2022 11:15PM

Marked as fixed.

ub...@gmail.com <ub...@gmail.com> #8Feb 10, 2023 03:52PM

I think you missed adding an attachment.

bi...@google.com <bi...@google.com> #9Feb 10, 2023 06:17PM

oops, here it is =)