Fixed
Status Update
No update yet.
Comments
lo...@gmail.com
Comment has been deleted.
il...@google.com
cl...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
https://android-review.googlesource.com/1288456
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 51abbcb6c4ae624a0c3a0f5b49b5790d9a121151
Author: Clara Fok <clarafok@google.com>
Date: Thu Jan 05 17:20:18 2023
Expose DialogFragmentNavigator backstack internally
Test: n/a
Bug: 257519195
Change-Id: I1d89cb108ffa3ad9b04b20b3cf81bed77253134f
M navigation/navigation-fragment/src/main/java/androidx/navigation/fragment/DialogFragmentNavigator.kt
https://android-review.googlesource.com/2378092
Branch: androidx-main
commit 51abbcb6c4ae624a0c3a0f5b49b5790d9a121151
Author: Clara Fok <clarafok@google.com>
Date: Thu Jan 05 17:20:18 2023
Expose DialogFragmentNavigator backstack internally
Test: n/a
Bug: 257519195
Change-Id: I1d89cb108ffa3ad9b04b20b3cf81bed77253134f
M navigation/navigation-fragment/src/main/java/androidx/navigation/fragment/DialogFragmentNavigator.kt
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit d306d15d40c7f029be99c2d207a2ecd7fe0ec9ef
Author: Clara Fok <clarafok@google.com>
Date: Tue Jan 03 15:35:11 2023
Expose ComposeNavigator internal APIs publically
We want to enable implementations of ComposeNavigator by exposing backstack and #onTransitionComplete APIs publically.
Test: n/a
Bug: 257519195
Relnote: "You can now access the backstack associated with ComposeNavigator by calling ComposeNavigator.backStack. onTransitionComplete() callback is also now a public API to mark a NavBackStackEntry as transition complete after a navigate/popBackStack operation."
Change-Id: I718dbcf2549d755b283292002cdfd9df9dc4bf26
M navigation/navigation-compose/api/current.txt
M navigation/navigation-compose/api/public_plus_experimental_current.txt
M navigation/navigation-compose/api/restricted_current.txt
M navigation/navigation-compose/src/main/java/androidx/navigation/compose/ComposeNavigator.kt
https://android-review.googlesource.com/2374988
Branch: androidx-main
commit d306d15d40c7f029be99c2d207a2ecd7fe0ec9ef
Author: Clara Fok <clarafok@google.com>
Date: Tue Jan 03 15:35:11 2023
Expose ComposeNavigator internal APIs publically
We want to enable implementations of ComposeNavigator by exposing backstack and #onTransitionComplete APIs publically.
Test: n/a
Bug: 257519195
Relnote: "You can now access the backstack associated with ComposeNavigator by calling ComposeNavigator.backStack. onTransitionComplete() callback is also now a public API to mark a NavBackStackEntry as transition complete after a navigate/popBackStack operation."
Change-Id: I718dbcf2549d755b283292002cdfd9df9dc4bf26
M navigation/navigation-compose/api/current.txt
M navigation/navigation-compose/api/public_plus_experimental_current.txt
M navigation/navigation-compose/api/restricted_current.txt
M navigation/navigation-compose/src/main/java/androidx/navigation/compose/ComposeNavigator.kt
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit e8cbb84db39ff712011f83f14e65ee6a318f8a33
Author: Clara Fok <clarafok@google.com>
Date: Wed Feb 15 12:35:39 2023
Expose FragmentNavigation backstack
Expose internally for testing purposes
Test: n/a
Bug: 257519195
Change-Id: Iec82ea2103b80b17eaf8b49f11704cbe198dde81
M navigation/navigation-fragment/src/main/java/androidx/navigation/fragment/FragmentNavigator.kt
https://android-review.googlesource.com/2438993
Branch: androidx-main
commit e8cbb84db39ff712011f83f14e65ee6a318f8a33
Author: Clara Fok <clarafok@google.com>
Date: Wed Feb 15 12:35:39 2023
Expose FragmentNavigation backstack
Expose internally for testing purposes
Test: n/a
Bug: 257519195
Change-Id: Iec82ea2103b80b17eaf8b49f11704cbe198dde81
M navigation/navigation-fragment/src/main/java/androidx/navigation/fragment/FragmentNavigator.kt
cl...@google.com
This bug is considered fixed for now. Separate bugs can be filed if specific APIs need to be opened up in the future.
The opened up APIs are available in navigation 2.6.0-beta01
Description
It is possible to open up the Navigator APIs so that they are more accessible. Specifically things like their back stack which are currently internal. Opening these up would give developers the ability to more easily create custom behavior based on our default Navigators vs always needing the implement their own.