Fixed
Status Update
No update yet.
Comments
lo...@gmail.com
Comment has been deleted.
il...@google.com
cl...@google.com
since it is already marked as deprecated, we can probably do it by now.
ap...@google.com
Opening diff shortly
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request fromhttps://github.com/androidx/androidx/pull/61 .
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
https://android-review.googlesource.com/1396827
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request from
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit d306d15d40c7f029be99c2d207a2ecd7fe0ec9ef
Author: Clara Fok <clarafok@google.com>
Date: Tue Jan 03 15:35:11 2023
Expose ComposeNavigator internal APIs publically
We want to enable implementations of ComposeNavigator by exposing backstack and #onTransitionComplete APIs publically.
Test: n/a
Bug: 257519195
Relnote: "You can now access the backstack associated with ComposeNavigator by calling ComposeNavigator.backStack. onTransitionComplete() callback is also now a public API to mark a NavBackStackEntry as transition complete after a navigate/popBackStack operation."
Change-Id: I718dbcf2549d755b283292002cdfd9df9dc4bf26
M navigation/navigation-compose/api/current.txt
M navigation/navigation-compose/api/public_plus_experimental_current.txt
M navigation/navigation-compose/api/restricted_current.txt
M navigation/navigation-compose/src/main/java/androidx/navigation/compose/ComposeNavigator.kt
https://android-review.googlesource.com/2374988
Branch: androidx-main
commit d306d15d40c7f029be99c2d207a2ecd7fe0ec9ef
Author: Clara Fok <clarafok@google.com>
Date: Tue Jan 03 15:35:11 2023
Expose ComposeNavigator internal APIs publically
We want to enable implementations of ComposeNavigator by exposing backstack and #onTransitionComplete APIs publically.
Test: n/a
Bug: 257519195
Relnote: "You can now access the backstack associated with ComposeNavigator by calling ComposeNavigator.backStack. onTransitionComplete() callback is also now a public API to mark a NavBackStackEntry as transition complete after a navigate/popBackStack operation."
Change-Id: I718dbcf2549d755b283292002cdfd9df9dc4bf26
M navigation/navigation-compose/api/current.txt
M navigation/navigation-compose/api/public_plus_experimental_current.txt
M navigation/navigation-compose/api/restricted_current.txt
M navigation/navigation-compose/src/main/java/androidx/navigation/compose/ComposeNavigator.kt
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit e8cbb84db39ff712011f83f14e65ee6a318f8a33
Author: Clara Fok <clarafok@google.com>
Date: Wed Feb 15 12:35:39 2023
Expose FragmentNavigation backstack
Expose internally for testing purposes
Test: n/a
Bug: 257519195
Change-Id: Iec82ea2103b80b17eaf8b49f11704cbe198dde81
M navigation/navigation-fragment/src/main/java/androidx/navigation/fragment/FragmentNavigator.kt
https://android-review.googlesource.com/2438993
Branch: androidx-main
commit e8cbb84db39ff712011f83f14e65ee6a318f8a33
Author: Clara Fok <clarafok@google.com>
Date: Wed Feb 15 12:35:39 2023
Expose FragmentNavigation backstack
Expose internally for testing purposes
Test: n/a
Bug: 257519195
Change-Id: Iec82ea2103b80b17eaf8b49f11704cbe198dde81
M navigation/navigation-fragment/src/main/java/androidx/navigation/fragment/FragmentNavigator.kt
cl...@google.com
This bug is considered fixed for now. Separate bugs can be filed if specific APIs need to be opened up in the future.
The opened up APIs are available in navigation 2.6.0-beta01
Description
It is possible to open up the Navigator APIs so that they are more accessible. Specifically things like their back stack which are currently internal. Opening these up would give developers the ability to more easily create custom behavior based on our default Navigators vs always needing the implement their own.