Make `Modifier.minimumTouchTargetSize()` public [258495559]

Fixed

Feature Request

Status Update

No update yet.

Description

ki...@google.com

created issue #1

Nov 9, 2022 09:06PM

https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:compose/material/material/src/commonMain/kotlin/androidx/compose/material/TouchTarget.kt

This is useful for people building their own "extensions" of Material, to stay consistent with the touch target requirements.

Comments

ki...@google.com <ki...@google.com> #2Nov 9, 2022 09:07PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 23a7d960caf43390a554700d3c56ada189a9d10e
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Mon Aug 10 15:11:36 2020

IconButton / IconToggleButton API scrub

Test: ./gradlew updateApi
Bug:

b/161809385

Bug:

b/161807956

Relnote: "Adds enabled parameter to IconButton, and reorders parameters in IconToggleButton"
Change-Id: I0a9419b1a631cadad451395302ad87b7f9214f96

M ui/ui-material/api/current.txt
M ui/ui-material/api/public_plus_experimental_current.txt
M ui/ui-material/api/restricted_current.txt
M ui/ui-material/src/commonMain/kotlin/androidx/compose/material/IconButton.kt

https://android-review.googlesource.com/1394868

lp...@google.com <lp...@google.com> #3Nov 14, 2022 06:38PM

Sounds reasonable, but note that:

this only affects the visual size (i.e allowing for at least the minimum space around components), touch targets are automatically expanded at the touch input layer so even without this modifier, components will still react to input outside their bounds up until the minimum size
it probably needs to be renamed as a result, the actual semantic meaning of this modifier is more like 'recommended minimum interactable component size' - the actual min touch target size is defined by the Android platform in the ViewConfiguration, and can be lower on some devices, whereas Material just recommends a static 48x48 for Material components. I'd want to make it clear that this is a Material thing for consistency in layouts, not a Compose required thing

co...@google.com <co...@google.com> Nov 14, 2022 09:32PM

Reassigned to ma...@google.com.

co...@google.com <co...@google.com> Nov 16, 2022 03:21PM

Reassigned to co...@google.com.

co...@google.com <co...@google.com> Nov 17, 2022 07:58PM

Accepted by co...@google.com.

ap...@google.com <ap...@google.com> #4Dec 3, 2022 07:47PM

Project: platform/frameworks/support
Branch: androidx-main

commit 8574b8cf56881f2111a5d26f4ad80302057e80be
Author: Connie Shi <connieshi@google.com>
Date: Wed Nov 16 14:09:05 2022

Rename `Modifier.minimumTouchTargetSize()` to `Modifier.minimumInteractiveComponentSize` and make it public.
Always use 48dp x 48dp as the minimimum size instead of deferring to the value set in LocalViewConfiguration.

Test: Ran existing tests.
bug: 258495559
Relnote: "Add `Modifier.minimumInteractiveComponentSize`. It can be used to reserve at least 48.dp in size to disambiguate touch interactions if the element would measure smaller."
Change-Id: I33f58e4c11cf74668e97167b91dad26b64ac554b

A compose/material/material/api/current.ignore
M compose/material/material/api/current.txt
M compose/material/material/api/public_plus_experimental_current.txt
A compose/material/material/api/restricted_current.ignore
M compose/material/material/api/restricted_current.txt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/CheckboxTest.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/IconButtonTest.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/RadioButtonTest.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/SwitchTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Checkbox.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/IconButton.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/InteractiveComponentSize.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/RadioButton.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Slider.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Surface.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Switch.kt
M compose/material3/material3/api/current.ignore
M compose/material3/material3/api/current.txt
M compose/material3/material3/api/public_plus_experimental_current.txt
M compose/material3/material3/api/restricted_current.ignore
M compose/material3/material3/api/restricted_current.txt
M compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/CheckboxTest.kt
M compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/FloatingActionButtonTest.kt
M compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/IconButtonTest.kt
M compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/RadioButtonTest.kt
M compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/SwitchTest.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/Checkbox.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/IconButton.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/InteractiveComponentSize.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/RadioButton.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/Slider.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/Surface.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/Switch.kt

https://android-review.googlesource.com/2305511

ma...@google.com <ma...@google.com> Dec 5, 2022 06:15PM

Marked as fixed.

na...@google.com <na...@google.com> #5Jan 11, 2023 08:11PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.material:material:1.4.0-alpha04
androidx.compose.material3:material3:1.1.0-alpha04