Status Update
Comments
je...@google.com <je...@google.com> #2
Gradle issue asking for it to be made easier to avoid making an unused modification to this list:
ga...@google.com <ga...@google.com>
je...@google.com <je...@google.com> #3
I think the issue here is that jvmArgs is null, which causes addAll()
to not run.
IMO we should be adding to jvmArgs and not replacing it entirely, in case something else has previously set jvmArgs. WYT @Ivan?
I could change it to something like
forkOptions.jvmArgs?.addAll(executionOptions.get().jvmArgs) ?: forkOptions.jvmArgs(executionOptions.get().jvmArgs)
je...@google.com <je...@google.com> #4
Yeah, the nullness of jvmArgs
was the first possibility I checked too, although even with "!!" it still had no effect, see
I uploaded a change that I observed to fix it for me and added you as a reviewer
je...@google.com <je...@google.com> #5
Ah, ok, that makes sense.
je...@google.com <je...@google.com> #6
Thanks for the change, Jeff!
Should we cherry-pick it into 7.4? I think AGP 7.4 has that but the settings plugin is not officially supported yet.
Description
In b/258677934 I found that I could specify
r8.runInSeparateProcess
by adding this to settings.gradle :However, when I try to set jvmArgs in the same way, it doesn't have an effect:
This appears to be because
says
rather than