r8.jvmArgs don't get used [258704137]

Fixed

Bug

Status Update

No update yet.

Description

je...@google.com

created issue #1

Nov 10, 2022 09:10PM

In b/258677934 I found that I could specify r8.runInSeparateProcess by adding this to settings.gradle :

buildscript {
    dependencies {
        classpath "com.android.tools.build:gradle-settings:8.0.0-alpha05"
    }
}

apply(plugin: "com.android.settings")

android {
    execution {
        profiles {
            Jeff {
                r8 {
                    runInSeparateProcess true
                }
            }
        }
        defaultProfile "Jeff"
    }
}

However, when I try to set jvmArgs in the same way, it doesn't have an effect:

android {
    execution {
        profiles {
            Jeff {
                r8 {
                    runInSeparateProcess true
                    setJvmOptions(["-Xms2g", "-Xmx2g"])
                }
            }
        }
        defaultProfile "Jeff"
    }
}

This appears to be because

https://android.googlesource.com/platform/tools/base/+/08c2b7273892834207e8fcc302a89b29eb88d69b/build-system/gradle-core/src/main/java/com/android/build/gradle/internal/tasks/R8Task.kt#587

says

forkOptions.jvmArgs?.addAll(executionOptions.get().jvmArgs)

rather than

forkOptions.jvmArgs(executionOptions.get().jvmArgs)

Comments

je...@google.com <je...@google.com> #2Nov 10, 2022 10:02PM

Thanks for the report. I will route this to the appropriate internal team and update this when I hear back from them.

ga...@google.com <ga...@google.com> Nov 11, 2022 09:44AM

Reassigned to je...@google.com.

je...@google.com <je...@google.com> #3Nov 17, 2022 10:37PM

One more detail, Data Layer event calls from the watch to the phone (running Android 13) do work on if the listener is in an Activity or Fragment.

Message last modified on Nov 17, 2022 10:37PM

je...@google.com <je...@google.com> #4Nov 17, 2022 10:40PM

Also, I'm seeing this message in the Logcat:

"2022-06-12 18:47:15.156 1841-4562/? W/PackageManager: Intent does not match component's intent filter: Intent { act=com.google.android.gms.wearable.BIND_LISTENER"

je...@google.com <je...@google.com> #5Nov 17, 2022 10:49PM

Experiencing the same issues, please see my other report for any useful logs:

https://issuetracker.google.com/issues/235673375

je...@google.com <je...@google.com> #6Nov 18, 2022 11:14PM

Marked as fixed.

+1, can confirm it doesn't work on Android 13:=

2022-07-15 11:26:15.023   589-5347  PackageManager          pid-589                              W  Intent does not match component's intent filter: Intent { act=com.google.android.gms.wearable.BIND_LISTENER cmp=xxx/xxx.WatchMessageReceiver }
2022-07-15 11:26:15.023   589-5347  PackageManager          pid-589                              W  Access blocked: ComponentInfo{xxx/xxx.WatchMessageReceiver}
2022-07-15 11:26:15.023   589-5347  ActivityManager         pid-589                              W  Unable to start service Intent { act=com.google.android.gms.wearable.BIND_LISTENER cmp=xxx/xxx.WatchMessageReceiver } U=0: not found

sp...@google.com <sp...@google.com> #7Nov 19, 2022 06:26AM

Note that I've been able to make it work by:

Adding <action android:name="com.google.android.gms.wearable.BIND_LISTENER" /> in the intent filter
Removing <data android:scheme="wear" android:host="*" />

But I feel like this is not something we should do

72...@gmail.com <72...@gmail.com> #8Jan 26, 2023 05:16PM

I'm really afraid Android 13 might get released as-is, breaking WearOS app communication 😨😨