Fixed
Status Update
Comments
je...@google.com <je...@google.com> #2
See also related
ga...@google.com <ga...@google.com>
je...@google.com <je...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit 86445f1b2ea2494f49ae2fee118c878ba510c568
Author: Dustin Lam <dustinlam@google.com>
Date: Mon Dec 28 15:21:36 2020
Make terminal separator behavior configurable
Adds an enum allowing a choice between waiting for both PagingSource and
RemoteMediator to resolve, or to simply await for PagingSource to
resolve allowing the use-case where initial load can immediately prepend
a header without requiring the user to scroll to see it even when using
RemoteMediator.
Relnote: "Allow configuration of terminal separator (header / footer)
behavior with an additional optional SeparatorType parameter. The two
options are:
* FULLY_COMPLETE - existing behavior; wait for both PagingSource and
RemoteMediator to mark endOfPaginationReached before adding terminal
separators. If RemoteMediator is not used, remote loadState is
ignored. This is primarily useful if you only want to show section
separators when the section is fully loaded, including fetching from
remote source e.g., network.
* SOURCE_COMPLETE - only wait for PagingSource to mark
endOfPaginationReached even if RemoteMediator is used. This allows
headers and footers to be presented synchronously with the initial
load, which prevents users from needing to scroll to see terminal
separators."
Test: ./gradlew paging:paging-common:test
Fixes: 174700218
Change-Id: Ibe9938d069e66d0deae806dc44684f3a05e651a0
M paging/common/api/current.txt
M paging/common/api/public_plus_experimental_current.txt
M paging/common/api/restricted_current.txt
M paging/common/src/main/kotlin/androidx/paging/PagingDataTransforms.kt
M paging/common/src/main/kotlin/androidx/paging/Separators.kt
M paging/common/src/test/kotlin/androidx/paging/HeaderFooterTest.kt
M paging/common/src/test/kotlin/androidx/paging/SeparatorsTest.kt
M paging/common/src/test/kotlin/androidx/paging/SeparatorsWithRemoteMediatorTest.kt
M paging/integration-tests/testapp/src/main/java/androidx/paging/integration/testapp/v3/V3ViewModel.kt
M paging/integration-tests/testapp/src/main/java/androidx/paging/integration/testapp/v3room/V3RoomViewModel.kt
https://android-review.googlesource.com/1537142
Branch: androidx-main
commit 86445f1b2ea2494f49ae2fee118c878ba510c568
Author: Dustin Lam <dustinlam@google.com>
Date: Mon Dec 28 15:21:36 2020
Make terminal separator behavior configurable
Adds an enum allowing a choice between waiting for both PagingSource and
RemoteMediator to resolve, or to simply await for PagingSource to
resolve allowing the use-case where initial load can immediately prepend
a header without requiring the user to scroll to see it even when using
RemoteMediator.
Relnote: "Allow configuration of terminal separator (header / footer)
behavior with an additional optional SeparatorType parameter. The two
options are:
* FULLY_COMPLETE - existing behavior; wait for both PagingSource and
RemoteMediator to mark endOfPaginationReached before adding terminal
separators. If RemoteMediator is not used, remote loadState is
ignored. This is primarily useful if you only want to show section
separators when the section is fully loaded, including fetching from
remote source e.g., network.
* SOURCE_COMPLETE - only wait for PagingSource to mark
endOfPaginationReached even if RemoteMediator is used. This allows
headers and footers to be presented synchronously with the initial
load, which prevents users from needing to scroll to see terminal
separators."
Test: ./gradlew paging:paging-common:test
Fixes: 174700218
Change-Id: Ibe9938d069e66d0deae806dc44684f3a05e651a0
M paging/common/api/current.txt
M paging/common/api/public_plus_experimental_current.txt
M paging/common/api/restricted_current.txt
M paging/common/src/main/kotlin/androidx/paging/PagingDataTransforms.kt
M paging/common/src/main/kotlin/androidx/paging/Separators.kt
M paging/common/src/test/kotlin/androidx/paging/HeaderFooterTest.kt
M paging/common/src/test/kotlin/androidx/paging/SeparatorsTest.kt
M paging/common/src/test/kotlin/androidx/paging/SeparatorsWithRemoteMediatorTest.kt
M paging/integration-tests/testapp/src/main/java/androidx/paging/integration/testapp/v3/V3ViewModel.kt
M paging/integration-tests/testapp/src/main/java/androidx/paging/integration/testapp/v3room/V3RoomViewModel.kt
je...@google.com <je...@google.com> #4
Yeah, the nullness of jvmArgs
was the first possibility I checked too, although even with "!!" it still had no effect, see
I uploaded a change that I observed to fix it for me and added you as a reviewer
je...@google.com <je...@google.com> #5
Ah, ok, that makes sense.
je...@google.com <je...@google.com> #6
Thanks for the change, Jeff!
Should we cherry-pick it into 7.4? I think AGP 7.4 has that but the settings plugin is not officially supported yet.
72...@gmail.com <72...@gmail.com> #8
Chờ nhận sp
Description
In b/258677934 I found that I could specify
r8.runInSeparateProcess
by adding this to settings.gradle :However, when I try to set jvmArgs in the same way, it doesn't have an effect:
This appears to be because
says
rather than