r8.jvmArgs don't get used [258704137]

Fixed

Bug

Status Update

No update yet.

Description

je...@google.com

created issue #1

Nov 10, 2022 09:10PM

In b/258677934 I found that I could specify r8.runInSeparateProcess by adding this to settings.gradle :

buildscript {
    dependencies {
        classpath "com.android.tools.build:gradle-settings:8.0.0-alpha05"
    }
}

apply(plugin: "com.android.settings")

android {
    execution {
        profiles {
            Jeff {
                r8 {
                    runInSeparateProcess true
                }
            }
        }
        defaultProfile "Jeff"
    }
}

However, when I try to set jvmArgs in the same way, it doesn't have an effect:

android {
    execution {
        profiles {
            Jeff {
                r8 {
                    runInSeparateProcess true
                    setJvmOptions(["-Xms2g", "-Xmx2g"])
                }
            }
        }
        defaultProfile "Jeff"
    }
}

This appears to be because

https://android.googlesource.com/platform/tools/base/+/08c2b7273892834207e8fcc302a89b29eb88d69b/build-system/gradle-core/src/main/java/com/android/build/gradle/internal/tasks/R8Task.kt#587

says

forkOptions.jvmArgs?.addAll(executionOptions.get().jvmArgs)

rather than

forkOptions.jvmArgs(executionOptions.get().jvmArgs)

Comments

je...@google.com <je...@google.com> #2Nov 10, 2022 10:02PM

Will be this fix also part of 4.2 please?

ga...@google.com <ga...@google.com> Nov 11, 2022 09:44AM

Reassigned to je...@google.com.

je...@google.com <je...@google.com> #3Nov 17, 2022 10:37PM

for the "out" bundle issue, this seems indeed an issue. for the second one reported adding "debugUpdateAPKArtifact" to the path, this WAI as there can more more than one transformer and we need to automatically separate them so they do not use the same output folder. for #3, I will look at it but it might be difficult to change it at this time.

Message last modified on Nov 17, 2022 10:37PM

je...@google.com <je...@google.com> #4Nov 17, 2022 10:40PM

I understand that if there is more transformer is necessary to make every folder different, but there is the main problem, that the final one (last transform) is inside of the intermediate folder. The last transformation should end in the standard location, right? Maybe also with the default name not?

je...@google.com <je...@google.com> #5Nov 17, 2022 10:49PM

Hello, this is a P1 S1 issue for a while now, and it's blocking us from upgrading to AGP 4.2 and further. What's the current status? And do you have plans to backport it to 4.2.x?

je...@google.com <je...@google.com> #6Nov 18, 2022 11:14PM

Marked as fixed.

no we don't have a plan to backport this. why is this blocking you from upgrading ?

sp...@google.com <sp...@google.com> #7Nov 19, 2022 06:26AM

We sign apk's and bundles via internal service, and i don't know another way to interact with artifacts; Yesterday i ended up with some ugly workaround: https://github.com/avito-tech/avito-android/pull/1085/files#diff-b898cc20fedebe394439bb37ffb91d3366a1f9a6d359dbdebca79af8a079f911 I'd be glad if you'll point me out how can it be done better.

72...@gmail.com <72...@gmail.com> #8Jan 26, 2023 05:16PM

I commented on the merge request but to summarize :

you can set your signing tasks output folder to wherever you need to be :

artifacts.use(target.tasks.signedApkTaskProvider(this)).configure { signedDirProperty.set(File("/path/to/where/you/want/your/signed/files")) }

if you don't set it, then we will set a directory automatically.