Error when TestMode.TYPE_ALIAS replace Function type with typealias [259130471]

Fixed

Bug

Status Update

No update yet.

Description

hu...@gmail.com

created issue #1

Nov 14, 2022 10:37PM

After bump lint to 31.0.0-alpha08, we have some test failed when run in TestMode.TYPE_ALIAS.
Thant's because when we have class like:
public class SomeNamedClass {
public void someMethod() {
ArgumentLiveData<Object, Object> anonymous = ArgumentLiveData.create(new Function<Object, LiveData<Object>>() {
@Override
public LiveData<Object> apply(Object input) {
return null;
}
});
}
}
in TestMode.TYPE_ALIAS, it's look like:
class SomeNamedClass {
fun someMethod() {
val anonymous = ArgumentLiveData.create(object : Function<Any, LiveData<Any>> {
override fun apply(input: Any?): LiveData<Any> {
return MutableLiveData()
}
})
}
}
which cause exception when analyze it.

Comments

hu...@gmail.com <hu...@gmail.com> #2Nov 15, 2022 06:04PM

Seems like it is caused by the subcompose(BottomSheetScaffoldLayoutSlot.Fab, fab)[0].measure(looseConstraints) line in the bottom sheet. Seems like you have the floatingActionButton = {} passed in your scaffold. setting it to null instead should solve the issue.

@jossi, could you take a look if we can handle this more gracefully and whether it makes sense?

lp...@google.com <lp...@google.com> #3Nov 17, 2022 02:45PM

Your assessment is correct; changing the fab to null prevents the crash. Maybe still warrants an empty check on the Measurables in addition to the null check.

tn...@google.com <tn...@google.com> Nov 17, 2022 03:00PM

Assigned to tn...@google.com.

tn...@google.com <tn...@google.com> #4Nov 19, 2022 05:21PM

We are also seeing this but at `BottomSheetScaffold.kt:447`:

```
val bodyPlaceable = subcompose(BottomSheetScaffoldLayoutSlot.Body) {
body(PaddingValues(bottom = sheetPeekHeight))
}[0].measure(bodyConstraints)
```

This happens whenever the body of BottomSheetScaffold is empty

```
E/AndroidRuntime: FATAL EXCEPTION: main
Process: co.minm, PID: 622
java.lang.IndexOutOfBoundsException: Index 0 is out of bounds. The list has 0 elements.
at androidx.compose.runtime.collection.MutableVectorKt.checkIndex(MutableVector.kt:1135)
at androidx.compose.runtime.collection.MutableVectorKt.access$checkIndex(MutableVector.kt:1)
at androidx.compose.runtime.collection.MutableVector$MutableVectorList.get(MutableVector.kt:940)
at androidx.compose.material.BottomSheetScaffoldKt$BottomSheetScaffoldLayout$1$1.invoke-0kLqBqw(BottomSheetScaffold.kt:447)
at androidx.compose.material.BottomSheetScaffoldKt$BottomSheetScaffoldLayout$1$1.invoke(BottomSheetScaffold.kt:430)
at androidx.compose.ui.layout.LayoutNodeSubcompositionsState$createMeasurePolicy$1.measure-3p2s80s(SubcomposeLayout.kt:590)
at androidx.compose.ui.node.InnerPlaceable.measure-BRTryo0(InnerPlaceable.kt:44)
at androidx.compose.ui.node.LayoutNode$performMeasure$1.invoke(LayoutNode.kt:1428)
at androidx.compose.ui.node.LayoutNode$performMeasure$1.invoke(LayoutNode.kt:1427)
at androidx.compose.runtime.snapshots.Snapshot$Companion.observe(Snapshot.kt:2099)
at androidx.compose.runtime.snapshots.SnapshotStateObserver.observeReads(SnapshotStateObserver.kt:112)
at androidx.compose.ui.node.OwnerSnapshotObserver.observeReads$ui_release(OwnerSnapshotObserver.kt:78)
at androidx.compose.ui.node.OwnerSnapshotObserver.observeMeasureSnapshotReads$ui_release(OwnerSnapshotObserver.kt:66)
at androidx.compose.ui.node.LayoutNode.performMeasure-BRTryo0$ui_release(LayoutNode.kt:1427)
at androidx.compose.ui.node.OuterMeasurablePlaceable.remeasure-BRTryo0(OuterMeasurablePlaceable.kt:94)
at androidx.compose.ui.node.OuterMeasurablePlaceable.measure-BRTryo0(OuterMeasurablePlaceable.kt:75)
at androidx.compose.ui.node.LayoutNode.measure-BRTryo0(LayoutNode.kt:1366)
at androidx.compose.foundation.layout.BoxKt$boxMeasurePolicy$1.measure-3p2s80s(Box.kt:115)
at androidx.compose.ui.node.InnerPlaceable.measure-BRTryo0(InnerPlaceable.kt:44)
at androidx.compose.ui.graphics.SimpleGraphicsLayerModifier.measure-3p2s80s(GraphicsLayerModifier.kt:405)
at androidx.compose.ui.node.ModifiedLayoutNode.measure-BRTryo0(ModifiedLayoutNode.kt:53)
at androidx.compose.foundation.layout.FillModifier.measure-3p2s80s(Size.kt:658)
at androidx.compose.ui.node.ModifiedLayoutNode.measure-BRTryo0(ModifiedLayoutNode.kt:53)
at androidx.compose.ui.node.LayoutNode$performMeasure$1.invoke(LayoutNode.kt:1428)
at androidx.compose.ui.node.LayoutNode$performMeasure$1.invoke(LayoutNode.kt:1427)
at androidx.compose.runtime.snapshots.Snapshot$Companion.observe(Snapshot.kt:2099)
at androidx.compose.runtime.snapshots.SnapshotStateObserver.observeReads(SnapshotStateObserver.kt:112)
at androidx.compose.ui.node.OwnerSnapshotObserver.observeReads$ui_release(OwnerSnapshotObserver.kt:78)
at androidx.compose.ui.node.OwnerSnapshotObserver.observeMeasureSnapshotReads$ui_release(OwnerSnapshotObserver.kt:66)
at androidx.compose.ui.node.LayoutNode.performMeasure-BRTryo0$ui_release(LayoutNode.kt:1427)
at androidx.compose.ui.node.OuterMeasurablePlaceable.remeasure-BRTryo0(OuterMeasurablePlaceable.kt:94)
at androidx.compose.ui.node.OuterMeasurablePlaceable.measure-BRTryo0(OuterMeasurablePlaceable.kt:75)
at androidx.compose.ui.node.LayoutNode.measure-BRTryo0(LayoutNode.kt:1366)
at androidx.compose.foundation.layout.BoxKt$boxMeasurePolicy$1.measure-3p2s80s(Box.kt:115)
at androidx.compose.ui.node.InnerPlaceable.measure-BRTryo0(InnerPlaceable.kt:44)
at androidx.compose.ui.graphics.SimpleGraphicsLayerModifier.measure-3p2s80s(GraphicsLayerModifier.kt:405)
at androidx.compose.ui.node.ModifiedLayoutNode.measure-BRTryo0(ModifiedLayoutNode.kt:53)
at androidx.compose.foundation.layout.PaddingValuesModifier.measure-3p2s80s(Padding.kt:417)
at androidx.compose.ui.node.ModifiedLayoutNode.measure-BRTryo0(ModifiedLayoutNode.kt:53)
at androidx.compose.ui.node.LayoutNode$performMeasure$1.invoke(LayoutNode.kt:1428)
```

tn...@google.com <tn...@google.com> #5Nov 21, 2022 03:35PM

Thanks for reporting this. We recently changed the implementation. For FABs, we recommend passing null instead. Moving forward, we are going to provide a nicer UX letting you pass in empty composables. #1 and #2, could you share your use cases for passing empty composables?

tn...@google.com <tn...@google.com> #6Nov 21, 2022 10:33PM

Marked as fixed.

The use cases are conditionally created bottom sheets based on device states, with conditional subcomposables based on device details. The use cases do not require empty composables rather than null. We can and will switch these to pass null. I think the bigger issue was just that previously working code started crashing on the update, without indication of the danger.

Issue 259130471