Lint: NPE due to querying Application instance in mergeOnly mode [259140252]

Fixed

Bug

Status Update

No update yet.

Description

ga...@linecorp.com

created issue #1

Nov 15, 2022 01:18AM

DESCRIBE THE ISSUE IN DETAIL:

STEPS TO REPRODUCE:

Perform ./gradlew :app:lintDebug
Occurrence rate with clean build : 10~15%

ATTACH LOG FILES (Select Help > Show Log in Files, or Show Log in Finder on a Mac)

Exception
org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':app:lintReportDevelopDebug'.	
	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.lambda$executeIfValid$1(ExecuteActionsTaskExecuter.java:142)	
		•••
Caused by: org.gradle.workers.internal.DefaultWorkerExecutor$WorkExecutionException: A failure occurred while executing com.android.build.gradle.internal.lint.AndroidLintTask$AndroidLintLauncherWorkAction	
	at org.gradle.workers.internal.DefaultWorkerExecutor.lambda$submitWork$2(DefaultWorkerExecutor.java:207)	
		•••
Caused by: org.gradle.workers.WorkerExecutionException: There was a failure while executing work items	
	at org.gradle.workers.internal.DefaultWorkerExecutor.workerExecutionException(DefaultWorkerExecutor.java:267)	
		•••
Caused by: org.gradle.workers.internal.DefaultWorkerExecutor$WorkExecutionException: A failure occurred while executing com.android.build.gradle.internal.lint.AndroidLintWorkAction	
	at org.gradle.workers.internal.DefaultWorkerExecutor$WorkItemExecution.waitForCompletion(DefaultWorkerExecutor.java:339)	
		•••
Caused by: java.lang.reflect.InvocationTargetException: (No message provided)	
	at jdk.internal.reflect.GeneratedMethodAccessor1707.invoke(Unknown Source)	
		•••
	at com.android.build.gradle.internal.lint.AndroidLintWorkAction.invokeLintMainRunMethod(AndroidLintWorkAction.kt:96)	
	at com.android.build.gradle.internal.lint.AndroidLintWorkAction.runLint(AndroidLintWorkAction.kt:85)	
	at com.android.build.gradle.internal.lint.AndroidLintWorkAction.execute(AndroidLintWorkAction.kt:61)	
		•••

Caused by: java.lang.NullPointerException: Cannot invoke "com.intellij.openapi.application.Application.getService(java.lang.Class)" because the return value of "com.intellij.openapi.application.ApplicationManager.getApplication()" is null	
	at com.intellij.openapi.vfs.VirtualFileManager.getInstance(VirtualFileManager.java:36)	
	at com.intellij.openapi.vfs.StandardFileSystems$1.compute(StandardFileSystems.java:24)	
	at com.intellij.openapi.vfs.StandardFileSystems$1.compute(StandardFileSystems.java:20)	
	at com.intellij.openapi.util.ClearableLazyValue.getValue(ClearableLazyValue.java:39)	
	at com.intellij.openapi.vfs.StandardFileSystems.local(StandardFileSystems.java:40)	
	at com.android.tools.lint.LintCliClient.readFile(LintCliClient.kt:1114)	
	at com.android.tools.lint.Main$MainLintClient.readFile(Main.java:624)	
	at com.android.tools.lint.LintCliClient$getSourceText$1.apply(LintCliClient.kt:933)	
	at com.android.tools.lint.LintCliClient$getSourceText$1.apply(LintCliClient.kt:933)	
	at java.util.HashMap.computeIfAbsent(HashMap.java:1220)	
	at com.android.tools.lint.LintCliClient.getSourceText(LintCliClient.kt:933)	
	at com.android.tools.lint.TextReporter$write$2.invoke(TextReporter.kt:143)	
	at com.android.tools.lint.TextReporter$write$2.invoke(TextReporter.kt:143)	
	at com.android.tools.lint.ReporterKt.getErrorLines(Reporter.kt:579)	
	at com.android.tools.lint.ReporterKt.getErrorLines(Reporter.kt:567)	
	at com.android.tools.lint.TextReporter.write(TextReporter.kt:143)	
	at com.android.tools.lint.LintCliClient.writeReports(LintCliClient.kt:442)	
	at com.android.tools.lint.LintCliClient.performReporting(LintCliClient.kt:313)	
	at com.android.tools.lint.LintCliClient.access$performReporting(LintCliClient.kt:126)	
	at com.android.tools.lint.LintCliClient$mergeOnly$2.invoke(LintCliClient.kt:261)	
	at com.android.tools.lint.LintCliClient$mergeOnly$2.invoke(LintCliClient.kt:259)	
	at com.android.tools.lint.LintCliClient.run(LintCliClient.kt:302)	
	at com.android.tools.lint.LintCliClient.mergeOnly(LintCliClient.kt:259)	
	at com.android.tools.lint.Main.run(Main.java:1670)	
	at com.android.tools.lint.Main.run(Main.java:274)	
	at jdk.internal.reflect.GeneratedMethodAccessor1707.invoke(Unknown Source)	
	at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)	
	at java.lang.reflect.Method.invoke(Method.java:568)	
	at com.android.build.gradle.internal.lint.AndroidLintWorkAction.invokeLintMainRunMethod(AndroidLintWorkAction.kt:96)	
	at com.android.build.gradle.internal.lint.AndroidLintWorkAction.runLint(AndroidLintWorkAction.kt:85)	
	at com.android.build.gradle.internal.lint.AndroidLintWorkAction.execute(AndroidLintWorkAction.kt:61)

IMPORTANT: Please read https://developer.android.com/studio/report-bugs.html carefully and supply all required information.

Studio Build: N/A
Version of Gradle Plugin: 7.4.0-beta05
Version of Gradle: 7.5.1
Version of Java: Java 11/Java 17
OS: Linux

Comments

ch...@google.com <ch...@google.com> Nov 15, 2022 02:09PM

Assigned to an...@google.com.

vi...@google.com <vi...@google.com> #2Nov 21, 2022 08:25PM

Thanks for the feedback. To help us troubleshoot this issue further, we will need more information. Please share detailed reproduction steps and as much as possible of the following information when it applies if you haven’t already:

Android Studio version and OS type and version
Screenshots or videos of the issue
idea.log file (select Help > Show Log in Finder / Explorer)
Thread dumps if the issue is a freezing or non-responding UI. For more information on what’s needed and how to obtain this information please read the guide at https://developer.android.com/studio/report-bugs#studio-bugs

ga...@linecorp.com <ga...@linecorp.com> #3Nov 23, 2022 11:29AM

Android Studio version and OS type and version Screenshots or videos of the issue
idea.log file (select Help > Show Log in Finder / Explorer)

As I reported, I didn't run build with Android Studio, but just invoked gradle wrapper on command line to perform lint.
And OS is linux (CentOS 7)
So, there is no screenshot, video and idea.log file to share.

gh...@google.com <gh...@google.com> #4Nov 28, 2022 10:44PM

Suspected repro steps:

Enable Lint text reports, so that the code in TextReporter runs
Have some Lint issues in the project, so that getSourceText() is called.
Invoke Lint such that some mergeOnly task runs before any analyze task in the Gradle daemon.

This issue looks similar to https://issuetracker.google.com/241787635 but with a different root cause.

We need to decide (1) whether this should block the AGP 7.4 release, and (2) the best fix. For #2 I'm wondering if it makes sense to always initialize the Application instance, even in the mergeOnly phase. AFAIK app init is fast (compared to project env init, which was the slow part?).

Message last modified on Nov 28, 2022 10:49PM

gh...@google.com <gh...@google.com> #5Nov 29, 2022 12:02AM

Ah, there is one more important repro step:

One of the .java/.kt/.kts files containing a Lint issue must also contain a carriage return character somewhere. This is what triggers the specific code path in LintCliClient.readFile.

gh...@google.com <gh...@google.com> Nov 29, 2022 06:18PM

Reassigned to tn...@google.com.

tn...@google.com <tn...@google.com> #6Dec 1, 2022 01:57AM

Marked as fixed.

Fixed by

https://cs.android.com/android-studio/platform/tools/base/+/1c98a5e5427e1fd2763448400bd8675f1a590eb3 for 8.0.0-beta01. It will also be cherrypicked to 7.4.1 (sorry, too late/risky for 7.4.0). Thanks for the report!