Lint: NPE due to querying Application instance in mergeOnly mode [259140252]

Fixed

Bug

Status Update

No update yet.

Description

ga...@linecorp.com

created issue #1

Nov 15, 2022 01:18AM

DESCRIBE THE ISSUE IN DETAIL:

STEPS TO REPRODUCE:

Perform ./gradlew :app:lintDebug
Occurrence rate with clean build : 10~15%

ATTACH LOG FILES (Select Help > Show Log in Files, or Show Log in Finder on a Mac)

Exception
org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':app:lintReportDevelopDebug'.	
	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.lambda$executeIfValid$1(ExecuteActionsTaskExecuter.java:142)	
		•••
Caused by: org.gradle.workers.internal.DefaultWorkerExecutor$WorkExecutionException: A failure occurred while executing com.android.build.gradle.internal.lint.AndroidLintTask$AndroidLintLauncherWorkAction	
	at org.gradle.workers.internal.DefaultWorkerExecutor.lambda$submitWork$2(DefaultWorkerExecutor.java:207)	
		•••
Caused by: org.gradle.workers.WorkerExecutionException: There was a failure while executing work items	
	at org.gradle.workers.internal.DefaultWorkerExecutor.workerExecutionException(DefaultWorkerExecutor.java:267)	
		•••
Caused by: org.gradle.workers.internal.DefaultWorkerExecutor$WorkExecutionException: A failure occurred while executing com.android.build.gradle.internal.lint.AndroidLintWorkAction	
	at org.gradle.workers.internal.DefaultWorkerExecutor$WorkItemExecution.waitForCompletion(DefaultWorkerExecutor.java:339)	
		•••
Caused by: java.lang.reflect.InvocationTargetException: (No message provided)	
	at jdk.internal.reflect.GeneratedMethodAccessor1707.invoke(Unknown Source)	
		•••
	at com.android.build.gradle.internal.lint.AndroidLintWorkAction.invokeLintMainRunMethod(AndroidLintWorkAction.kt:96)	
	at com.android.build.gradle.internal.lint.AndroidLintWorkAction.runLint(AndroidLintWorkAction.kt:85)	
	at com.android.build.gradle.internal.lint.AndroidLintWorkAction.execute(AndroidLintWorkAction.kt:61)	
		•••

Caused by: java.lang.NullPointerException: Cannot invoke "com.intellij.openapi.application.Application.getService(java.lang.Class)" because the return value of "com.intellij.openapi.application.ApplicationManager.getApplication()" is null	
	at com.intellij.openapi.vfs.VirtualFileManager.getInstance(VirtualFileManager.java:36)	
	at com.intellij.openapi.vfs.StandardFileSystems$1.compute(StandardFileSystems.java:24)	
	at com.intellij.openapi.vfs.StandardFileSystems$1.compute(StandardFileSystems.java:20)	
	at com.intellij.openapi.util.ClearableLazyValue.getValue(ClearableLazyValue.java:39)	
	at com.intellij.openapi.vfs.StandardFileSystems.local(StandardFileSystems.java:40)	
	at com.android.tools.lint.LintCliClient.readFile(LintCliClient.kt:1114)	
	at com.android.tools.lint.Main$MainLintClient.readFile(Main.java:624)	
	at com.android.tools.lint.LintCliClient$getSourceText$1.apply(LintCliClient.kt:933)	
	at com.android.tools.lint.LintCliClient$getSourceText$1.apply(LintCliClient.kt:933)	
	at java.util.HashMap.computeIfAbsent(HashMap.java:1220)	
	at com.android.tools.lint.LintCliClient.getSourceText(LintCliClient.kt:933)	
	at com.android.tools.lint.TextReporter$write$2.invoke(TextReporter.kt:143)	
	at com.android.tools.lint.TextReporter$write$2.invoke(TextReporter.kt:143)	
	at com.android.tools.lint.ReporterKt.getErrorLines(Reporter.kt:579)	
	at com.android.tools.lint.ReporterKt.getErrorLines(Reporter.kt:567)	
	at com.android.tools.lint.TextReporter.write(TextReporter.kt:143)	
	at com.android.tools.lint.LintCliClient.writeReports(LintCliClient.kt:442)	
	at com.android.tools.lint.LintCliClient.performReporting(LintCliClient.kt:313)	
	at com.android.tools.lint.LintCliClient.access$performReporting(LintCliClient.kt:126)	
	at com.android.tools.lint.LintCliClient$mergeOnly$2.invoke(LintCliClient.kt:261)	
	at com.android.tools.lint.LintCliClient$mergeOnly$2.invoke(LintCliClient.kt:259)	
	at com.android.tools.lint.LintCliClient.run(LintCliClient.kt:302)	
	at com.android.tools.lint.LintCliClient.mergeOnly(LintCliClient.kt:259)	
	at com.android.tools.lint.Main.run(Main.java:1670)	
	at com.android.tools.lint.Main.run(Main.java:274)	
	at jdk.internal.reflect.GeneratedMethodAccessor1707.invoke(Unknown Source)	
	at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)	
	at java.lang.reflect.Method.invoke(Method.java:568)	
	at com.android.build.gradle.internal.lint.AndroidLintWorkAction.invokeLintMainRunMethod(AndroidLintWorkAction.kt:96)	
	at com.android.build.gradle.internal.lint.AndroidLintWorkAction.runLint(AndroidLintWorkAction.kt:85)	
	at com.android.build.gradle.internal.lint.AndroidLintWorkAction.execute(AndroidLintWorkAction.kt:61)

IMPORTANT: Please read https://developer.android.com/studio/report-bugs.html carefully and supply all required information.

Studio Build: N/A
Version of Gradle Plugin: 7.4.0-beta05
Version of Gradle: 7.5.1
Version of Java: Java 11/Java 17
OS: Linux

Comments

ch...@google.com <ch...@google.com> Nov 15, 2022 02:09PM

Assigned to an...@google.com.

vi...@google.com <vi...@google.com> #2Nov 21, 2022 08:25PM

Okay. I tried a bunch of agp+android studio versions

The last working version was classpath("com.android.tools.build:gradle:7.4.0-alpha06")

once I moved to

classpath("com.android.tools.build:gradle:7.4.0-alpha07") then things start breaking on firebase app dist.

ga...@linecorp.com <ga...@linecorp.com> #3Nov 23, 2022 11:29AM

Scott, assigning to you as it seem to complain the zip is not aligned while packaging which is very puzzling considering the steps...

gh...@google.com <gh...@google.com> #4Nov 28, 2022 10:44PM

OP, when you build the APK with AGP, are you doing any post-processing on the APK and/or do you have any custom tasks that are modifying the APK?

Can you try to verify the alignment of your APK with zipalign locally (zipalign is included in build-tools):

zipalign -c -v 4 foo.apk

Message last modified on Nov 28, 2022 10:49PM

gh...@google.com <gh...@google.com> #5Nov 29, 2022 12:02AM

Not doing any post processing. No custom tasks. I will try to verify alignment now. Give me a sec.

gh...@google.com <gh...@google.com> Nov 29, 2022 06:18PM

Reassigned to tn...@google.com.

tn...@google.com <tn...@google.com> #6Dec 1, 2022 01:57AM

Marked as fixed.

Scenario 1:

built my apk with agp alpha09, but didn't update firebase (bom = 30.2.0)
/Users/idle/Library/Android/sdk/build-tools/31.0.0/zipalign -c -v 4 app-release.apk

"Verification succesful"

Scenario 2:

built my apk with agp alpha09, but I DID update firebase (bom = 30.3.1)
/Users/idle/Library/Android/sdk/build-tools/31.0.0/zipalign -c -v 4 app-release.apk

"Verification FAILED"