Lint: NPE due to querying Application instance in mergeOnly mode [259140252]

Fixed

Bug

Status Update

No update yet.

Description

ga...@linecorp.com

created issue #1

Nov 15, 2022 01:18AM

DESCRIBE THE ISSUE IN DETAIL:

STEPS TO REPRODUCE:

Perform ./gradlew :app:lintDebug
Occurrence rate with clean build : 10~15%

ATTACH LOG FILES (Select Help > Show Log in Files, or Show Log in Finder on a Mac)

Exception
org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':app:lintReportDevelopDebug'.	
	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.lambda$executeIfValid$1(ExecuteActionsTaskExecuter.java:142)	
		•••
Caused by: org.gradle.workers.internal.DefaultWorkerExecutor$WorkExecutionException: A failure occurred while executing com.android.build.gradle.internal.lint.AndroidLintTask$AndroidLintLauncherWorkAction	
	at org.gradle.workers.internal.DefaultWorkerExecutor.lambda$submitWork$2(DefaultWorkerExecutor.java:207)	
		•••
Caused by: org.gradle.workers.WorkerExecutionException: There was a failure while executing work items	
	at org.gradle.workers.internal.DefaultWorkerExecutor.workerExecutionException(DefaultWorkerExecutor.java:267)	
		•••
Caused by: org.gradle.workers.internal.DefaultWorkerExecutor$WorkExecutionException: A failure occurred while executing com.android.build.gradle.internal.lint.AndroidLintWorkAction	
	at org.gradle.workers.internal.DefaultWorkerExecutor$WorkItemExecution.waitForCompletion(DefaultWorkerExecutor.java:339)	
		•••
Caused by: java.lang.reflect.InvocationTargetException: (No message provided)	
	at jdk.internal.reflect.GeneratedMethodAccessor1707.invoke(Unknown Source)	
		•••
	at com.android.build.gradle.internal.lint.AndroidLintWorkAction.invokeLintMainRunMethod(AndroidLintWorkAction.kt:96)	
	at com.android.build.gradle.internal.lint.AndroidLintWorkAction.runLint(AndroidLintWorkAction.kt:85)	
	at com.android.build.gradle.internal.lint.AndroidLintWorkAction.execute(AndroidLintWorkAction.kt:61)	
		•••

Caused by: java.lang.NullPointerException: Cannot invoke "com.intellij.openapi.application.Application.getService(java.lang.Class)" because the return value of "com.intellij.openapi.application.ApplicationManager.getApplication()" is null	
	at com.intellij.openapi.vfs.VirtualFileManager.getInstance(VirtualFileManager.java:36)	
	at com.intellij.openapi.vfs.StandardFileSystems$1.compute(StandardFileSystems.java:24)	
	at com.intellij.openapi.vfs.StandardFileSystems$1.compute(StandardFileSystems.java:20)	
	at com.intellij.openapi.util.ClearableLazyValue.getValue(ClearableLazyValue.java:39)	
	at com.intellij.openapi.vfs.StandardFileSystems.local(StandardFileSystems.java:40)	
	at com.android.tools.lint.LintCliClient.readFile(LintCliClient.kt:1114)	
	at com.android.tools.lint.Main$MainLintClient.readFile(Main.java:624)	
	at com.android.tools.lint.LintCliClient$getSourceText$1.apply(LintCliClient.kt:933)	
	at com.android.tools.lint.LintCliClient$getSourceText$1.apply(LintCliClient.kt:933)	
	at java.util.HashMap.computeIfAbsent(HashMap.java:1220)	
	at com.android.tools.lint.LintCliClient.getSourceText(LintCliClient.kt:933)	
	at com.android.tools.lint.TextReporter$write$2.invoke(TextReporter.kt:143)	
	at com.android.tools.lint.TextReporter$write$2.invoke(TextReporter.kt:143)	
	at com.android.tools.lint.ReporterKt.getErrorLines(Reporter.kt:579)	
	at com.android.tools.lint.ReporterKt.getErrorLines(Reporter.kt:567)	
	at com.android.tools.lint.TextReporter.write(TextReporter.kt:143)	
	at com.android.tools.lint.LintCliClient.writeReports(LintCliClient.kt:442)	
	at com.android.tools.lint.LintCliClient.performReporting(LintCliClient.kt:313)	
	at com.android.tools.lint.LintCliClient.access$performReporting(LintCliClient.kt:126)	
	at com.android.tools.lint.LintCliClient$mergeOnly$2.invoke(LintCliClient.kt:261)	
	at com.android.tools.lint.LintCliClient$mergeOnly$2.invoke(LintCliClient.kt:259)	
	at com.android.tools.lint.LintCliClient.run(LintCliClient.kt:302)	
	at com.android.tools.lint.LintCliClient.mergeOnly(LintCliClient.kt:259)	
	at com.android.tools.lint.Main.run(Main.java:1670)	
	at com.android.tools.lint.Main.run(Main.java:274)	
	at jdk.internal.reflect.GeneratedMethodAccessor1707.invoke(Unknown Source)	
	at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)	
	at java.lang.reflect.Method.invoke(Method.java:568)	
	at com.android.build.gradle.internal.lint.AndroidLintWorkAction.invokeLintMainRunMethod(AndroidLintWorkAction.kt:96)	
	at com.android.build.gradle.internal.lint.AndroidLintWorkAction.runLint(AndroidLintWorkAction.kt:85)	
	at com.android.build.gradle.internal.lint.AndroidLintWorkAction.execute(AndroidLintWorkAction.kt:61)

IMPORTANT: Please read https://developer.android.com/studio/report-bugs.html carefully and supply all required information.

Studio Build: N/A
Version of Gradle Plugin: 7.4.0-beta05
Version of Gradle: 7.5.1
Version of Java: Java 11/Java 17
OS: Linux

Comments

ch...@google.com <ch...@google.com> Nov 15, 2022 02:09PM

Assigned to an...@google.com.

vi...@google.com <vi...@google.com> #2Nov 21, 2022 08:25PM

Retraced stack trace:

Caused by: java.lang.UnsupportedOperationException: Operation is not supported for read-only collection
	at com.android.tools.r8.jetbrains.kotlin.collections.EmptyList.removeAll(Collections.kt)
	at com.android.tools.r8.resourceshrinker.r8integration.LegacyResourceShrinker.run(LegacyResourceShrinker.java:228)
	at com.android.tools.r8.R8.shrinkResources(R8.java:991)
	at com.android.tools.r8.R8.runInternal(R8.java:894)
	at com.android.tools.r8.R8.runInternal(R8.java:259)
	at com.android.tools.r8.R8.lambda$runForTesting$1(R8.java:243)
	at com.android.tools.r8.internal.Nu.a(R8_8.9.27_3afcc9fea5cc5cd06373667ec09d5fe106db8a4a77576689534e667542385a93:28

ga...@linecorp.com <ga...@linecorp.com> #3Nov 23, 2022 11:29AM

This is happening when there are no unused resources at all and we have duplicated resources between the feature and base (or different features)

Reproduction here: https://r8-review.git.corp.google.com/c/r8/+/102418

Fix here: https://r8-review.git.corp.google.com/c/r8/+/102626

For the reporter to work around this:

Disable resource shrinking in this case, it will have no effect since there are no unused resources for this build
Use legacy AGP embedded shrinker - set android.r8.integratedResourceShrinking false in your settings
Manually update to a new R8 version (I will post a follow up when this is on our release branch)

gh...@google.com <gh...@google.com> #4Nov 28, 2022 10:44PM

Thanks!

Message last modified on Nov 28, 2022 10:49PM

gh...@google.com <gh...@google.com> #5Nov 29, 2022 12:02AM

Project: r8
Branch: main
Author: Rico Wind <ricow@google.com>
Link: https://r8-review.googlesource.com/102626

Fix usage of Immutable list in resource shrinker

Expand for full commit details

Fix usage of Immutable list in resource shrinker 
 
The returned list is mutable unless it is empty, allways create a copy. 
 
Bug: b/401546693 
Change-Id: I9ea50d23c365ea59e1f6ae5e13a02048daa8b5f8

Files:

M src/resourceshrinker/java/com/android/build/shrinker/r8integration/LegacyResourceShrinker.java
M src/test/java/com/android/tools/r8/androidresources/DuplicatedEntriesEmptyUnusedTest.java

Hash: dc5cae852ee11d42456d275afb1837d1f770306f
Date: Mon Mar 10 17:56:18 2025

gh...@google.com <gh...@google.com> Nov 29, 2022 06:18PM

Reassigned to tn...@google.com.

tn...@google.com <tn...@google.com> #6Dec 1, 2022 01:57AM

Marked as fixed.

Project: r8
Branch: main
Author: Rico Wind <ricow@google.com>
Link: https://r8-review.googlesource.com/102418

Add reproduction of adding to immutable list in resource shrinker