Allow pinning some of the lazy list items [259274257]

Fixed

Feature Request

Status Update

No update yet.

Description

an...@google.com

created issue #1

Nov 15, 2022 07:00PM

We need to provide an api (internal for now as the usage is in foundation) which allows to
1) Via composition local to find a parent pinnable parent
2) Call pin on it, which means that this composable will be kept composed even if it will naturally be scrolled our of the viewport of this pinnable parent
3) To be defined if we need to place such layoutnode or not. Probably we should, we can try to first pin it at some fake position outside the viewbounds
4) There should be a possibility to unpin it when the pinning is not needed anymore (for example the item is not focused anymore)
5) Such logic should work for nested lazy lists recursively, for example for cases when we have focused item inside LazyRow inside LazyColumn
6) Eventually the code should be abstracted away so it is easy to add such logic into your own LazyLayout implementation, for the first implementation we can just add it in LazyColumn as an internal api

Comments

st...@google.com <st...@google.com> Nov 18, 2022 11:38AM

Accepted by an...@google.com.

lo...@gmail.com <lo...@gmail.com> #2Dec 6, 2022 02:53PM

test

an...@google.com <an...@google.com> #3Dec 6, 2022 02:59PM

test

lo...@gmail.com <lo...@gmail.com> #4Dec 6, 2022 03:45PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit e2e911e8fcb08867b586cd4b0d92319dfa04e6db
Author: Siyamed Sinir <siyamed@google.com>
Date: Mon Oct 28 21:14:23 2019

Remove selectionColor from Text composable

Even though Text should define a selection color in the future:
- selection state of Text will probably more complicated than just a color
- initially it is better SelectionContainer to define those values
- it is better to enable this to be themed

Therefore selectionColor should not be a part of the Text composable as it is
right now. aosp/1149085 tries to introduce a selection style, and lets
SelectionContainer to install the selection style.

Test: ./gradlew ui:ui-framework:test
Test: ./gradlew ui:ui-framework:connectedAndroidTest
Test: ./gradlew ui:ui-text:test
Test: ./gradlew ui:ui-text:connectedAndroidTest

Bug: 139320372
Change-Id: I62aa2c45b59ab4d6991894795b12f61ab06806e0

M ui/ui-foundation/integration-tests/foundation-demos/src/main/java/androidx/ui/foundation/demos/PopupActivity.kt
M ui/ui-framework/api/0.1.0-dev03.txt
M ui/ui-framework/api/api_lint.ignore
M ui/ui-framework/api/current.txt
M ui/ui-framework/api/public_plus_experimental_0.1.0-dev03.txt
M ui/ui-framework/api/public_plus_experimental_current.txt
M ui/ui-framework/api/restricted_0.1.0-dev03.txt
M ui/ui-framework/api/restricted_current.txt
M ui/ui-framework/integration-tests/framework-demos/src/main/java/androidx/ui/framework/demos/autofill/ExplicitAutofillTypesActivity.kt
M ui/ui-framework/src/androidTest/java/androidx/ui/core/test/TextFieldTest.kt
M ui/ui-framework/src/main/java/androidx/ui/core/PasswordTextField.kt
M ui/ui-framework/src/main/java/androidx/ui/core/Text.kt
M ui/ui-framework/src/main/java/androidx/ui/core/TextField.kt
M ui/ui-framework/src/main/java/androidx/ui/core/TextFieldDelegate.kt
M ui/ui-framework/src/test/java/androidx/ui/core/TextFieldDelegateTest.kt
M ui/ui-text/api/0.1.0-dev03.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev03.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev03.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/integration-tests/text-demos/src/main/java/androidx/ui/text/demos/ComposeInputField.kt
M ui/ui-text/integration-tests/text-demos/src/main/java/androidx/ui/text/demos/ComposeInputFieldFocusTransition.kt
M ui/ui-text/integration-tests/text-demos/src/main/java/androidx/ui/text/demos/ComposeInputFieldTrickyUseCase.kt
M ui/ui-text/integration-tests/text-demos/src/main/java/androidx/ui/text/demos/ComposeVariousInputField.kt
D ui/ui-text/src/main/java/androidx/ui/input/EditorStyle.kt

https://android-review.googlesource.com/1153315

https://goto.google.com/android-sha1/e2e911e8fcb08867b586cd4b0d92319dfa04e6db

an...@google.com <an...@google.com> #5Dec 6, 2022 03:47PM

This bug was referenced by a recent CL that changed the Android API surface area.

The Android API Council <

http://go/android-api-council> regularly reviews API changes for
consistency and sustainability, and we've just added this bug to our hotlist of pending reviews.
We'll wait until you mark this bug as 'Fixed' before starting our review, but please reach out
if you'd like us to review it sooner.

CHANGES TO ui/ui-framework/api/current.txt

http://goto.google.com/android-api-diff/support/cur/pkg/androidx.ui.core

http://goto.google.com/android-api-diff/support/cur/clz/androidx.ui.core.PasswordTextFieldKt

http://goto.google.com/android-api-diff/support/cur/clz/androidx.ui.core.TextFieldKt

http://goto.google.com/android-api-diff/support/cur/clz/androidx.ui.core.TextKt

CHANGES TO ui/ui-framework/api/public_plus_experimental_current.txt

http://goto.google.com/android-api-diff/support/cur/pkg/androidx.ui.core

http://goto.google.com/android-api-diff/support/cur/clz/androidx.ui.core.PasswordTextFieldKt

http://goto.google.com/android-api-diff/support/cur/clz/androidx.ui.core.TextFieldKt

http://goto.google.com/android-api-diff/support/cur/clz/androidx.ui.core.TextKt

CHANGES TO ui/ui-text/api/current.txt

http://goto.google.com/android-api-diff/support/cur/pkg/androidx.ui.input

http://goto.google.com/android-api-diff/support/cur/clz/androidx.ui.input.EditorStyle

CHANGES TO ui/ui-text/api/public_plus_experimental_current.txt

http://goto.google.com/android-api-diff/support/cur/pkg/androidx.ui.input

http://goto.google.com/android-api-diff/support/cur/clz/androidx.ui.input.EditorStyle

The links above may take several days to start working. Generated from

http://go/support-current.txt/e2e911e8fcb08867b586cd4b0d92319dfa04e6db
CL:

http://android-review.googlesource.com/1153315
API Approvers: siyamed@google.com

lo...@gmail.com <lo...@gmail.com> #6Dec 6, 2022 04:05PM

bulk comment, fyi: we have added icebox to all the tickets because it was suggested by blintz in order to prevent auto-close tickets. we want to keep our Compose tickets to remain opened.

see

b/123001228#comment6

ap...@google.com <ap...@google.com> #7Dec 8, 2022 04:27PM

Marked as fixed.

(bulk comment) Hi,

Can you please check if this task can be finished before June, and if not remove `Jetpack Compose Major Release (May 2020)` hotlist?

(apologies if this is a double comment)

Thank you

na...@google.com <na...@google.com> #8Jan 11, 2023 08:11PM

(bulk comment)
Please ignore last comment related to the June release. It was caused by a mistake in the query I used. Thank you.

ch...@gmail.com <ch...@gmail.com> #9Jan 13, 2023 07:58AM

further postponing to category 3, since it doesn't look like we can accomplish this one. If time allows one of us will pick it up during category 2.

an...@google.com <an...@google.com> #10Jan 13, 2023 01:06PM

related: b/139320907

ch...@gmail.com <ch...@gmail.com> #11Jan 13, 2023 02:48PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 93195d42d1f079136053e33ccec6e7d5ac839dfe
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Tue Nov 17 15:20:25 2020

Adds AmbientTextSelectionColors to allow customizing the colors used for text selection

Also sets the correct Material defaults in MaterialTheme

Bug:

b/139320372

Bug:

b/139320907

Test: MaterialTextSelectionColorsScreenshotTest
Test: TextSelectionColorsScreenshotTest
Test: TextSelectionBackgroundColorTest
Relnote: "MaterialTheme now sets the correct colors for selection handles and selection background. Non-Material apps can manually use AmbientTextSelectionColors to customize the colors used for selection."
Change-Id: I1e6f4b495bdc713e162759a08ecf0a7311b26e33

M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/TextFieldDelegateIntegrationTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/CoreText.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/CoreTextField.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/TextFieldDelegate.kt
M compose/material/material/api/current.txt
M compose/material/material/api/public_plus_experimental_current.txt
M compose/material/material/api/restricted_current.txt
A compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/MaterialTextSelectionColorsScreenshotTest.kt
A compose/material/material/src/commonMain/kotlin/androidx/compose/material/MaterialTextSelectionColors.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/MaterialTheme.kt
A compose/material/material/src/test/kotlin/androidx/compose/material/TextSelectionBackgroundColorTest.kt
M compose/ui/ui/api/current.txt
M compose/ui/ui/api/public_plus_experimental_current.txt
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/selection/SelectionHandlesTest.kt
A compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/selection/TextSelectionColorsScreenshotTest.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/selection/SelectionHandles.kt
A compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/selection/TextSelectionColors.kt

https://android-review.googlesource.com/1502030

an...@google.com <an...@google.com> #12Jan 13, 2023 02:57PM

Even that you can try to hack it to help your use case, officially we are not recommending doing so. We hope that

b/230099236

we are currently investigating should help such use cases

ch...@gmail.com <ch...@gmail.com> #13Jan 13, 2023 04:56PM

Thanks for letting know that this isn't recommended approach.

What would be good usecase for LocalPinnableContainer?

an...@google.com <an...@google.com> #14Jan 13, 2023 04:58PM

Two use cases we are currently planning to use it for are keeping an item active when it is focused, or when text selection is including this item

pr...@google.com <pr...@google.com> #15Feb 8, 2023 06:21PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.tv:tv-foundation:1.0.0-alpha04