Allow pinning some of the lazy list items [259274257]

Fixed

Feature Request

Status Update

No update yet.

Description

an...@google.com

created issue #1

Nov 15, 2022 07:00PM

We need to provide an api (internal for now as the usage is in foundation) which allows to
1) Via composition local to find a parent pinnable parent
2) Call pin on it, which means that this composable will be kept composed even if it will naturally be scrolled our of the viewport of this pinnable parent
3) To be defined if we need to place such layoutnode or not. Probably we should, we can try to first pin it at some fake position outside the viewbounds
4) There should be a possibility to unpin it when the pinning is not needed anymore (for example the item is not focused anymore)
5) Such logic should work for nested lazy lists recursively, for example for cases when we have focused item inside LazyRow inside LazyColumn
6) Eventually the code should be abstracted away so it is easy to add such logic into your own LazyLayout implementation, for the first implementation we can just add it in LazyColumn as an internal api

Comments

st...@google.com <st...@google.com> Nov 18, 2022 11:38AM

Accepted by an...@google.com.

lo...@gmail.com <lo...@gmail.com> #2Dec 6, 2022 02:53PM

We have some support in androidx.compose.ui.autofill

Leaving this bug open in case Ralston wants to add more info

an...@google.com <an...@google.com> #3Dec 6, 2022 02:59PM

I found an example here. One problem is that it only works with the Google autofill service. When using any other service like Microsoft Authenticator or OneKey, the following error is shown:

D/Autofill Status: Autofill popup isn't shown because autofill is not available.
    
    Did you set up autofill?
    1. Go to Settings > System > Languages&input > Advanced > Autofill Service
    2. Pick a service
    
    Did you add an account?
    1. Go to Settings > System > Languages&input > Advanced
    2. Click on the settings icon next to the Autofill Service
    3. Add your account

Is this a bug on your side or do the app developers of these password managers need to change their implementation?

lo...@gmail.com <lo...@gmail.com> #4Dec 6, 2022 03:45PM

Another problem I am facing with autofill is that it won't save my credentials. I tried forcing to finish the context as described here, but it won't do that either although I filled in the username with the one provided by the Google autofill service.

an...@google.com <an...@google.com> #5Dec 6, 2022 03:47PM

deleted

lo...@gmail.com <lo...@gmail.com> #6Dec 6, 2022 04:05PM

Facing the same issue here, Google autofill service seems to work. Zero documentation on adding support for Autofill framework on jetpack compose.

ap...@google.com <ap...@google.com> #7Dec 8, 2022 04:27PM

Marked as fixed.

Hello, I am trying to implement the same thing - it seems like there's no way for current password managers like 1Password or Bitwarden, to automatically pick up the fields. Is there a possible solution?

na...@google.com <na...@google.com> #8Jan 11, 2023 08:11PM

I setup this modifier:

@OptIn(ExperimentalComposeUiApi::class)
fun Modifier.autofill(
    autofillTypes: List<AutofillType>,
    onFill: ((String) -> Unit),
) = composed {
    val autofill = LocalAutofill.current
    val autofillNode = AutofillNode(onFill = onFill, autofillTypes = autofillTypes)
    LocalAutofillTree.current += autofillNode

    this.onGloballyPositioned {
        autofillNode.boundingBox = it.boundsInWindow()
    }.onFocusChanged { focusState ->
        autofill?.run {
            if (focusState.isFocused) {
                requestAutofillForNode(autofillNode)
            } else {
                cancelAutofillForNode(autofillNode)
            }
        }
    }
}

And use it like this:

val emailState = remember { EmailState() }
Email(
    modifier = Modifier.autofill(
        autofillTypes = listOf(
            AutofillType.Username,
            AutofillType.EmailAddress
        ),
        onFill = { emailState.text = it },
    ),
    emailState = emailState,
    onImeAction = { onForgotPasswordSubmitted(emailState.text) }
)

With these steps, autofill works for me.

ch...@gmail.com <ch...@gmail.com> #9Jan 13, 2023 07:58AM

@lo...@gmail.com comment#8

what version of compose are you using? I'm using latest alpha and the above doesn't work for me. 😭

an...@google.com <an...@google.com> #10Jan 13, 2023 01:06PM

Works perfectly fine on the latest stable and alpha versions. Did you check in my second comment if you enabled everything?

ch...@gmail.com <ch...@gmail.com> #11Jan 13, 2023 02:48PM

I believe so?

I copied the modifier and then used

modifier = Modifier.autofill(
        autofillTypes = listOf(
            AutofillType.Username,
            AutofillType.EmailAddress
        ),
        onFill = { emailState.text = it },
    )

on my text field.

an...@google.com <an...@google.com> #12Jan 13, 2023 02:57PM

The auto-filling works for me with the latest alpha version, but I'm never presented with the save dialog though.

ch...@gmail.com <ch...@gmail.com> #13Jan 13, 2023 04:56PM

The auto-filling works for me with the latest alpha version, but I'm never presented with the save dialog though.

I am having exactly same problem. Autofill works, but the Save dialog is never shown...

an...@google.com <an...@google.com> #14Jan 13, 2023 04:58PM

Any updates on this? I can't get LastPass to display at all. I can ONLY get the Google Auto-fill service to work

pr...@google.com <pr...@google.com> #15Feb 8, 2023 06:21PM

Same here, autofill in Jetpack Compose only works with the Google auto-fill service. When picking 1Password as the Auto-fill service in Settings, the debug log prints out:

D/Autofill Status: Autofill popup isn't shown because autofill is not available.
    
    Did you set up autofill?
    1. Go to Settings > System > Languages&input > Advanced > Autofill Service
    2. Pick a service
    
    Did you add an account?
    1. Go to Settings > System > Languages&input > Advanced
    2. Click on the settings icon next to the Autofill Service
    3. Add your account