TestLifecycleOwner hangs inside of runTest [259344129]

Fixed

Bug

Status Update

No update yet.

Description

ji...@gmail.com

created issue #1

Nov 16, 2022 07:11PM

Component used: TestLifecycleOwner

Version used: 2.5.1

Devices/Android versions reproduced on: N/A

When used inside of runTest,

@OptIn(ExperimentalCoroutinesApi::class, ExperimentalStdlibApi::class)
class TestLifecycleOwnerTest {
  @Test
  fun testLifecycleOwnerStuff() = runTest(dispatchTimeoutMs = 5000) {
    Dispatchers.setMain(coroutineContext[CoroutineDispatcher]!!)
    val lifecycleOwner = TestLifecycleOwner()

    lifecycleOwner.currentState = Lifecycle.State.RESUMED
    Dispatchers.resetMain()
  }
}

...will hang and never return (not even after dispatchTimeoutMs expires)

Comments

sa...@google.com <sa...@google.com> #2Nov 16, 2022 09:28PM

Note that only target platforms supported by Compose (not to confuse with Compose Multiplatform) will be supported by the lifecycle-viewmodel-compose artifact.

ji...@gmail.com <ji...@gmail.com> #3Nov 16, 2022 10:11PM

Project: platform/frameworks/support
Branch: androidx-main

commit 74baccb421292733fcff3fc12335fdbfdb69ece0
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Wed Mar 20 11:39:47 2024

Add `KClass` method variants on `viewmodel-compose`

RelNote: "Composable `viewModel` functions now accept a `KClass` for Multiplatform compatibility. The `Class` variants are kept for Android compatibility."
Test: N/A
Bug: 330323282
Change-Id: I59611546d8a5fd133694817837a986c029fcd47e

M lifecycle/lifecycle-viewmodel-compose/api/current.txt
M lifecycle/lifecycle-viewmodel-compose/api/restricted_current.txt
M lifecycle/lifecycle-viewmodel-compose/src/androidMain/kotlin/androidx/lifecycle/viewmodel/compose/ViewModel.android.kt

https://android-review.googlesource.com/3007640

il...@google.com <il...@google.com> May 10, 2023 11:13PM

Assigned to sa...@google.com.

sa...@google.com <sa...@google.com> Aug 7, 2023 01:03PM

Accepted by sa...@google.com.

ap...@google.com <ap...@google.com> #4Aug 25, 2023 04:53PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 4beef5f6d988924a9640138db56f193301ef1329
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Wed Mar 20 11:18:32 2024

Configure KMP on `viewmodel-compose`

* Setup the build scripts.
* Setup folder hierarchy.

Test: N/A
Bug: 330323282
Change-Id: Ib7d563bb2c2277b3c3a4167803ffdc9472dcfd5c

M docs-tip-of-tree/build.gradle
M lifecycle/lifecycle-viewmodel-compose/build.gradle
M lifecycle/lifecycle-viewmodel-compose/src/androidInstrumentedTest/AndroidManifest.xml
M lifecycle/lifecycle-viewmodel-compose/src/androidInstrumentedTest/kotlin/androidx/lifecycle/viewmodel/compose/SavedStateHandleSaverTest.kt
M lifecycle/lifecycle-viewmodel-compose/src/androidInstrumentedTest/kotlin/androidx/lifecycle/viewmodel/compose/TestViewModelClasses.kt
M lifecycle/lifecycle-viewmodel-compose/src/androidInstrumentedTest/kotlin/androidx/lifecycle/viewmodel/compose/ViewModelInAppCompatActivityTest.kt
M lifecycle/lifecycle-viewmodel-compose/src/androidInstrumentedTest/kotlin/androidx/lifecycle/viewmodel/compose/ViewModelInComponentActivityTest.kt
M lifecycle/lifecycle-viewmodel-compose/src/androidInstrumentedTest/kotlin/androidx/lifecycle/viewmodel/compose/ViewModelInFragmentTest.kt
M lifecycle/lifecycle-viewmodel-compose/src/androidInstrumentedTest/kotlin/androidx/lifecycle/viewmodel/compose/ViewModelTest.kt
M lifecycle/lifecycle-viewmodel-compose/src/androidMain/kotlin/androidx/lifecycle/viewmodel/compose/LocalViewModelStoreOwner.kt
M lifecycle/lifecycle-viewmodel-compose/src/androidMain/kotlin/androidx/lifecycle/viewmodel/compose/SavedStateHandleSaveableApi.kt
M lifecycle/lifecycle-viewmodel-compose/src/androidMain/kotlin/androidx/lifecycle/viewmodel/compose/SavedStateHandleSaver.kt
M lifecycle/lifecycle-viewmodel-compose/src/androidMain/kotlin/androidx/lifecycle/viewmodel/compose/ViewModel.kt

https://android-review.googlesource.com/3007634

il...@google.com <il...@google.com> #5Aug 29, 2023 04:03PM

Project: platform/frameworks/support
Branch: androidx-main

commit 89a169b4573e1b28c7a5a73fd52d294bd0596a79
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Wed Mar 20 11:33:41 2024

Move `LocalViewModelStoreOwner` to common on `viewmodel-compose`

Test: N/A
Bug: 330323282
Change-Id: I1ead8036fc8b3c49d5846c417d301f281cff90e3

M lifecycle/lifecycle-viewmodel-compose/src/androidMain/kotlin/androidx/lifecycle/viewmodel/compose/LocalViewModelStoreOwner.android.kt
A lifecycle/lifecycle-viewmodel-compose/src/commonMain/kotlin/androidx/lifecycle/viewmodel/compose/LocalViewModelStoreOwner.kt
A lifecycle/lifecycle-viewmodel-compose/src/desktopMain/kotlin/androidx/lifecycle/viewmodel/compose/LocalViewModelStoreOwner.desktop.kt

https://android-review.googlesource.com/3007638

pr...@google.com <pr...@google.com> #6Sep 6, 2023 07:56PM

Project: platform/frameworks/support
Branch: androidx-main

commit b8e5ea51a234c4cdbbed82e41f6ffd28f630dcd9
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Wed Mar 20 11:22:15 2024

Rename source from `viewmodel-compose` to follow KMP convention

Test: N/A
Bug: 330323282
Change-Id: Ic417903127417b53f0888263a35fc5e4a82d57cc

M lifecycle/lifecycle-viewmodel-compose/src/androidInstrumentedTest/kotlin/androidx/lifecycle/viewmodel/compose/SavedStateHandleSaverTest.android.kt
M lifecycle/lifecycle-viewmodel-compose/src/androidInstrumentedTest/kotlin/androidx/lifecycle/viewmodel/compose/TestViewModelClasses.android.kt
M lifecycle/lifecycle-viewmodel-compose/src/androidInstrumentedTest/kotlin/androidx/lifecycle/viewmodel/compose/ViewModelInAppCompatActivityTest.android.kt
M lifecycle/lifecycle-viewmodel-compose/src/androidInstrumentedTest/kotlin/androidx/lifecycle/viewmodel/compose/ViewModelInComponentActivityTest.android.kt
M lifecycle/lifecycle-viewmodel-compose/src/androidInstrumentedTest/kotlin/androidx/lifecycle/viewmodel/compose/ViewModelInFragmentTest.android.kt
M lifecycle/lifecycle-viewmodel-compose/src/androidInstrumentedTest/kotlin/androidx/lifecycle/viewmodel/compose/ViewModelTest.android.kt
M lifecycle/lifecycle-viewmodel-compose/src/androidMain/kotlin/androidx/lifecycle/viewmodel/compose/LocalViewModelStoreOwner.android.kt
M lifecycle/lifecycle-viewmodel-compose/src/androidMain/kotlin/androidx/lifecycle/viewmodel/compose/SavedStateHandleSaveableApi.android.kt
M lifecycle/lifecycle-viewmodel-compose/src/androidMain/kotlin/androidx/lifecycle/viewmodel/compose/SavedStateHandleSaver.android.kt
M lifecycle/lifecycle-viewmodel-compose/src/androidMain/kotlin/androidx/lifecycle/viewmodel/compose/ViewModel.android.kt

https://android-review.googlesource.com/3007635