TestLifecycleOwner hangs inside of runTest [259344129]

Fixed

Bug

Status Update

No update yet.

Description

ji...@gmail.com

created issue #1

Nov 16, 2022 07:11PM

Component used: TestLifecycleOwner

Version used: 2.5.1

Devices/Android versions reproduced on: N/A

When used inside of runTest,

@OptIn(ExperimentalCoroutinesApi::class, ExperimentalStdlibApi::class)
class TestLifecycleOwnerTest {
  @Test
  fun testLifecycleOwnerStuff() = runTest(dispatchTimeoutMs = 5000) {
    Dispatchers.setMain(coroutineContext[CoroutineDispatcher]!!)
    val lifecycleOwner = TestLifecycleOwner()

    lifecycleOwner.currentState = Lifecycle.State.RESUMED
    Dispatchers.resetMain()
  }
}

...will hang and never return (not even after dispatchTimeoutMs expires)

Comments

sa...@google.com <sa...@google.com> #2Nov 16, 2022 09:28PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

ji...@gmail.com <ji...@gmail.com> #3Nov 16, 2022 10:11PM

Hi, are you able to step through and see which line it is hanging on?

It hangs on the following line:

lifecycleOwner.currentState = Lifecycle.State.RESUMED

Specifically, it hangs when currentState's setter calls runBlocking. runBlocking is not safe to call from a coroutine.

Also, what are you specifically trying to test here?

Sorry, my naming wasn't clear. This might make it more clear:

@OptIn(ExperimentalCoroutinesApi::class, ExperimentalStdlibApi::class)
class TestLifecycleOwnerTest {
  @Test
  fun canAssignToCurrentStateInRunTest() = runTest(dispatchTimeoutMs = 5000) {
    Dispatchers.setMain(coroutineContext[CoroutineDispatcher]!!)
    val lifecycleOwner = TestLifecycleOwner()

    lifecycleOwner.currentState = Lifecycle.State.RESUMED
    Dispatchers.resetMain()
  }
}

Assigning to currenState is basic functionality for using TestLifecycleOwner.

Our current workaround is to use UnconfinedTestDispatcher. UnconfinedTestDispatcher forces behaviors on us that StandardTestDispatcher does not, though, so this is not great.

il...@google.com <il...@google.com> May 10, 2023 11:13PM

Assigned to sa...@google.com.

sa...@google.com <sa...@google.com> Aug 7, 2023 01:03PM

Accepted by sa...@google.com.

ap...@google.com <ap...@google.com> #4Aug 25, 2023 04:53PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 7c76b7013a0229dd0f75cedd910a5005d53e52f3
Author: Sanura Njaka <sanura@google.com>
Date: Mon Aug 07 10:43:36 2023

Add new API to fix TestLifecycleOwner hanging inside of runTest

The use of runBlocking in TestLifecycleOwner causes
tests to hang when the api is used from the context of
another coroutine (such as runTest). To fix this, we
have added a suspending function to allow using
TestLifecycleOwner from within a coroutine.

RelNote: "`TestLifecycleOwner` now includes the suspending
function `setCurrentState()` to give users the option of using `TestLifecycleOwner` from within a coroutine."
Test: testSetCurrentStateInRunTest
Fixes: 259344129

Change-Id: I329de3d76bcd7fa5e04077916ff551f9f2f3f864

M lifecycle/lifecycle-runtime-testing/api/current.txt
M lifecycle/lifecycle-runtime-testing/api/restricted_current.txt
M lifecycle/lifecycle-runtime-testing/build.gradle
M lifecycle/lifecycle-runtime-testing/src/androidTest/java/androidx/lifecycle/testing/TestLifecycleOwnerAndroidTest.kt
M lifecycle/lifecycle-runtime-testing/src/main/java/androidx/lifecycle/testing/TestLifecycleOwner.kt

https://android-review.googlesource.com/2695369

il...@google.com <il...@google.com> #5Aug 29, 2023 04:03PM

We've added a suspend fun setCurrentState(Lifecycle.State) method on TestLifecycleOwner that keeps the requirement of dispatching all events on the coroutineDispatcher you've passed on TestLifecycleOwner's constructor while not blocking the current thread. This will be available in Lifecycle 2.7.0-alpha02.

The follow up bug, b/297880630 tracks adding a Lint warning for the current non-suspending version to point developers to use the new API if they are within a suspending context.

pr...@google.com <pr...@google.com> #6Sep 6, 2023 07:56PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.lifecycle:lifecycle-runtime-testing:2.7.0-alpha02