Status Update
Comments
tn...@google.com <tn...@google.com>
sh...@pinterest.com <sh...@pinterest.com> #3
I was finally able to repro, and what happens is that if you finish the Gemini onboarding flow, you'll get the Ask Gemini
text, but you have to restart the IDE to get the link to show up.
We need to fix that, or tweak the text before rebooting to either hide it or say something like ("reboot to enable Ask Gemini feature").
tn...@google.com <tn...@google.com> #4
Background:
This feature is implemented by chaining together 2 separate pieces:
-
com/android/tools/idea/logcat/messages/MessageFormatter.kt
adds the text "Ask Gemini". For every message from logcat, we check if it is an exception, and if so, add the text "Ask Gemini". -
A separate
EditorHyperlinkDetector
is responsible for "linkifying" the text. But this detector, only adds the studio bot specific logic if studio bot was enabled during initialization.
Due to the inconsistency in how (1) and (2) detect whether studio bot is available, we run into this situation when:
- On IDE start up, logcat is initializated. Studio Bot is not enabled at this time, so the hyper link detector doesn't add the studio bot specific logic.
- User on boards to Studio bot. After this, the MessageFormatter will start adding the text "Ask Gemini" for exceptions.
I think we should do a simple fix right away: We should always add the StudioBotFilter
to the hyper link detector. This can then check for whether studio bot is enabled internally, which should make (1) and (2) consistent in how they check for studio bot being active.
sh...@pinterest.com <sh...@pinterest.com> #5
Can you also add an option to disable the feature, even if I logged in to Gemini?
We often share logcat output in bugreports and such. This is noise we can do without.
Description
DESCRIBE THE ISSUE IN DETAIL:
We are seeing occasional errors on CI in
LintResourceRepository.getOrCreateRepository
. Based on the code and comments, this is a recoverable error, yet it still fails the lint task with aLintError
(and hence fails our builds.) Should it not be aLintWarning
instead? If it's recoverable I'd expect the lint task to be able to continue.I'm also happy to file a separate bug about the errors but we don't have any repro steps, as it happens intermittently, and only on CI.
Version of Gradle Plugin: 7.2.2 Version of Gradle: 7.3.3 Version of Java: openjdk 11.0.12 2021-07-20 OS: MacOS 12.6.1