Status Update
No update yet.
Comments
tn...@google.com
tn...@google.com
As I understand it, we need to migrate namespace definitions both from AndroidManifest.xml and from implicit definitions from applicationId / testApplicationId? Is that right? So an 8.0 project would have a
namespace <n>
testNamespace <tn>
where <n> is taken from AndroidManifest.xml package definitions if present, and applicationId if not, and <tn> is testApplicationId if present and <n>.test if not?
sh...@pinterest.com
Sorry for the confusion. AGP would change how it computes the namespace for the androidTest variant. All the Upgrade assistant would need to do is update the source code for the import of the R class.
tn...@google.com
OK! And, I think, this should happen at the same time as the namespace declaration is migrated from AndroidManifest.xml?
sh...@pinterest.com
It's unrelated, but it is possible that we move 8.0 to also only declare the namespace into the DSL. I would make it a separate refactoring because they are not tied at all.
Description
DESCRIBE THE ISSUE IN DETAIL:
We are seeing occasional errors on CI in
LintResourceRepository.getOrCreateRepository. Based on the code and comments, this is a recoverable error, yet it still fails the lint task with aLintError(and hence fails our builds.) Should it not be aLintWarninginstead? If it's recoverable I'd expect the lint task to be able to continue.I'm also happy to file a separate bug about the errors but we don't have any repro steps, as it happens intermittently, and only on CI.
Version of Gradle Plugin: 7.2.2 Version of Gradle: 7.3.3 Version of Java: openjdk 11.0.12 2021-07-20 OS: MacOS 12.6.1