Failure to deserialize lint resources cache results in a lint error (but should be a warning) [259363262]

Fixed

Bug

Status Update

No update yet.

Description

sh...@pinterest.com

created issue #1

Nov 16, 2022 09:58PM

DESCRIBE THE ISSUE IN DETAIL:

We are seeing occasional errors on CI in LintResourceRepository.getOrCreateRepository. Based on the code and comments, this is a recoverable error, yet it still fails the lint task with a LintError (and hence fails our builds.) Should it not be a LintWarning instead? If it's recoverable I'd expect the lint task to be able to continue.

I'm also happy to file a separate bug about the errors but we don't have any repro steps, as it happens intermittently, and only on CI.

Version of Gradle Plugin: 7.2.2 Version of Gradle: 7.3.3 Version of Java: openjdk 11.0.12 2021-07-20 OS: MacOS 12.6.1

Comments

tn...@google.com <tn...@google.com> Nov 21, 2022 03:17PM

Assigned to tn...@google.com.

tn...@google.com <tn...@google.com> #2Nov 21, 2022 10:33PM

Marked as fixed.

Thanks for the report. Would it be possible for you to share a zip dump of the inputs to R8, including the app's class files, keep rules, etc.? This should enable us to reproduce the build.

You can generate this by running:

./gradlew assembleRelease --no-daemon -Dcom.android.tools.r8.dumpinputtodirectory=/path/to/r8/dumps

sh...@pinterest.com <sh...@pinterest.com> #3Nov 30, 2022 10:04PM

Hi, thanks for response, here they are

Message last modified on Nov 30, 2022 11:20PM

tn...@google.com <tn...@google.com> #4Dec 1, 2022 02:35PM

Thanks for sharing. Looking at the code from the dump it is not immediately clear why this would fail with a NullPointerException. Would it be possible for you to also share the APK that is not working?

sh...@pinterest.com <sh...@pinterest.com> #5Dec 1, 2022 04:51PM

We experience the same problem after we upgraded to Gradle 8. Identical problem as reported in this ticket: with the setActivity call on a session:

java.lang.NullPointerException: Attempt to invoke virtual method 'boolean java.lang.String.equals(java.lang.Object)' on a null object reference
at com.google.android.gms.internal.fitness.zzfv.zza(com.google.android.gms:play-services-fitness@@21.1.0:1)
at com.google.android.gms.fitness.data.Session$Builder.setActivity(com.google.android.gms:play-services-fitness@@21.1.0:1)

It happens for example when invoking:
val session = Session.Builder()
.setDescription("our description")
.setIdentifier("our package name")
.setActivity(FitnessActivities.SLEEP)
.setStartTime(startSleepTime, TimeUnit.MILLISECONDS)
.setEndTime(endSleepTime, TimeUnit.MILLISECONDS)
.build()

We tried it with both with R8 fullMode default enabled and with R8 full mode disabled, but in both cases the error occurs.

We also tested this with JavaVersion.VERSION_1_8 and with JavaVersion.VERSION_17 and in both cases the problem occurs.

In all cases it works fine with a debug build.

We we revert to gradle 7.4.2. the problem disappears.

Please let me know how we can help you with additional information.

Issue 259363262