No implementation of ScalingLazyListScope.items for LazyPagingItems [259385813]

Fixed

Feature Request

Status Update

No update yet.

Description

ch...@meta.com

created issue #1

Nov 16, 2022 06:13PM

Component used:
Version used:
androidx.paging:paging-runtime:3.1.1
androidx.paging:paging-compose:1.0.0-alpha17
Devices/Android versions reproduced on: n/a

I'm trying to use the Paging 3 library for my Wear OS app, but I am unable to put the LazyPagingItems from my Pager implementation on a ScalingLazyColumn in the UI. I notice that you are able to do this for LazyColumn, but not for ScalingLazyColumn. Are there plans for ScalingLazyColumn to support LazyPagingItems?

Comments

cl...@google.com <cl...@google.com> #2Nov 18, 2022 01:07AM

Status: New

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

ys...@google.com <ys...@google.com> #3Nov 23, 2022 11:48AM

There is a POC of this integration which is reasonable simple here https://github.com/google/horologist/pull/517/files

ys...@google.com <ys...@google.com> #4Nov 25, 2022 08:58AM

We landed an updated version in Horologist. https://github.com/google/horologist/pull/777

It will be in 0.2.4 when released

If we want to support this in androidx.paging, we can deprecate this functionality in Horologist.

cl...@google.com <cl...@google.com> #5Mar 2, 2023 07:07PM

Assigned to cl...@google.com.

To update, we are planning new APIs to support custom implementations of LazyScopes.

ap...@google.com <ap...@google.com> #6Mar 30, 2023 07:27PM

Project: platform/frameworks/support
Branch: androidx-main

commit 96199071546a12a5583f3da96a1c8cdc05311f1b
Author: Clara Fok <clarafok@google.com>
Date: Thu Mar 16 12:39:01 2023

Implement LazyPagingItem itemKey as helper function

Added itemKey API which returns a lambda that can be plugged into `key` params for Lazy scopes.
If no key is provided, defaults to PagingPlaceholderKey(index) instead of compose's DefaultLazyKey

Test: Compose demos
Test: ./gradlew paging:paging-compose:cC
Bug: 259385813
Relnote: "LazyPagingItems has a new itemKey API which returns a key implementation that can be plugged into the `key` params of Lazy scopes. If no key is provided, defaults to using index-based PagingPlaceholderKey."

Change-Id: Ifa13b3d764203422645cac8bfc3d09278d508874

M compose/integration-tests/demos/build.gradle
M compose/integration-tests/demos/src/main/java/androidx/compose/integration/demos/Demos.kt
M paging/paging-compose/api/current.txt
M paging/paging-compose/api/public_plus_experimental_current.txt
M paging/paging-compose/api/restricted_current.txt
A paging/paging-compose/integration-tests/paging-demos/src/main/java/androidx/paging/compose/demos/PagingFoundationDemos.kt
M paging/paging-compose/samples/build.gradle
A paging/paging-compose/samples/src/main/java/androidx/paging/compose/samples/PagingFoundationSample.kt
A paging/paging-compose/src/main/java/androidx/paging/compose/LazyFoundationExtensions.kt
M paging/paging-compose/src/main/java/androidx/paging/compose/LazyPagingItems.kt
A paging/paging-compose/src/main/java/androidx/paging/compose/PagingPlaceholderKey.kt

https://android-review.googlesource.com/2494897

ap...@google.com <ap...@google.com> #7Apr 4, 2023 12:21AM

Project: platform/frameworks/support
Branch: androidx-main

commit 4bfb8df28135eac7f4cd306a85b72eb7db0386e1
Author: Clara Fok <clarafok@google.com>
Date: Fri Mar 31 15:16:04 2023

Implement LazyPagingItem itemContenType as helper function

Added itemContentType API which returns a lambda that can be plugged into `contentType` params for Lazy scopes.
If no contentType is provided, defaults to null contentType.

Test: Compose demos
Test: ./gradlew paging:paging-compose:cC
Bug: 259385813
Relnote: "LazyPagingItems has a new itemContentType API which returns a contentType implementation that can be plugged into the `contentType` params of Lazy scopes. If no contentType is provided, defaults to `null` contentType for all paging items."
Change-Id: Ib04f099111605af368c5b025d84a085ab4251fb6

M paging/paging-compose/api/current.txt
M paging/paging-compose/api/public_plus_experimental_current.txt
M paging/paging-compose/api/restricted_current.txt
M paging/paging-compose/integration-tests/paging-demos/src/main/java/androidx/paging/compose/demos/PagingFoundationDemos.kt
M paging/paging-compose/samples/src/main/java/androidx/paging/compose/samples/PagingFoundationSample.kt
M paging/paging-compose/src/androidTest/java/androidx/paging/compose/LazyPagingItemsTest.kt
M paging/paging-compose/src/main/java/androidx/paging/compose/LazyFoundationExtensions.kt
M paging/paging-compose/src/main/java/androidx/paging/compose/LazyPagingItems.kt
M paging/paging-compose/src/main/java/androidx/paging/compose/PagingPlaceholders.kt

https://android-review.googlesource.com/2518335

cl...@google.com <cl...@google.com> #8Apr 5, 2023 09:13PM

Marked as fixed.

Instead of writing an extension for ScalingLazyListScope, we wrote LazyPagingItems APIs for key and contentType with implementations that can be plugged directly into Lazy scopes such as ScalingLazyListScope.items.

https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:wear/compose/compose-foundation/src/commonMain/kotlin/androidx/wear/compose/foundation/lazy/ScalingLazyColumn.kt;l=91?q=scalinglazycolumn

cl...@google.com <cl...@google.com> #9Apr 6, 2023 08:42PM

Fixed internally and will be available in paging-compose 1.0.0-alpha19

na...@google.com <na...@google.com> #10May 3, 2023 06:24PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.paging:paging-compose:1.0.0-alpha19