Fixed
Status Update
Comments
ys...@google.com <ys...@google.com> #3
Split screen has 3 "stops" - 1/3, 1/2, and 2/3.
This looks like the icon is either getting cropped OR it is getting scrolled (same as other items such as Display > Lock screen display > Lock screen pop has a scrollable content inside). Do you know what is the case here?
In terms of solutions, assuming we need to keep all the elements, we can:
1. shrink the icon
2. let is scroll, and leave it WAI
This looks like the icon is either getting cropped OR it is getting scrolled (same as other items such as Display > Lock screen display > Lock screen pop has a scrollable content inside). Do you know what is the case here?
In terms of solutions, assuming we need to keep all the elements, we can:
1. shrink the icon
2. let is scroll, and leave it WAI
ys...@google.com <ys...@google.com> #4
I agree with Alok.
1. Can we shrink the icon to fit in the smallest UI scenario? (1/3 screen)?
-Is it possible to make the icon scalable? Or do we want to swap the icon to the smaller size?
2. If #1 is problematic, we could have a scroll bar for the description and icon area following our framework. Which is not ideal in this case.
1. Can we shrink the icon to fit in the smallest UI scenario? (1/3 screen)?
-Is it possible to make the icon scalable? Or do we want to swap the icon to the smaller size?
2. If #1 is problematic, we could have a scroll bar for the description and icon area following our framework. Which is not ideal in this case.
cl...@google.com <cl...@google.com> #5
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 32ad78e0ee659091e9074cc588d0759cd8b01d38
Author: Kevin Chyn <kchyn@google.com>
Date: Thu Jul 18 16:50:08 2019
Allow the FingerprintDialog to be scrollable
Fixes: 126367887
Test: Split screen, BiometricPromptDemo, dialog scrolls
Change-Id: Id14f116391c8ebfe27f1a7e6c40516ea0383221a
M biometric/res/layout/fingerprint_dialog_layout.xml
https://android-review.googlesource.com/1087532
https://goto.google.com/android-sha1/32ad78e0ee659091e9074cc588d0759cd8b01d38
Branch: androidx-master-dev
commit 32ad78e0ee659091e9074cc588d0759cd8b01d38
Author: Kevin Chyn <kchyn@google.com>
Date: Thu Jul 18 16:50:08 2019
Allow the FingerprintDialog to be scrollable
Fixes: 126367887
Test: Split screen, BiometricPromptDemo, dialog scrolls
Change-Id: Id14f116391c8ebfe27f1a7e6c40516ea0383221a
M biometric/res/layout/fingerprint_dialog_layout.xml
ap...@google.com <ap...@google.com> #6
Project: platform/frameworks/support
Branch: androidx-main
commit 96199071546a12a5583f3da96a1c8cdc05311f1b
Author: Clara Fok <clarafok@google.com>
Date: Thu Mar 16 12:39:01 2023
Implement LazyPagingItem itemKey as helper function
Added itemKey API which returns a lambda that can be plugged into `key` params for Lazy scopes.
If no key is provided, defaults to PagingPlaceholderKey(index) instead of compose's DefaultLazyKey
Test: Compose demos
Test: ./gradlew paging:paging-compose:cC
Bug: 259385813
Relnote: "LazyPagingItems has a new itemKey API which returns a key implementation that can be plugged into the `key` params of Lazy scopes. If no key is provided, defaults to using index-based PagingPlaceholderKey."
Change-Id: Ifa13b3d764203422645cac8bfc3d09278d508874
M compose/integration-tests/demos/build.gradle
M compose/integration-tests/demos/src/main/java/androidx/compose/integration/demos/Demos.kt
M paging/paging-compose/api/current.txt
M paging/paging-compose/api/public_plus_experimental_current.txt
M paging/paging-compose/api/restricted_current.txt
A paging/paging-compose/integration-tests/paging-demos/src/main/java/androidx/paging/compose/demos/PagingFoundationDemos.kt
M paging/paging-compose/samples/build.gradle
A paging/paging-compose/samples/src/main/java/androidx/paging/compose/samples/PagingFoundationSample.kt
A paging/paging-compose/src/main/java/androidx/paging/compose/LazyFoundationExtensions.kt
M paging/paging-compose/src/main/java/androidx/paging/compose/LazyPagingItems.kt
A paging/paging-compose/src/main/java/androidx/paging/compose/PagingPlaceholderKey.kt
https://android-review.googlesource.com/2494897
Branch: androidx-main
commit 96199071546a12a5583f3da96a1c8cdc05311f1b
Author: Clara Fok <clarafok@google.com>
Date: Thu Mar 16 12:39:01 2023
Implement LazyPagingItem itemKey as helper function
Added itemKey API which returns a lambda that can be plugged into `key` params for Lazy scopes.
If no key is provided, defaults to PagingPlaceholderKey(index) instead of compose's DefaultLazyKey
Test: Compose demos
Test: ./gradlew paging:paging-compose:cC
Bug: 259385813
Relnote: "LazyPagingItems has a new itemKey API which returns a key implementation that can be plugged into the `key` params of Lazy scopes. If no key is provided, defaults to using index-based PagingPlaceholderKey."
Change-Id: Ifa13b3d764203422645cac8bfc3d09278d508874
M compose/integration-tests/demos/build.gradle
M compose/integration-tests/demos/src/main/java/androidx/compose/integration/demos/Demos.kt
M paging/paging-compose/api/current.txt
M paging/paging-compose/api/public_plus_experimental_current.txt
M paging/paging-compose/api/restricted_current.txt
A paging/paging-compose/integration-tests/paging-demos/src/main/java/androidx/paging/compose/demos/PagingFoundationDemos.kt
M paging/paging-compose/samples/build.gradle
A paging/paging-compose/samples/src/main/java/androidx/paging/compose/samples/PagingFoundationSample.kt
A paging/paging-compose/src/main/java/androidx/paging/compose/LazyFoundationExtensions.kt
M paging/paging-compose/src/main/java/androidx/paging/compose/LazyPagingItems.kt
A paging/paging-compose/src/main/java/androidx/paging/compose/PagingPlaceholderKey.kt
ap...@google.com <ap...@google.com> #7
Project: platform/frameworks/support
Branch: androidx-main
commit 4bfb8df28135eac7f4cd306a85b72eb7db0386e1
Author: Clara Fok <clarafok@google.com>
Date: Fri Mar 31 15:16:04 2023
Implement LazyPagingItem itemContenType as helper function
Added itemContentType API which returns a lambda that can be plugged into `contentType` params for Lazy scopes.
If no contentType is provided, defaults to null contentType.
Test: Compose demos
Test: ./gradlew paging:paging-compose:cC
Bug: 259385813
Relnote: "LazyPagingItems has a new itemContentType API which returns a contentType implementation that can be plugged into the `contentType` params of Lazy scopes. If no contentType is provided, defaults to `null` contentType for all paging items."
Change-Id: Ib04f099111605af368c5b025d84a085ab4251fb6
M paging/paging-compose/api/current.txt
M paging/paging-compose/api/public_plus_experimental_current.txt
M paging/paging-compose/api/restricted_current.txt
M paging/paging-compose/integration-tests/paging-demos/src/main/java/androidx/paging/compose/demos/PagingFoundationDemos.kt
M paging/paging-compose/samples/src/main/java/androidx/paging/compose/samples/PagingFoundationSample.kt
M paging/paging-compose/src/androidTest/java/androidx/paging/compose/LazyPagingItemsTest.kt
M paging/paging-compose/src/main/java/androidx/paging/compose/LazyFoundationExtensions.kt
M paging/paging-compose/src/main/java/androidx/paging/compose/LazyPagingItems.kt
M paging/paging-compose/src/main/java/androidx/paging/compose/PagingPlaceholders.kt
https://android-review.googlesource.com/2518335
Branch: androidx-main
commit 4bfb8df28135eac7f4cd306a85b72eb7db0386e1
Author: Clara Fok <clarafok@google.com>
Date: Fri Mar 31 15:16:04 2023
Implement LazyPagingItem itemContenType as helper function
Added itemContentType API which returns a lambda that can be plugged into `contentType` params for Lazy scopes.
If no contentType is provided, defaults to null contentType.
Test: Compose demos
Test: ./gradlew paging:paging-compose:cC
Bug: 259385813
Relnote: "LazyPagingItems has a new itemContentType API which returns a contentType implementation that can be plugged into the `contentType` params of Lazy scopes. If no contentType is provided, defaults to `null` contentType for all paging items."
Change-Id: Ib04f099111605af368c5b025d84a085ab4251fb6
M paging/paging-compose/api/current.txt
M paging/paging-compose/api/public_plus_experimental_current.txt
M paging/paging-compose/api/restricted_current.txt
M paging/paging-compose/integration-tests/paging-demos/src/main/java/androidx/paging/compose/demos/PagingFoundationDemos.kt
M paging/paging-compose/samples/src/main/java/androidx/paging/compose/samples/PagingFoundationSample.kt
M paging/paging-compose/src/androidTest/java/androidx/paging/compose/LazyPagingItemsTest.kt
M paging/paging-compose/src/main/java/androidx/paging/compose/LazyFoundationExtensions.kt
M paging/paging-compose/src/main/java/androidx/paging/compose/LazyPagingItems.kt
M paging/paging-compose/src/main/java/androidx/paging/compose/PagingPlaceholders.kt
cl...@google.com <cl...@google.com> #8
Instead of writing an extension for ScalingLazyListScope
, we wrote LazyPagingItems APIs for key and contentType with implementations that can be plugged directly into Lazy scopes such as ScalingLazyListScope.items
.
cl...@google.com <cl...@google.com> #9
Fixed internally and will be available in paging-compose 1.0.0-alpha19
na...@google.com <na...@google.com> #10
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.paging:paging-compose:1.0.0-alpha19
Description
Version used:
androidx.paging:paging-runtime:3.1.1
androidx.paging:paging-compose:1.0.0-alpha17
Devices/Android versions reproduced on: n/a
I'm trying to use the Paging 3 library for my Wear OS app, but I am unable to put the LazyPagingItems from my Pager implementation on a ScalingLazyColumn in the UI. I notice that you are able to do this for LazyColumn, but not for ScalingLazyColumn. Are there plans for ScalingLazyColumn to support LazyPagingItems?