No implementation of ScalingLazyListScope.items for LazyPagingItems [259385813]

Fixed

Feature Request

Status Update

No update yet.

Description

ch...@meta.com

created issue #1

Nov 16, 2022 06:13PM

Component used:
Version used:
androidx.paging:paging-runtime:3.1.1
androidx.paging:paging-compose:1.0.0-alpha17
Devices/Android versions reproduced on: n/a

I'm trying to use the Paging 3 library for my Wear OS app, but I am unable to put the LazyPagingItems from my Pager implementation on a ScalingLazyColumn in the UI. I notice that you are able to do this for LazyColumn, but not for ScalingLazyColumn. Are there plans for ScalingLazyColumn to support LazyPagingItems?

Comments

cl...@google.com <cl...@google.com> #2Nov 18, 2022 01:07AM

Status: New

Looks very similar to

https://issuetracker.google.com/issues/130561500tt

ys...@google.com <ys...@google.com> #3Nov 23, 2022 11:48AM

It seems like this could be addressed by updating the EnumType.parseValue() method, adding a fallback case in which if none of the enum values matches, then try to find a case insensitive match and return it.

maybe something like this?

public override fun parseValue(value: String): D {
    var caseInsensitiveMatch: D? = null
    for (constant in type.enumConstants) {
        val enumConstant = (constant as Enum<*>)
        if (enumConstant.name == value) {
            return constant
        }
        if (enumConstant.name.equals(value, ignoreCase = true) && caseInsensitiveMatch == null) {
            caseInsensitiveMatch = constant
        }
    }
    if (caseInsensitiveMatch != null) return caseInsensitiveMatch
    throw IllegalArgumentException(
        "Enum value $value not found for type ${type.name}."
    )
}

I'd be happy to submit a complete Pull Request if you think this is a good solution.

ys...@google.com <ys...@google.com> #4Nov 25, 2022 08:58AM

I have opened a PR to Fix this ... https://github.com/androidx/androidx/pull/152

cl...@google.com <cl...@google.com> #5Mar 2, 2023 07:07PM

Assigned to cl...@google.com.

Project: platform/frameworks/support
Branch: androidx-main

commit fd55939285777560a833f259725fd62e181249e9
Author: Brad Ball <github@bradball.net>
Date: Tue Apr 13 13:03:12 2021

[GH] [Navigation] Allow case-insensitive matches of Enum args in deep links

## Proposed Changes
Deep Link arguments that are Enum types would only match and get parsed if the casing of the argument value was an exact match to the casing of the Enum value. Since enum values are typically all upper case, this required deep links to contain upper case values as well, meaning if you have an enum with a value of say `Bitmap.Config.ALPHA_8`, a deep link that has an argument of type `Bitmap.Config` will only match if the URL contains `/ALPHA_8` and will not match a url with `/alpha_8`.

This PR updates the EnumType value parsing to include case-insensitive matching. It will first try to parse an enum value using a case-sensitive match, and if no match is found, it will then try to parse the enum value using a case-insensitive match.

Given the following enum:
```
enum class Colors {
RED,
BLUE,
GREEN
}
```

And a destination with an Enum argument and deep link:
```
<argument
android:name="destColor"
app:argType="com.my.app.Colors"
android:defaultValue="RED" />

<deepLink
app:uri="

https://myapp.com/{destColor}" />
```

This PR updates the EnumType parsing so that a url like `

https://myapp.com/green` will be matched and the `destColor` will be set to `Colors.GREEN`

## Testing
- There were no existing tests for the EnumType.parseValue() method.
- I added a test in `NavTypeTest` to test `EnumType.parseValue()` asserting that both case-sensitive and case-insensitive values are matched.

Test: /gradlew test connnectedCheck

## Issues Fixed

https://issuetracker.google.com/issues/135857840
Fixes:

b/135857840

This is an imported pull request from

https://github.com/androidx/androidx/pull/152.

Resolves #152
Github-Pr-Head-Sha: c7f5aefa7bb58a1224782ec269bb20f5a8dc8f04
GitOrigin-RevId: f8da24d9cd33f24b24763c87a4574979b0d1fbdc
Change-Id: I7738eaab2d64ff2bfeb20d5987190d0279a75314

M navigation/navigation-common/src/androidTest/java/androidx/navigation/NavTypeTest.kt
M navigation/navigation-common/src/main/java/androidx/navigation/NavType.kt

https://android-review.googlesource.com/1674765

ap...@google.com <ap...@google.com> #6Mar 30, 2023 07:27PM

Project: platform/frameworks/support
Branch: androidx-main

commit 96199071546a12a5583f3da96a1c8cdc05311f1b
Author: Clara Fok <clarafok@google.com>
Date: Thu Mar 16 12:39:01 2023

Implement LazyPagingItem itemKey as helper function

Added itemKey API which returns a lambda that can be plugged into `key` params for Lazy scopes.
If no key is provided, defaults to PagingPlaceholderKey(index) instead of compose's DefaultLazyKey

Test: Compose demos
Test: ./gradlew paging:paging-compose:cC
Bug: 259385813
Relnote: "LazyPagingItems has a new itemKey API which returns a key implementation that can be plugged into the `key` params of Lazy scopes. If no key is provided, defaults to using index-based PagingPlaceholderKey."

Change-Id: Ifa13b3d764203422645cac8bfc3d09278d508874

M compose/integration-tests/demos/build.gradle
M compose/integration-tests/demos/src/main/java/androidx/compose/integration/demos/Demos.kt
M paging/paging-compose/api/current.txt
M paging/paging-compose/api/public_plus_experimental_current.txt
M paging/paging-compose/api/restricted_current.txt
A paging/paging-compose/integration-tests/paging-demos/src/main/java/androidx/paging/compose/demos/PagingFoundationDemos.kt
M paging/paging-compose/samples/build.gradle
A paging/paging-compose/samples/src/main/java/androidx/paging/compose/samples/PagingFoundationSample.kt
A paging/paging-compose/src/main/java/androidx/paging/compose/LazyFoundationExtensions.kt
M paging/paging-compose/src/main/java/androidx/paging/compose/LazyPagingItems.kt
A paging/paging-compose/src/main/java/androidx/paging/compose/PagingPlaceholderKey.kt

https://android-review.googlesource.com/2494897

ap...@google.com <ap...@google.com> #7Apr 4, 2023 12:21AM

Project: platform/frameworks/support
Branch: androidx-main

commit 4bfb8df28135eac7f4cd306a85b72eb7db0386e1
Author: Clara Fok <clarafok@google.com>
Date: Fri Mar 31 15:16:04 2023

Implement LazyPagingItem itemContenType as helper function

Added itemContentType API which returns a lambda that can be plugged into `contentType` params for Lazy scopes.
If no contentType is provided, defaults to null contentType.

Test: Compose demos
Test: ./gradlew paging:paging-compose:cC
Bug: 259385813
Relnote: "LazyPagingItems has a new itemContentType API which returns a contentType implementation that can be plugged into the `contentType` params of Lazy scopes. If no contentType is provided, defaults to `null` contentType for all paging items."
Change-Id: Ib04f099111605af368c5b025d84a085ab4251fb6

M paging/paging-compose/api/current.txt
M paging/paging-compose/api/public_plus_experimental_current.txt
M paging/paging-compose/api/restricted_current.txt
M paging/paging-compose/integration-tests/paging-demos/src/main/java/androidx/paging/compose/demos/PagingFoundationDemos.kt
M paging/paging-compose/samples/src/main/java/androidx/paging/compose/samples/PagingFoundationSample.kt
M paging/paging-compose/src/androidTest/java/androidx/paging/compose/LazyPagingItemsTest.kt
M paging/paging-compose/src/main/java/androidx/paging/compose/LazyFoundationExtensions.kt
M paging/paging-compose/src/main/java/androidx/paging/compose/LazyPagingItems.kt
M paging/paging-compose/src/main/java/androidx/paging/compose/PagingPlaceholders.kt

https://android-review.googlesource.com/2518335

cl...@google.com <cl...@google.com> #8Apr 5, 2023 09:13PM

Marked as fixed.

Instead of writing an extension for ScalingLazyListScope, we wrote LazyPagingItems APIs for key and contentType with implementations that can be plugged directly into Lazy scopes such as ScalingLazyListScope.items.

https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:wear/compose/compose-foundation/src/commonMain/kotlin/androidx/wear/compose/foundation/lazy/ScalingLazyColumn.kt;l=91?q=scalinglazycolumn

cl...@google.com <cl...@google.com> #9Apr 6, 2023 08:42PM

Fixed internally and will be available in paging-compose 1.0.0-alpha19

na...@google.com <na...@google.com> #10May 3, 2023 06:24PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.paging:paging-compose:1.0.0-alpha19