Fixed
Status Update
No update yet.
Comments
cl...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
https://android-review.googlesource.com/1123258
https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
ys...@google.com
ys...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
https://android-review.googlesource.com/1288456
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
cl...@google.com
To update, we are planning new APIs to support custom implementations of LazyScopes.
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 96199071546a12a5583f3da96a1c8cdc05311f1b
Author: Clara Fok <clarafok@google.com>
Date: Thu Mar 16 12:39:01 2023
Implement LazyPagingItem itemKey as helper function
Added itemKey API which returns a lambda that can be plugged into `key` params for Lazy scopes.
If no key is provided, defaults to PagingPlaceholderKey(index) instead of compose's DefaultLazyKey
Test: Compose demos
Test: ./gradlew paging:paging-compose:cC
Bug: 259385813
Relnote: "LazyPagingItems has a new itemKey API which returns a key implementation that can be plugged into the `key` params of Lazy scopes. If no key is provided, defaults to using index-based PagingPlaceholderKey."
Change-Id: Ifa13b3d764203422645cac8bfc3d09278d508874
M compose/integration-tests/demos/build.gradle
M compose/integration-tests/demos/src/main/java/androidx/compose/integration/demos/Demos.kt
M paging/paging-compose/api/current.txt
M paging/paging-compose/api/public_plus_experimental_current.txt
M paging/paging-compose/api/restricted_current.txt
A paging/paging-compose/integration-tests/paging-demos/src/main/java/androidx/paging/compose/demos/PagingFoundationDemos.kt
M paging/paging-compose/samples/build.gradle
A paging/paging-compose/samples/src/main/java/androidx/paging/compose/samples/PagingFoundationSample.kt
A paging/paging-compose/src/main/java/androidx/paging/compose/LazyFoundationExtensions.kt
M paging/paging-compose/src/main/java/androidx/paging/compose/LazyPagingItems.kt
A paging/paging-compose/src/main/java/androidx/paging/compose/PagingPlaceholderKey.kt
https://android-review.googlesource.com/2494897
Branch: androidx-main
commit 96199071546a12a5583f3da96a1c8cdc05311f1b
Author: Clara Fok <clarafok@google.com>
Date: Thu Mar 16 12:39:01 2023
Implement LazyPagingItem itemKey as helper function
Added itemKey API which returns a lambda that can be plugged into `key` params for Lazy scopes.
If no key is provided, defaults to PagingPlaceholderKey(index) instead of compose's DefaultLazyKey
Test: Compose demos
Test: ./gradlew paging:paging-compose:cC
Bug: 259385813
Relnote: "LazyPagingItems has a new itemKey API which returns a key implementation that can be plugged into the `key` params of Lazy scopes. If no key is provided, defaults to using index-based PagingPlaceholderKey."
Change-Id: Ifa13b3d764203422645cac8bfc3d09278d508874
M compose/integration-tests/demos/build.gradle
M compose/integration-tests/demos/src/main/java/androidx/compose/integration/demos/Demos.kt
M paging/paging-compose/api/current.txt
M paging/paging-compose/api/public_plus_experimental_current.txt
M paging/paging-compose/api/restricted_current.txt
A paging/paging-compose/integration-tests/paging-demos/src/main/java/androidx/paging/compose/demos/PagingFoundationDemos.kt
M paging/paging-compose/samples/build.gradle
A paging/paging-compose/samples/src/main/java/androidx/paging/compose/samples/PagingFoundationSample.kt
A paging/paging-compose/src/main/java/androidx/paging/compose/LazyFoundationExtensions.kt
M paging/paging-compose/src/main/java/androidx/paging/compose/LazyPagingItems.kt
A paging/paging-compose/src/main/java/androidx/paging/compose/PagingPlaceholderKey.kt
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 4bfb8df28135eac7f4cd306a85b72eb7db0386e1
Author: Clara Fok <clarafok@google.com>
Date: Fri Mar 31 15:16:04 2023
Implement LazyPagingItem itemContenType as helper function
Added itemContentType API which returns a lambda that can be plugged into `contentType` params for Lazy scopes.
If no contentType is provided, defaults to null contentType.
Test: Compose demos
Test: ./gradlew paging:paging-compose:cC
Bug: 259385813
Relnote: "LazyPagingItems has a new itemContentType API which returns a contentType implementation that can be plugged into the `contentType` params of Lazy scopes. If no contentType is provided, defaults to `null` contentType for all paging items."
Change-Id: Ib04f099111605af368c5b025d84a085ab4251fb6
M paging/paging-compose/api/current.txt
M paging/paging-compose/api/public_plus_experimental_current.txt
M paging/paging-compose/api/restricted_current.txt
M paging/paging-compose/integration-tests/paging-demos/src/main/java/androidx/paging/compose/demos/PagingFoundationDemos.kt
M paging/paging-compose/samples/src/main/java/androidx/paging/compose/samples/PagingFoundationSample.kt
M paging/paging-compose/src/androidTest/java/androidx/paging/compose/LazyPagingItemsTest.kt
M paging/paging-compose/src/main/java/androidx/paging/compose/LazyFoundationExtensions.kt
M paging/paging-compose/src/main/java/androidx/paging/compose/LazyPagingItems.kt
M paging/paging-compose/src/main/java/androidx/paging/compose/PagingPlaceholders.kt
https://android-review.googlesource.com/2518335
Branch: androidx-main
commit 4bfb8df28135eac7f4cd306a85b72eb7db0386e1
Author: Clara Fok <clarafok@google.com>
Date: Fri Mar 31 15:16:04 2023
Implement LazyPagingItem itemContenType as helper function
Added itemContentType API which returns a lambda that can be plugged into `contentType` params for Lazy scopes.
If no contentType is provided, defaults to null contentType.
Test: Compose demos
Test: ./gradlew paging:paging-compose:cC
Bug: 259385813
Relnote: "LazyPagingItems has a new itemContentType API which returns a contentType implementation that can be plugged into the `contentType` params of Lazy scopes. If no contentType is provided, defaults to `null` contentType for all paging items."
Change-Id: Ib04f099111605af368c5b025d84a085ab4251fb6
M paging/paging-compose/api/current.txt
M paging/paging-compose/api/public_plus_experimental_current.txt
M paging/paging-compose/api/restricted_current.txt
M paging/paging-compose/integration-tests/paging-demos/src/main/java/androidx/paging/compose/demos/PagingFoundationDemos.kt
M paging/paging-compose/samples/src/main/java/androidx/paging/compose/samples/PagingFoundationSample.kt
M paging/paging-compose/src/androidTest/java/androidx/paging/compose/LazyPagingItemsTest.kt
M paging/paging-compose/src/main/java/androidx/paging/compose/LazyFoundationExtensions.kt
M paging/paging-compose/src/main/java/androidx/paging/compose/LazyPagingItems.kt
M paging/paging-compose/src/main/java/androidx/paging/compose/PagingPlaceholders.kt
cl...@google.com
Instead of writing an extension for ScalingLazyListScope, we wrote LazyPagingItems APIs for key and contentType with implementations that can be plugged directly into Lazy scopes such as ScalingLazyListScope.items.
cl...@google.com
Fixed internally and will be available in paging-compose 1.0.0-alpha19
na...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.paging:paging-compose:1.0.0-alpha19
Description
Version used:
androidx.paging:paging-runtime:3.1.1
androidx.paging:paging-compose:1.0.0-alpha17
Devices/Android versions reproduced on: n/a
I'm trying to use the Paging 3 library for my Wear OS app, but I am unable to put the LazyPagingItems from my Pager implementation on a ScalingLazyColumn in the UI. I notice that you are able to do this for LazyColumn, but not for ScalingLazyColumn. Are there plans for ScalingLazyColumn to support LazyPagingItems?