StackSampling enabled in Benchmark: "read failed: Is a directory" at the end of the run [259424099]

Fixed

Bug

Status Update

No update yet.

Description

jg...@google.com

created issue #1

Nov 16, 2022 07:01PM

Repro-steps:

./gradlew --daemon :benchmark:benchmark-benchmark:connectedCheck \
 -P android.testInstrumentationRunnerArguments.class=androidx.benchmark.benchmark.PerfettoSdkOverheadBenchmark#traceBeginEnd_perfettoSdkTrace \
 -P android.testInstrumentationRunnerArguments.androidx.benchmark.profiling.mode=StackSampling \
 -P android.testInstrumentationRunnerArguments.androidx.benchmark.profiling.sampleDurationSeconds=10 \
 -P android.testInstrumentationRunnerArguments.androidx.benchmark.profiling.sampleFrequency=1000

Result:

Exception thrown during onAfterEach invocation of plugin com.android.tools.utp.plugins.host.additionaltestoutput.AndroidAdditionalTestOutputPlugin for test case PerfettoSdkOverheadBenchmark#traceBeginEnd_perfettoSdkTrace.
read failed: Is a directory
com.android.ddmlib.SyncException: read failed: Is a directory
        at com.android.ddmlib.SyncService.doPullFile(SyncService.java:567)
        at com.android.ddmlib.SyncService.pullFile(SyncService.java:351)
        at com.android.ddmlib.internal.DeviceImpl.pullFile(DeviceImpl.java:1145)
        at com.android.tools.utp.plugins.deviceprovider.ddmlib.DdmlibAndroidDevice.pullFile(DdmlibAndroidDevice.kt)
        at com.android.tools.utp.plugins.deviceprovider.ddmlib.DdmlibAndroidDeviceController.pull(DdmlibAndroidDeviceController.kt:274)
        at com.google.testing.platform.executor.DeviceControllerProxy$pull$2.invoke(DeviceControllerProxy.kt:100)
        at com.google.testing.platform.executor.DeviceControllerProxy$pull$2.invoke(DeviceControllerProxy.kt:97)
        at com.google.testing.platform.core.telemetry.common.noop.NoopDiagnosticsScope.recordEvent(NoopDiagnosticsScope.kt:35)
        at com.google.testing.platform.core.telemetry.TelemetryKt.recordEvent(Telemetry.kt:66)
        at com.google.testing.platform.executor.DeviceControllerProxy.pull(DeviceControllerProxy.kt:97)
        at com.android.tools.utp.plugins.host.additionaltestoutput.AndroidAdditionalTestOutputPlugin.addBenchmarkFiles(AndroidAdditionalTestOutputPlugin.kt:194)
        at com.android.tools.utp.plugins.host.additionaltestoutput.AndroidAdditionalTestOutputPlugin.addBenchmarkOutput(AndroidAdditionalTestOutputPlugin.kt:158)
        at com.android.tools.utp.plugins.host.additionaltestoutput.AndroidAdditionalTestOutputPlugin.afterEach(AndroidAdditionalTestOutputPlugin.kt:126)
        at com.google.testing.platform.plugin.PluginLifecycle$onAfterEach$1$mergedResult$1$1$1$1.invoke(PluginLifecycle.kt:220)
        at com.google.testing.platform.plugin.PluginLifecycle$onAfterEach$1$mergedResult$1$1$1$1.invoke(PluginLifecycle.kt:219)
        at com.google.testing.platform.plugin.PluginLifecycle$verify$1.invoke(PluginLifecycle.kt:104)
        at com.google.testing.platform.api.event.Events.verify(Events.kt:31)
        at com.google.testing.platform.plugin.PluginLifecycle.verify(PluginLifecycle.kt:104)
        at com.google.testing.platform.plugin.PluginLifecycle.access$verify(PluginLifecycle.kt:52)
        at com.google.testing.platform.plugin.PluginLifecycle$onAfterEach$1$mergedResult$1$1.invoke(PluginLifecycle.kt:219)
        at com.google.testing.platform.plugin.PluginLifecycle$onAfterEach$1$mergedResult$1$1.invoke(PluginLifecycle.kt:210)
        at com.google.testing.platform.plugin.PluginLifecycleKt$invokeOrThrow$1.invoke(PluginLifecycle.kt:374)
        at com.google.testing.platform.plugin.PluginLifecycleKt$invokeOrThrow$1.invoke(PluginLifecycle.kt:374)
        at com.google.testing.platform.core.telemetry.common.noop.NoopDiagnosticsScope.recordEvent(NoopDiagnosticsScope.kt:35)
        at com.google.testing.platform.core.telemetry.TelemetryKt.recordEvent(Telemetry.kt:105)
        at com.google.testing.platform.core.telemetry.TelemetryKt.recordEvent$default(Telemetry.kt:98)
        at com.google.testing.platform.plugin.PluginLifecycleKt.invokeOrThrow(PluginLifecycle.kt:374)
        at com.google.testing.platform.plugin.PluginLifecycleKt.access$invokeOrThrow(PluginLifecycle.kt:1)
        at com.google.testing.platform.plugin.PluginLifecycle$onAfterEach$1.invoke(PluginLifecycle.kt:210)
        at com.google.testing.platform.plugin.PluginLifecycle$onAfterEach$1.invoke(PluginLifecycle.kt:201)
        at com.google.testing.platform.core.telemetry.common.noop.NoopDiagnosticsScope.recordEvent(NoopDiagnosticsScope.kt:35)
        at com.google.testing.platform.core.telemetry.TelemetryKt.recordEvent(Telemetry.kt:105)
        at com.google.testing.platform.core.telemetry.TelemetryKt.recordEvent$default(Telemetry.kt:98)
        at com.google.testing.platform.plugin.PluginLifecycle.onAfterEach(PluginLifecycle.kt:201)
        at com.google.testing.platform.executor.SingleDeviceExecutor$execute$2.invoke(SingleDeviceExecutor.kt:97)
        at com.google.testing.platform.executor.SingleDeviceExecutor$execute$2.invoke(SingleDeviceExecutor.kt:96)
        at com.google.testing.platform.result.TestResultListenerManager.afterTest(TestResultListenerManager.kt:105)
        at com.google.testing.platform.runtime.android.driver.AndroidInstrumentationDriver$InstrumentationListener.testEnded(AndroidInstrumentationDriver.kt:360)
        at com.google.testing.platform.lib.adb.command.instrument.AmInstrumentationParser.reportTestEnded(AmInstrumentationParser.kt:331)
        at com.google.testing.platform.lib.adb.command.instrument.AmInstrumentationParser.handleStatusCode(AmInstrumentationParser.kt:229)
        at com.google.testing.platform.lib.adb.command.instrument.AmInstrumentationParser.parse(AmInstrumentationParser.kt:121)
        at com.google.testing.platform.runtime.android.driver.AndroidInstrumentationDriver$runTestSuite$1.invoke(AndroidInstrumentationDriver.kt:253)
        at com.google.testing.platform.runtime.android.driver.AndroidInstrumentationDriver$runTestSuite$1.invoke(AndroidInstrumentationDriver.kt:251)
        at com.android.tools.utp.plugins.deviceprovider.ddmlib.DdmlibAndroidDeviceController$executeAsync$deferred$1$receiver$receiver$1.processNewLines(DdmlibAndroidDeviceController.kt:148)
        at com.android.ddmlib.MultiLineReceiver.addOutput(MultiLineReceiver.java:104)
        at com.android.ddmlib.AdbHelper.executeRemoteCommand(AdbHelper.java:746)
        at com.android.ddmlib.AdbHelper.executeRemoteCommand(AdbHelper.java:511)
        at com.android.ddmlib.internal.DeviceImpl.executeShellCommand(DeviceImpl.java:741)
        at com.android.tools.utp.plugins.deviceprovider.ddmlib.DdmlibAndroidDevice.executeShellCommand(DdmlibAndroidDevice.kt)
        at com.android.tools.utp.plugins.deviceprovider.ddmlib.DdmlibAndroidDeviceController$executeAsync$deferred$1.invokeSuspend(DdmlibAndroidDeviceController.kt:153)
        at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
        at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:106)
        at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:571)
        at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask(CoroutineScheduler.kt:750)
        at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker(CoroutineScheduler.kt:678)
        at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:665)

logcat-output.txt

251 KB

View

Download

gradle-output.txt

49 B

View

Download

Comments

jg...@google.com <jg...@google.com> #2Nov 16, 2022 07:08PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

Message last modified on Nov 16, 2022 07:08PM

cc...@google.com <cc...@google.com> #3Nov 16, 2022 07:43PM

I saw something like this yesterday, where /data/data is the correct path, rather than what the app sees in code. That time I saw the error messages from http://b/227510293 where outputs fails to pick a safe directory, but I've only observed that on API 21 and 22.

jg...@google.com <jg...@google.com> #4Nov 17, 2022 10:28AM

I can reproduce on the following devices:

[ro.product.model]: [Pixel 4a]
[ro.system.build.fingerprint]: [google/sunfish/sunfish:12/S2B1.211112.005/7929954:userdebug/dev-keys]
[ro.system.build.version.sdk]: [32]

[ro.product.model]: [Pixel 4a]
[ro.system.build.fingerprint]: [google/sunfish/sunfish:12/SQ1A.220205.002/8010174:user/release-keys]
[ro.system.build.version.sdk]: [31]

[ro.product.model]: [Pixel 2 XL]
[ro.system.build.fingerprint]: [google/taimen/taimen:11/RP1A.201005.004.A1/6934943:user/release-keys]
[ro.system.build.version.sdk]: [30]

Attached a bugreport from one of them.

bugreport-sunfish-S2B1.211112.005-2022-11-16-19-15-56.zip

33 MB

Download

ap...@google.com <ap...@google.com> #5Nov 29, 2022 02:05AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 68104e80c27bb7ca002dab7aed9bffa9f93721a0
Author: Chris Craik <ccraik@google.com>
Date: Wed Nov 16 12:50:54 2022

Fix file / trace file moving

Fixes:259424099
Test: ProfilerTest # API 23 26 29 33
Test: ./gradlew b:b-c:cC # API 23 26 29 31
Relnote: "Fix simpleperf trace output to create and place the file
correctly. This should also more generally fix issues where a file is
unsuccessfully pulled by gradle."

- Fix output files being incorrectly created as directory
- Fix simpleperf proto conversion, broken in refactor/rebase
- Fix output file creation errors being unsafely swallowed (which masked simpleperf proto convert issue)

This CL generally removes workarounds for an invalid path being
specified as additionalTestOutputDir, as we now expect AGP to always
pass a valid path. This may make issues with older AGP versions
passing invalid paths, but if this occurs we can suggest an alternate
workaround, such as manually passing a different directory.

Change-Id: I12a1cda85c3fb4925c6875b6a738e96494eb5f80

M benchmark/benchmark-common/src/androidTest/java/androidx/benchmark/OutputsTest.kt
M benchmark/benchmark-common/src/main/java/androidx/benchmark/Outputs.kt
M benchmark/benchmark-common/src/main/java/androidx/benchmark/simpleperf/ProfileSession.java

https://android-review.googlesource.com/2305671

ju...@google.com <ju...@google.com> #6Dec 7, 2022 06:36PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.benchmark:benchmark-common:1.2.0-alpha08

Issue 259424099

Description

Issue summary

Comments

jg...@google.com <jg...@google.com> #2Nov 16, 2022 07:08PM

cc...@google.com <cc...@google.com> #3Nov 16, 2022 07:43PM

jg...@google.com <jg...@google.com> #4Nov 17, 2022 10:28AM

ap...@google.com <ap...@google.com> #5Nov 29, 2022 02:05AM

ju...@google.com <ju...@google.com> #6Dec 7, 2022 06:36PM

Add comment

Issue metadata