dropShaderCache test crash on 1.2.0-alpha07 [API 30] [259508183]

Fixed

Bug

Status Update

No update yet.

Description

la...@team.bumble.com

created issue #1

Nov 17, 2022 05:35PM

Component used: Macrobenchmark, profileinstaller

Version used: 1.2.0-alpha07 (Macrobenchmark), 1.3.0-alpha02 (profileinstaller)

Devices/Android versions reproduced on: Samsung SM-A415F/SM-A217F (API 30) [not-rooted]

Hi!

I'm trying to update to macrobenchmark 1.2.0-alpha06 to 1.2.0-alpha07, and unfortunately due to the latest change relating to the dropShaderCache (or perhaps 'safe shell commands' - https://android-review.googlesource.com/c/platform/frameworks/support/+/2267992) macrobenchmark is failing on the first iteration of the test run.

java.lang.IllegalStateException: Expected no stderr from echo 3 > /proc/sys/vm/drop_caches && echo Success || echo Failure, saw /storage/emulated/0/Android/media/com.badoo.mobile.macrobenchmark/temporaryScript7432334656308310021.tmp[2]: can't create /proc/sys/vm/drop_caches: Permission denied
	at androidx.benchmark.Shell.executeScriptCaptureStdout(Shell.kt:217)
	at androidx.benchmark.Shell.executeScriptCaptureStdout$default(Shell.kt:215)
	at androidx.benchmark.macro.MacrobenchmarkScope.dropKernelPageCache(MacrobenchmarkScope.kt:297)
	at androidx.benchmark.macro.MacrobenchmarkKt$macrobenchmarkWithStartupMode$1.invoke(Macrobenchmark.kt:389)
	at androidx.benchmark.macro.MacrobenchmarkKt$macrobenchmarkWithStartupMode$1.invoke(Macrobenchmark.kt:365)
	at androidx.benchmark.macro.MacrobenchmarkKt$macrobenchmark$measurements$1.invoke(Macrobenchmark.kt:208)
	at androidx.benchmark.macro.MacrobenchmarkKt$macrobenchmark$measurements$1.invoke(Macrobenchmark.kt:199)
	at androidx.benchmark.macro.perfetto.PerfettoTraceProcessor$Companion.runServer(PerfettoTraceProcessor.kt:70)
	at androidx.benchmark.macro.perfetto.PerfettoTraceProcessor$Companion.runServer$default(PerfettoTraceProcessor.kt:53)
	at androidx.benchmark.macro.MacrobenchmarkKt.macrobenchmark(Macrobenchmark.kt:199)
	at androidx.benchmark.macro.MacrobenchmarkKt.macrobenchmarkWithStartupMode(Macrobenchmark.kt:365)
	at androidx.benchmark.macro.junit4.MacrobenchmarkRule.measureRepeated(MacrobenchmarkRule.kt:106)
	at com.badoo.mobile.macrobenchmark.BadooStartupBenchmark.measureAppStartup(BadooStartupBenchmark.kt:21)

Any tips to avoid this crash? Or is it possibly a bug with the latest version?

Comments

cc...@google.com <cc...@google.com> #2Nov 17, 2022 06:23PM

Yigit, do you have time to fix it?

reemission of the same liveData is racy

la...@team.bumble.com <la...@team.bumble.com> #3Nov 17, 2022 06:27PM

yea i'll take it.

ap...@google.com <ap...@google.com> #4Nov 19, 2022 05:28AM

Marked as fixed.

Thanks for the detailed analysis. This may not be an issue anymore since we've started using Main.immediate there but I' not sure; I'll try to create a test case.

ju...@google.com <ju...@google.com> #5Dec 7, 2022 06:36PM

just emitting same live data reproduces the issue.

@Test
fun raceTest() {
val subLiveData = MutableLiveData(1)
val subject = liveData(testScope.coroutineContext) {
emitSource(subLiveData)
emitSource(subLiveData) //crashes
}
subject.addObserver().apply {
testScope.advanceUntilIdle()
}
}

la...@team.bumble.com <la...@team.bumble.com> #6Dec 8, 2022 12:30PM

With 2.2.0-alpha04 (that use Main.immediate), the issue seems to be still there (I tested it by calling emitSource() twice, like your test case)

Issue 259508183