dropShaderCache test crash on 1.2.0-alpha07 [API 30] [259508183]

Fixed

Bug

Status Update

No update yet.

Description

la...@team.bumble.com

created issue #1

Nov 17, 2022 05:35PM

Component used: Macrobenchmark, profileinstaller

Version used: 1.2.0-alpha07 (Macrobenchmark), 1.3.0-alpha02 (profileinstaller)

Devices/Android versions reproduced on: Samsung SM-A415F/SM-A217F (API 30) [not-rooted]

Hi!

I'm trying to update to macrobenchmark 1.2.0-alpha06 to 1.2.0-alpha07, and unfortunately due to the latest change relating to the dropShaderCache (or perhaps 'safe shell commands' - https://android-review.googlesource.com/c/platform/frameworks/support/+/2267992) macrobenchmark is failing on the first iteration of the test run.

java.lang.IllegalStateException: Expected no stderr from echo 3 > /proc/sys/vm/drop_caches && echo Success || echo Failure, saw /storage/emulated/0/Android/media/com.badoo.mobile.macrobenchmark/temporaryScript7432334656308310021.tmp[2]: can't create /proc/sys/vm/drop_caches: Permission denied
	at androidx.benchmark.Shell.executeScriptCaptureStdout(Shell.kt:217)
	at androidx.benchmark.Shell.executeScriptCaptureStdout$default(Shell.kt:215)
	at androidx.benchmark.macro.MacrobenchmarkScope.dropKernelPageCache(MacrobenchmarkScope.kt:297)
	at androidx.benchmark.macro.MacrobenchmarkKt$macrobenchmarkWithStartupMode$1.invoke(Macrobenchmark.kt:389)
	at androidx.benchmark.macro.MacrobenchmarkKt$macrobenchmarkWithStartupMode$1.invoke(Macrobenchmark.kt:365)
	at androidx.benchmark.macro.MacrobenchmarkKt$macrobenchmark$measurements$1.invoke(Macrobenchmark.kt:208)
	at androidx.benchmark.macro.MacrobenchmarkKt$macrobenchmark$measurements$1.invoke(Macrobenchmark.kt:199)
	at androidx.benchmark.macro.perfetto.PerfettoTraceProcessor$Companion.runServer(PerfettoTraceProcessor.kt:70)
	at androidx.benchmark.macro.perfetto.PerfettoTraceProcessor$Companion.runServer$default(PerfettoTraceProcessor.kt:53)
	at androidx.benchmark.macro.MacrobenchmarkKt.macrobenchmark(Macrobenchmark.kt:199)
	at androidx.benchmark.macro.MacrobenchmarkKt.macrobenchmarkWithStartupMode(Macrobenchmark.kt:365)
	at androidx.benchmark.macro.junit4.MacrobenchmarkRule.measureRepeated(MacrobenchmarkRule.kt:106)
	at com.badoo.mobile.macrobenchmark.BadooStartupBenchmark.measureAppStartup(BadooStartupBenchmark.kt:21)

Any tips to avoid this crash? Or is it possibly a bug with the latest version?

Comments

cc...@google.com <cc...@google.com> #2Nov 17, 2022 06:23PM

Tentatively, the annotation should be something use-case-specific like @OutlinedNewApi that allows alternative build systems (e.g. not R8/D8) to make their own decisions. We'll provide a default Proguard configuration for R8, but it's not guaranteed this will work as intended -- outlining is automatic in newer versions, but it may be disabled.

la...@team.bumble.com <la...@team.bumble.com> #3Nov 17, 2022 06:27PM

Just as an FYI, this was enabled in AGP 2 years ago (AGP 7.3 as far as I remember), ag/18426192, so for AGP users it might fine to just remove the rule for @DoNotInline. I like the @OutlinedNewApi to make it clear what this is for other consumers to handle it as they see fit.

ap...@google.com <ap...@google.com> #4Nov 19, 2022 05:28AM

Marked as fixed.

This article from Morten Krogh-Jespersen suggests it wasn't (perma-)enabled by default until AGP 8.1, which is only <redacted>% of users.

Given the failure mode can include run-time crashes, that's not an acceptable level of usage.

ju...@google.com <ju...@google.com> #5Dec 7, 2022 06:36PM

I think you can still include a top-level proguard.txt, and it will be used by versions that do not support the com.android.tools format. E.g. Kotlin Coroutines library does this

la...@team.bumble.com <la...@team.bumble.com> #6Dec 8, 2022 12:30PM

Yeah, I that combined with r8-upto is the right approach. comment#4 is in regard to the idea that we should remove the annotations from source instead of gating the rules on R8 version.

Issue 259508183