dropShaderCache test crash on 1.2.0-alpha07 [API 30] [259508183]

Fixed

Bug

Status Update

No update yet.

Description

la...@team.bumble.com

created issue #1

Nov 17, 2022 05:35PM

Component used: Macrobenchmark, profileinstaller

Version used: 1.2.0-alpha07 (Macrobenchmark), 1.3.0-alpha02 (profileinstaller)

Devices/Android versions reproduced on: Samsung SM-A415F/SM-A217F (API 30) [not-rooted]

Hi!

I'm trying to update to macrobenchmark 1.2.0-alpha06 to 1.2.0-alpha07, and unfortunately due to the latest change relating to the dropShaderCache (or perhaps 'safe shell commands' - https://android-review.googlesource.com/c/platform/frameworks/support/+/2267992) macrobenchmark is failing on the first iteration of the test run.

java.lang.IllegalStateException: Expected no stderr from echo 3 > /proc/sys/vm/drop_caches && echo Success || echo Failure, saw /storage/emulated/0/Android/media/com.badoo.mobile.macrobenchmark/temporaryScript7432334656308310021.tmp[2]: can't create /proc/sys/vm/drop_caches: Permission denied
	at androidx.benchmark.Shell.executeScriptCaptureStdout(Shell.kt:217)
	at androidx.benchmark.Shell.executeScriptCaptureStdout$default(Shell.kt:215)
	at androidx.benchmark.macro.MacrobenchmarkScope.dropKernelPageCache(MacrobenchmarkScope.kt:297)
	at androidx.benchmark.macro.MacrobenchmarkKt$macrobenchmarkWithStartupMode$1.invoke(Macrobenchmark.kt:389)
	at androidx.benchmark.macro.MacrobenchmarkKt$macrobenchmarkWithStartupMode$1.invoke(Macrobenchmark.kt:365)
	at androidx.benchmark.macro.MacrobenchmarkKt$macrobenchmark$measurements$1.invoke(Macrobenchmark.kt:208)
	at androidx.benchmark.macro.MacrobenchmarkKt$macrobenchmark$measurements$1.invoke(Macrobenchmark.kt:199)
	at androidx.benchmark.macro.perfetto.PerfettoTraceProcessor$Companion.runServer(PerfettoTraceProcessor.kt:70)
	at androidx.benchmark.macro.perfetto.PerfettoTraceProcessor$Companion.runServer$default(PerfettoTraceProcessor.kt:53)
	at androidx.benchmark.macro.MacrobenchmarkKt.macrobenchmark(Macrobenchmark.kt:199)
	at androidx.benchmark.macro.MacrobenchmarkKt.macrobenchmarkWithStartupMode(Macrobenchmark.kt:365)
	at androidx.benchmark.macro.junit4.MacrobenchmarkRule.measureRepeated(MacrobenchmarkRule.kt:106)
	at com.badoo.mobile.macrobenchmark.BadooStartupBenchmark.measureAppStartup(BadooStartupBenchmark.kt:21)

Any tips to avoid this crash? Or is it possibly a bug with the latest version?

Comments

cc...@google.com <cc...@google.com> #2Nov 17, 2022 06:23PM

Thanks, that's an issue with the safe shell check. Will fix.

la...@team.bumble.com <la...@team.bumble.com> #3Nov 17, 2022 06:27PM

Thanks for the quick response! Looking forward to trying out the improvements in the next release

ap...@google.com <ap...@google.com> #4Nov 19, 2022 05:28AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 4f3a2edf189583e6c932165cc6bee92c0395c1de
Author: Chris Craik <ccraik@google.com>
Date: Fri Nov 18 16:09:26 2022

Fix dropKernelPageCache crash on unrooted builds < API33

Fixes: 259508183
Test: MacrobenchmarkScopeTest # unrooted API 29 emulator
Relnote:"Fixed crash on unrooted builds below Android 13 (API 33) with message `Expected no stderr from echo 3 > /proc/sys/vm/drop_caches`"

Change-Id: I6c2454926a9f73b665e7ec8f349ad21afe1f94b5

M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/MacrobenchmarkScopeTest.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/MacrobenchmarkScope.kt

https://android-review.googlesource.com/2309967

ju...@google.com <ju...@google.com> #5Dec 7, 2022 06:36PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.benchmark:benchmark-macro:1.2.0-alpha08

la...@team.bumble.com <la...@team.bumble.com> #6Dec 8, 2022 12:30PM

It seems to be fixed!

Great work. Thank you all :D

Issue 259508183