AGP 8.0.0 A8 breaks baseline profiles [259556213]

Fixed

Bug

Status Update

No update yet.

Description

to...@gmail.com

created issue #1

Nov 18, 2022 12:28PM

DESCRIBE THE ISSUE IN DETAIL:

STEPS TO REPRODUCE:

Compile an application with Android gradle plugin 8.0.0 alpha8
check the resulting AAB com.android.tools.build.profiles is missing
Revert to alpha 7 or 7.3.1 without any other change and com.android.tools.build.profiles is properly present.

ATTACH SCREENSHOTS/RECORDINGS OF THE ISSUE

ATTACH LOG FILES (Select Help > Show Log in Files, or Show Log in Finder on a Mac)

IMPORTANT: Please read https://developer.android.com/studio/report-bugs.html carefully and supply all required information.

Studio Build: Flaming A8 Version of Gradle Plugin: 8.0.0 A8 Version of Gradle: 7.6-rc-3 Version of Java: 11 OS: Windows

Comments

jl...@google.com <jl...@google.com> Nov 18, 2022 03:46PM

Assigned to an...@google.com.

to...@gmail.com <to...@gmail.com> #2Nov 21, 2022 10:28AM

Here is the stacktrace:

java.lang.VerifyError: Verifier rejected class WN: android.app.Notification$Style WN.h(android.app.Person, android.app.PendingIntent) failed to verify: android.app.Notification$Style WN.h(android.app.Person, android.app.PendingIntent): [0x4]  can't resolve returned type 'Reference: android.app.Notification$Style' or 'Unresolved Reference: android.app.Notification$CallStyle' (declaration of 'WN' appears in base.apk!classes4.dex)
	at Tj.<init>(SourceFile:17)
	at kT1.<init>(SourceFile:23)
	at aL1.<init>(SourceFile:293)
	at bh4.get(SourceFile:1606)
	at cL1.a(SourceFile:29)
	at cL1.e(SourceFile:17)
	at s1i.getValue(Unknown Source:17)
	at dL1.a(SourceFile:11)
	at RQ1.b(Unknown Source:2)
	at EQ1.execute(SourceFile:15)
	at lU1.handleMessage(SourceFile:18)
	at android.os.Handler.dispatchMessage(Handler.java:106)
	at N52.dispatchMessage(SourceFile:7)
	at android.os.Looper.loop(Looper.java:237)
	at android.os.HandlerThread.run(HandlerThread.java:67)

Unfortunately, I can't share the dex2oat logs for this as I'm running into this problem on Android 11 emulator and I don't have a rooted Android 11 device on-hand.

be...@google.com <be...@google.com> #3Nov 21, 2022 11:17AM

Thanks for the report. Can you share the APK failing and give suggestions to force the error such that I can see the entire logcat on device. The outline is looking correct so I believe the error is someplace else and logcat will show that.

be...@google.com <be...@google.com> #4Nov 21, 2022 11:18AM

I shared the APK and instructions to reproduce over email. Let me know if you have any trouble reproing the crash.

to...@gmail.com <to...@gmail.com> #5Nov 21, 2022 11:28AM

Thank you for the dump and information. Turns out that behavior of the verifier changed on Android 11 and 12 but was reverted again. I am working on a fix that should be easy to merge to the 4.0 branch.

Note that the verification error is actually also easy to create by manual outlining, but our pattern just emphasize it.

je...@google.com <je...@google.com> #6Nov 29, 2022 06:35PM

Status: Won't Fix (Intended Behavior)

Project: r8
Branch: main

commit b7b22190797c9b74218fb1d2fdfb497a9be9fb3b
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Mon Mar 20 13:03:38 2023

[ApiModel] Insert CheckCast for return values causing verification error

Bug:

b/272725341

Change-Id: I2479d669217d90f057fa248fcea0f0f27faf91a6

M src/main/java/com/android/tools/r8/androidapi/ComputedApiLevel.java
M src/main/java/com/android/tools/r8/ir/code/Return.java
M src/main/java/com/android/tools/r8/ir/conversion/IRConverter.java
M src/main/java/com/android/tools/r8/ir/desugar/apimodel/ApiInvokeOutlinerDesugaring.java
A src/main/java/com/android/tools/r8/ir/optimize/RemoveVerificationErrorForUnknownReturnedValues.java
M src/main/java/com/android/tools/r8/utils/AndroidApiLevelUtils.java
M src/main/java/com/android/tools/r8/utils/InternalOptions.java
M src/test/java/com/android/tools/r8/apimodel/ApiModelManualOutlineWithUnknownReturnTypeTest.java
M src/test/java/com/android/tools/r8/apimodel/ApiModelOutlineHorizontalMergingTest.java
M src/test/java/com/android/tools/r8/apimodel/ApiModelOutlineInstanceInitializerTest.java
M src/test/java/com/android/tools/r8/apimodel/ApiModelOutlineWithUnknownReturnTypeTest.java

https://r8-review.googlesource.com/77221

to...@gmail.com <to...@gmail.com> #7Nov 29, 2022 06:40PM

Project: r8
Branch: main

commit 88dd6ed0006725301bcbe88942e474569c9aa1b1
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Mon Mar 20 12:43:54 2023

[ApiModel] Add tests for introducing verification issues when outlining

Bug:

b/272725341

Change-Id: I5684a12bf42422bb96122422e063ffd0503fb5e5

M src/main/java/com/android/tools/r8/utils/AndroidApiLevel.java
A src/test/java/com/android/tools/r8/apimodel/ApiModelManualOutlineWithUnknownReturnTypeTest.java
A src/test/java/com/android/tools/r8/apimodel/ApiModelOutlineWithUnknownReturnTypeTest.java

https://r8-review.googlesource.com/77180

to...@gmail.com <to...@gmail.com> #8Nov 29, 2022 07:16PM

thanks for the fix. if this can be backported to 4.0 that would be great

da...@gmail.com <da...@gmail.com> #9Nov 29, 2022 08:14PM

Project: r8
Branch: 8.0

commit e1cdcb66b3a225076a41b646a2684d150a594693
Author: Rico Wind <ricow@google.com>
Date: Tue Mar 21 18:58:29 2023

Version 8.0.39

Bug:

b/272725341

Change-Id: Iad8a15631027cf587871f6c8df12a8b4c601296c

M src/main/java/com/android/tools/r8/Version.java

https://r8-review.googlesource.com/77428

da...@gmail.com <da...@gmail.com> #10Nov 30, 2022 10:02PM

Project: r8
Branch: 8.0

commit 7248df9f87378eda019093887585afba9631a669
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Tue Mar 21 13:59:20 2023

[ApiModel] Insert CheckCast for return values causing verification error

Bug:

b/272725341

https://r8-review.googlesource.com/77425

to...@gmail.com <to...@gmail.com> #11Dec 1, 2022 06:42AM

Project: r8
Branch: 8.0

commit 4c0694de75503094bb84d6e28fd091453b172e2e
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Tue Mar 21 13:59:12 2023

[ApiModel] Add tests for introducing verification issues when outlining

Bug:

b/272725341

https://r8-review.googlesource.com/77424

je...@google.com <je...@google.com> #12Dec 1, 2022 10:29PM

Status: Assigned (reopened)

Project: r8
Branch: 4.0

commit 4fe0ece4d3da01068bf0b63cd7a5f37d47fa6244
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Wed Mar 22 16:30:30 2023

[ApiModel] Add tests for introducing verification issues when outlining

Bug:

b/272725341

https://r8-review.googlesource.com/77496

sp...@google.com <sp...@google.com> Dec 1, 2022 11:49PM

Accepted by sp...@google.com.

sp...@google.com <sp...@google.com> #13Dec 2, 2022 06:44PM

Assigned to be...@google.com.

Project: r8
Branch: 4.0

commit 1e7c88c78ac0636eae649e132b862306ea416d48
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Wed Mar 22 16:30:43 2023

Version 4.0.58

Bug:

b/272725341

Change-Id: If899ee42bdf757985546807d785639e98b3360e6

M src/main/java/com/android/tools/r8/Version.java

https://r8-review.googlesource.com/77494

to...@gmail.com <to...@gmail.com> #14Dec 2, 2022 06:51PM

Project: r8
Branch: 4.0

commit b367460c6cab514f9c8c974f2a48e7ed862610de
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Wed Mar 22 16:30:37 2023

[ApiModel] Insert CheckCast for return values causing verification error

Bug:

b/272725341

https://r8-review.googlesource.com/77492

sp...@google.com <sp...@google.com> Dec 2, 2022 06:56PM

Reassigned to sp...@google.com.

to...@gmail.com <to...@gmail.com> #15Dec 2, 2022 07:23PM

I've backported the fix to version 4.0.58. Could you take that version for a spin to see if that solves the issues?

Message last modified on Dec 2, 2022 07:24PM

baseline.png

21 KB

View

Download

baseline-a7.png

6.8 KB

View

Download

sp...@google.com <sp...@google.com> #16Dec 2, 2022 07:25PM

I verified the fix works. Thanks!

sp...@google.com <sp...@google.com> #17Dec 3, 2022 12:16AM

Thanks for reporting back and your help with this issue.

to...@gmail.com <to...@gmail.com> #18Dec 3, 2022 08:03AM

deleted

sp...@google.com <sp...@google.com> #19Dec 3, 2022 03:38PM

ชอบ

sp...@google.com <sp...@google.com> #20Dec 5, 2022 04:01AM

Marked as fixed.

ชอบเรียนรู้

to...@gmail.com <to...@gmail.com> #21Dec 5, 2022 06:50AM

Thanks a lot, just to be sure this was also tested with both options from #8?

to...@gmail.com <to...@gmail.com> #22Dec 28, 2022 09:50AM

So updated to AGP 8.0 A10 and the profiles are back but still in com.android.tools.build.profiles this contradicts #6 is this normal/expected will it change in a future 8.0 build?

sp...@google.com <sp...@google.com> #23Dec 28, 2022 05:27PM

Re #22, please disregard #6... that only applies to APKs, not AABs.

ma...@google.com <ma...@google.com> #24Jan 17, 2023 09:58PM

Is there an alpha that includes this fix?

sp...@google.com <sp...@google.com> #25Jan 17, 2023 10:04PM

The fix will be in AGP 8.0.0-beta02 and AGP 8.1.0-alpha01

Issue 259556213

Description

Issue summary

Comments

jl...@google.com <jl...@google.com> Nov 18, 2022 03:46PM

to...@gmail.com <to...@gmail.com> #2Nov 21, 2022 10:28AM

be...@google.com <be...@google.com> #3Nov 21, 2022 11:17AM

be...@google.com <be...@google.com> #4Nov 21, 2022 11:18AM

to...@gmail.com <to...@gmail.com> #5Nov 21, 2022 11:28AM

je...@google.com <je...@google.com> #6Nov 29, 2022 06:35PM

to...@gmail.com <to...@gmail.com> #7Nov 29, 2022 06:40PM

to...@gmail.com <to...@gmail.com> #8Nov 29, 2022 07:16PM

da...@gmail.com <da...@gmail.com> #9Nov 29, 2022 08:14PM

da...@gmail.com <da...@gmail.com> #10Nov 30, 2022 10:02PM

to...@gmail.com <to...@gmail.com> #11Dec 1, 2022 06:42AM

je...@google.com <je...@google.com> #12Dec 1, 2022 10:29PM

sp...@google.com <sp...@google.com> Dec 1, 2022 11:49PM

sp...@google.com <sp...@google.com> #13Dec 2, 2022 06:44PM

to...@gmail.com <to...@gmail.com> #14Dec 2, 2022 06:51PM

sp...@google.com <sp...@google.com> Dec 2, 2022 06:56PM

to...@gmail.com <to...@gmail.com> #15Dec 2, 2022 07:23PM

sp...@google.com <sp...@google.com> #16Dec 2, 2022 07:25PM

sp...@google.com <sp...@google.com> #17Dec 3, 2022 12:16AM

to...@gmail.com <to...@gmail.com> #18Dec 3, 2022 08:03AM

sp...@google.com <sp...@google.com> #19Dec 3, 2022 03:38PM

sp...@google.com <sp...@google.com> #20Dec 5, 2022 04:01AM

to...@gmail.com <to...@gmail.com> #21Dec 5, 2022 06:50AM

to...@gmail.com <to...@gmail.com> #22Dec 28, 2022 09:50AM

sp...@google.com <sp...@google.com> #23Dec 28, 2022 05:27PM

ma...@google.com <ma...@google.com> #24Jan 17, 2023 09:58PM

sp...@google.com <sp...@google.com> #25Jan 17, 2023 10:04PM

Add comment

Issue metadata