AGP 8.0.0 A8 breaks baseline profiles [259556213]

Fixed

Bug

Status Update

No update yet.

Description

to...@gmail.com

created issue #1

Nov 18, 2022 12:28PM

DESCRIBE THE ISSUE IN DETAIL:

STEPS TO REPRODUCE:

Compile an application with Android gradle plugin 8.0.0 alpha8
check the resulting AAB com.android.tools.build.profiles is missing
Revert to alpha 7 or 7.3.1 without any other change and com.android.tools.build.profiles is properly present.

ATTACH SCREENSHOTS/RECORDINGS OF THE ISSUE

ATTACH LOG FILES (Select Help > Show Log in Files, or Show Log in Finder on a Mac)

IMPORTANT: Please read https://developer.android.com/studio/report-bugs.html carefully and supply all required information.

Studio Build: Flaming A8 Version of Gradle Plugin: 8.0.0 A8 Version of Gradle: 7.6-rc-3 Version of Java: 11 OS: Windows

Comments

jl...@google.com <jl...@google.com> Nov 18, 2022 03:46PM

Assigned to an...@google.com.

to...@gmail.com <to...@gmail.com> #2Nov 21, 2022 10:28AM

Thank you for the report and the supplied dump with the reproduction. I can confirm that the NPE is also present on HEAD, and I will look into it.

Quite a few of the class files in the dump has malformed inner-class attribute, where R8 reports e.g.:

Info in /tmp/tmpo67ucguh/program.jar:ofifmwrrhhmodsc/ψξψξψξξ.class:
Malformed inner-class attribute:
	outerTypeInternal: ofifmwrrhhmodsc/ψξψξψξξ
	innerTypeInternal: ofifmwrrhhmodsc/ψξψξψξξ$ψξξψξξξ
	innerName: ψξψξψξξ$ψξξψξξξ

These are ignored, so they should not be the reason for the NPE, but something to also look into.

be...@google.com <be...@google.com> #3Nov 21, 2022 11:17AM

Project: r8
Branch: main

commit e59500ca4445f5fb5d2ccc1114acbf66df11d196
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 09:48:55 2023

Insert patched frame instructions in the right place

Fixes:

b/274337639

Change-Id: Iae204ed529f9af5bf5fa3eaacba45128dfa6fd9e

M src/main/java/com/android/tools/r8/graph/LazyCfCode.java
M src/test/java/com/android/tools/r8/cf/frames/InitBeforeNewInInstructionStreamTest.java

https://r8-review.googlesource.com/77390

be...@google.com <be...@google.com> #4Nov 21, 2022 11:18AM

Project: r8
Branch: main

commit 780c2e83c8c033e7594d61894fa1b3dbcad6630b
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 09:48:13 2023

Add reproduction of

b/274337639

Bug:

b/274337639

Change-Id: I7573883d6a649eed47b10d7bf0cdea2e11710268

M build.gradle
M src/main/java/com/android/tools/r8/cf/code/frame/UninitializedNew.java
A src/test/java/com/android/tools/r8/cf/frames/InitBeforeNewInInstructionStreamTest.java

https://r8-review.googlesource.com/77389

to...@gmail.com <to...@gmail.com> #5Nov 21, 2022 11:28AM

I will backport this to the 8.0 and 4.0 branches.

je...@google.com <je...@google.com> #6Nov 29, 2022 06:35PM

Status: Won't Fix (Intended Behavior)

Thank you very much for taking a look at this!

Is this fix related to the nullpointer or the malformed inner-class attributes ?

Do you have a separated ticket for it? Could you share it?

to...@gmail.com <to...@gmail.com> #7Nov 29, 2022 06:40PM

Project: r8
Branch: 4.0

commit 6edb00fb23e41b28d4794cfa69d706d5c5aa3fba
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 16:55:01 2023

Version 4.0.56

Bug:

b/274337639

Change-Id: I88a20fc922ce892d38fa3a34f9a3f1f4714354ae

M src/main/java/com/android/tools/r8/Version.java

https://r8-review.googlesource.com/77447

to...@gmail.com <to...@gmail.com> #8Nov 29, 2022 07:16PM

Project: r8
Branch: 4.0

commit d9215af3b02f64d1207b9ebd63a6925229307b9d
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 16:54:50 2023

Insert patched frame instructions in the right place

Bug:

b/274337639

https://r8-review.googlesource.com/77446

da...@gmail.com <da...@gmail.com> #9Nov 29, 2022 08:14PM

Project: r8
Branch: 4.0

commit 4fda9b9062c871ba0e31cb68d1518b13b993692f
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 16:54:33 2023

Add reproduction of

b/274337639

Bug:

b/274337639

https://r8-review.googlesource.com/77445

da...@gmail.com <da...@gmail.com> #10Nov 30, 2022 10:02PM

Project: r8
Branch: 8.0

commit 6686e7dffea83ea894438b496c065d0a18cda206
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 16:53:01 2023

Version 8.0.37

Bug:

b/274337639

Change-Id: I43a723a94638088d921cd3fb6e22ef6e41f07d5f

M src/main/java/com/android/tools/r8/Version.java

https://r8-review.googlesource.com/77444

to...@gmail.com <to...@gmail.com> #11Dec 1, 2022 06:42AM

Project: r8
Branch: 8.0

commit 57f55fb70aa678a61f9c7ff1826fbc695faeac7d
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 16:52:27 2023

Insert patched frame instructions in the right place

Bug:

b/274337639

https://r8-review.googlesource.com/77443

je...@google.com <je...@google.com> #12Dec 1, 2022 10:29PM

Status: Assigned (reopened)

Project: r8
Branch: 8.0

commit cd00c053222b06bb27fdd90bbed56af9c9ef0744
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 16:51:57 2023

Add reproduction of

b/274337639

Bug:

b/274337639

https://r8-review.googlesource.com/77442

sp...@google.com <sp...@google.com> Dec 1, 2022 11:49PM

Accepted by sp...@google.com.

sp...@google.com <sp...@google.com> #13Dec 2, 2022 06:44PM

Assigned to be...@google.com.

b/274337639

https://r8-review.googlesource.com/77446

to...@gmail.com <to...@gmail.com> #14Dec 2, 2022 06:51PM

Project: r8
Branch: 4.0

commit 4fda9b9062c871ba0e31cb68d1518b13b993692f
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 16:54:33 2023

Add reproduction of

b/274337639

Bug:

b/274337639

https://r8-review.googlesource.com/77445

sp...@google.com <sp...@google.com> Dec 2, 2022 06:56PM

Reassigned to sp...@google.com.

to...@gmail.com <to...@gmail.com> #15Dec 2, 2022 07:23PM

Answer to #comment6. This fix only addresses the NPE.

The malformed inner-class attributes is an issue with the input class files, and they where not related to the NPE. You will have to contact the supplier of the library where they are present if you would like to get rid of the "Info" messages (you will have to run ./gradlew --info ... to see them). From what I can see the issue is that the innerName: ψξψξψξξ$ψξξψξξξ should have been innerName: ψξξψξξξ.

Message last modified on Dec 2, 2022 07:24PM

baseline.png

21 KB

View

Download

baseline-a7.png

6.8 KB

View

Download

sp...@google.com <sp...@google.com> #16Dec 2, 2022 07:25PM

Project: r8
Branch: 4.0

commit 49f738ff7377dacecf0fca39fec5146beb251ea3
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 18:14:15 2023

Version 4.0.57

Backport test to 4.0 test APIs.

Bug:

b/274337639

Change-Id: Iecf03a2ad9dcdbd53e6c572d2f08915248435682

M src/main/java/com/android/tools/r8/Version.java
M src/test/java/com/android/tools/r8/cf/frames/InitBeforeNewInInstructionStreamTest.java

https://r8-review.googlesource.com/77450

sp...@google.com <sp...@google.com> #17Dec 3, 2022 12:16AM

Project: r8
Branch: 8.0

commit c11ddf096e58245c2c67514dc9e5a2098dd8f705
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 18:16:54 2023

Version 8.0.38

Backport test to 8.0 test APIs.

Bug:

b/274337639

Change-Id: I35ae6d701fa92a6a7a734f9c0296d1383fed8e20

M src/main/java/com/android/tools/r8/Version.java
M src/test/java/com/android/tools/r8/cf/frames/InitBeforeNewInInstructionStreamTest.java

https://r8-review.googlesource.com/77451

to...@gmail.com <to...@gmail.com> #18Dec 3, 2022 08:03AM

deleted

sp...@google.com <sp...@google.com> #19Dec 3, 2022 03:38PM

deleted

sp...@google.com <sp...@google.com> #20Dec 5, 2022 04:01AM

Marked as fixed.

deleted

to...@gmail.com <to...@gmail.com> #21Dec 5, 2022 06:50AM

Thanks a lot, just to be sure this was also tested with both options from #8?

to...@gmail.com <to...@gmail.com> #22Dec 28, 2022 09:50AM

So updated to AGP 8.0 A10 and the profiles are back but still in com.android.tools.build.profiles this contradicts #6 is this normal/expected will it change in a future 8.0 build?

sp...@google.com <sp...@google.com> #23Dec 28, 2022 05:27PM

Re #22, please disregard #6... that only applies to APKs, not AABs.

ma...@google.com <ma...@google.com> #24Jan 17, 2023 09:58PM

Is there an alpha that includes this fix?

sp...@google.com <sp...@google.com> #25Jan 17, 2023 10:04PM

The fix will be in AGP 8.0.0-beta02 and AGP 8.1.0-alpha01

Issue 259556213

Description

Issue summary

Comments

jl...@google.com <jl...@google.com> Nov 18, 2022 03:46PM

to...@gmail.com <to...@gmail.com> #2Nov 21, 2022 10:28AM

be...@google.com <be...@google.com> #3Nov 21, 2022 11:17AM

be...@google.com <be...@google.com> #4Nov 21, 2022 11:18AM

to...@gmail.com <to...@gmail.com> #5Nov 21, 2022 11:28AM

je...@google.com <je...@google.com> #6Nov 29, 2022 06:35PM

to...@gmail.com <to...@gmail.com> #7Nov 29, 2022 06:40PM

to...@gmail.com <to...@gmail.com> #8Nov 29, 2022 07:16PM

da...@gmail.com <da...@gmail.com> #9Nov 29, 2022 08:14PM

da...@gmail.com <da...@gmail.com> #10Nov 30, 2022 10:02PM

to...@gmail.com <to...@gmail.com> #11Dec 1, 2022 06:42AM

je...@google.com <je...@google.com> #12Dec 1, 2022 10:29PM

sp...@google.com <sp...@google.com> Dec 1, 2022 11:49PM

sp...@google.com <sp...@google.com> #13Dec 2, 2022 06:44PM

to...@gmail.com <to...@gmail.com> #14Dec 2, 2022 06:51PM

sp...@google.com <sp...@google.com> Dec 2, 2022 06:56PM

to...@gmail.com <to...@gmail.com> #15Dec 2, 2022 07:23PM

sp...@google.com <sp...@google.com> #16Dec 2, 2022 07:25PM

sp...@google.com <sp...@google.com> #17Dec 3, 2022 12:16AM

to...@gmail.com <to...@gmail.com> #18Dec 3, 2022 08:03AM

sp...@google.com <sp...@google.com> #19Dec 3, 2022 03:38PM

sp...@google.com <sp...@google.com> #20Dec 5, 2022 04:01AM

to...@gmail.com <to...@gmail.com> #21Dec 5, 2022 06:50AM

to...@gmail.com <to...@gmail.com> #22Dec 28, 2022 09:50AM

sp...@google.com <sp...@google.com> #23Dec 28, 2022 05:27PM

ma...@google.com <ma...@google.com> #24Jan 17, 2023 09:58PM

sp...@google.com <sp...@google.com> #25Jan 17, 2023 10:04PM

Add comment

Issue metadata