IssueTracker

I have not seen any information about it so just asking here to avoid opening another issue. It also seems that when generating APK with alpha 8 the dex is no more compressed in the APK and stored as is. Leading to way bigger APKs.

While this is not an issue when distributing via Play Store, this could have impact for all the other distribution channels. Is this a normal wanted change and we'll have to deal with it? Or is there some new parameter to control this?

I can reproduce the originally reported issue of missing Baseline Profiles with AGP 8.0.0-alpha08. To verify, check out the bw/agp8 branch of the samples, create and inspect release builds.

AS for comment#2, I recommend creating a new issue.

Created https://issuetracker.google.com/issues/259832799 can't triage to proper component.

the location of the baseline profile has changed, it is now in dexopt folder instead of com.android.tools.build.profiles

please file a different bug for other issues so we can assign them correctly for each issue.

There is no dexopt or any baseline profile related file in the generated aab. There is also nothing related to baseline profile in APK generated with AGP 8.0.

Can you please verify, keep the issue opened and provide a solution?

As a side note I do use:

android.experimental.enableNewResourceShrinker.preciseShrinking=true

And

<?xml version="1.0" encoding="utf-8"?>
<resources xmlns:tools="http://schemas.android.com/tools"
    tools:shrinkMode="strict" />

So maybe depending on when the baseline is packaged it's removed, but in all case it's not working currently so not really WAI.

It's not working either for me. And I don't have android.experimental.enableNewResourceShrinker.preciseShrinking=true and tools:shrinkMode='strict'

Still happening with AGP 8.0.0-alpha09. Release build apk don't include baseline profile in assets/dexopt/

When they quickly close like that without checking on most part of the tracker anything written after is just plain ignored..

Need to reopen an issue, since no access to proper category hope again that triage put it in the proper place then hope that this time it's properly read.

If only all the parts could be like the R8/D8 part of this issue tracker.

Scott, can you have a look if modifying an app according to Comment #8 makes the baseline profile disappear.

I'm not able to reproduce.

Ben, the link to the repro project from comment #3 is broken for me. Can you fix it?

https://github.com/android/performance-samples/tree/agp8 is the link for #3

Is there any logs I can provide from the build to help figure out?

For the record also tested with A9 and there's the result on Windows.

Image is content of the aab (res and BUNDLE-METADATA)

And the result of a search on all the app folder including all the build dirs after the build

PS D:\_Gradle\Symfonik> Get-Childitem -Include *baseline* -Recurse

    Directory: D:\_Gradle\Symfonik\app\src\main

Mode                 LastWriteTime         Length Name
----                 -------------         ------ ----
-a---          29/11/2022    10:58        2114655 baseline-prof.txt

    Directory: D:\_Gradle\Symfonik\benchmark\src\main\java\app\symfonik\benchmark

Mode                 LastWriteTime         Length Name
----                 -------------         ------ ----
d----          29/11/2022    10:48                baselineprofile

    Directory: D:\_Gradle\Symfonik\benchmark\src\main\java\app\symfonik\benchmark\baselineprofile

Mode                 LastWriteTime         Length Name
----                 -------------         ------ ----
-a---          29/11/2022    10:48           1231 BaselineProfileGenerator.kt

Reverting to A7 generates an aab that is 15k larger (the size of the baseline)

And the search after the build gives:

PS D:\_Gradle\Symfonik> Get-Childitem -Include *baseline* -Recurse

    Directory: D:\_Gradle\Symfonik\app\build\intermediates\binary_art_profile\release

Mode                 LastWriteTime         Length Name
----                 -------------         ------ ----
-a---          02/12/2022    20:17          14796 baseline.prof

    Directory: D:\_Gradle\Symfonik\app\build\intermediates\binary_art_profile_metadata\release

Mode                 LastWriteTime         Length Name
----                 -------------         ------ ----
-a---          02/12/2022    20:17           1805 baseline.profm

    Directory: D:\_Gradle\Symfonik\app\build\intermediates\merged_art_profile\release

Mode                 LastWriteTime         Length Name
----                 -------------         ------ ----
-a---          02/12/2022    20:12        2303810 baseline-prof.txt

    Directory: D:\_Gradle\Symfonik\app\src\main

Mode                 LastWriteTime         Length Name
----                 -------------         ------ ----
-a---          29/11/2022    10:58        2114655 baseline-prof.txt

    Directory: D:\_Gradle\Symfonik\benchmark\src\main\java\app\symfonik\benchmark

Mode                 LastWriteTime         Length Name
----                 -------------         ------ ----
d----          29/11/2022    10:48                baselineprofile

    Directory: D:\_Gradle\Symfonik\benchmark\src\main\java\app\symfonik\benchmark\baselineprofile

Mode                 LastWriteTime         Length Name
----                 -------------         ------ ----
-a---          29/11/2022    10:48           1231 BaselineProfileGenerator.kt

So the files are properly generated in binary_art_profile for A7 and completely missing in A8 / A9. This does not sound like a packaging issue (Same behavior without the options from #8) but more a missing generation step.

This is a full compose app, no jetifier, minsdk 28, no png generation, ultra optimized everywhere I can, so maybe the build step depends on a step that is missing now?

Thanks. I'm able to repro now with the correct link

It looks like this was caused by Change-Id: I68ab3a6f342327cfb4c5477f85941fa3a6434a81. When I revert that change, the issue goes away. Working on a fix...

Thanks, is AGP not in AOSP? Can't find that change https://android-review.googlesource.com/q/I68ab3a6f342327cfb4c5477f85941fa3a6434a81 for my personal culture.

AGP is not in AOSP. You can see that change here. I have a pending fix for this bug.

This will be fixed in AGP 8.0.0-beta02 (Change-Id: Icb1a29bcd0c60a8ee6228a5ee05e708624c319c0)

Thanks a lot, just to be sure this was also tested with both options from #8?

So updated to AGP 8.0 A10 and the profiles are back but still in com.android.tools.build.profiles this contradicts #6 is this normal/expected will it change in a future 8.0 build?

Re #22, please disregard #6... that only applies to APKs, not AABs.

Is there an alpha that includes this fix?

The fix will be in AGP 8.0.0-beta02 and AGP 8.1.0-alpha01