AGP 8.0.0 A8 breaks baseline profiles [259556213]

Fixed

Bug

Status Update

No update yet.

Description

to...@gmail.com

created issue #1

Nov 18, 2022 12:28PM

DESCRIBE THE ISSUE IN DETAIL:

STEPS TO REPRODUCE:

Compile an application with Android gradle plugin 8.0.0 alpha8
check the resulting AAB com.android.tools.build.profiles is missing
Revert to alpha 7 or 7.3.1 without any other change and com.android.tools.build.profiles is properly present.

ATTACH SCREENSHOTS/RECORDINGS OF THE ISSUE

ATTACH LOG FILES (Select Help > Show Log in Files, or Show Log in Finder on a Mac)

IMPORTANT: Please read https://developer.android.com/studio/report-bugs.html carefully and supply all required information.

Studio Build: Flaming A8 Version of Gradle Plugin: 8.0.0 A8 Version of Gradle: 7.6-rc-3 Version of Java: 11 OS: Windows

Comments

jl...@google.com <jl...@google.com> Nov 18, 2022 03:46PM

Assigned to an...@google.com.

to...@gmail.com <to...@gmail.com> #2Nov 21, 2022 10:28AM

[Comment deleted]

be...@google.com <be...@google.com> #3Nov 21, 2022 11:17AM

[Comment deleted]

be...@google.com <be...@google.com> #4Nov 21, 2022 11:18AM

Also of note is the adb error when trying to install bad APK: INSTALL_FAILED_DEXOPT

to...@gmail.com <to...@gmail.com> #5Nov 21, 2022 11:28AM

load dex files over 5Gb. -> load dex files over 5Mb.

je...@google.com <je...@google.com> #6Nov 29, 2022 06:35PM

Status: Won't Fix (Intended Behavior)

Same here! Looking forward to a solution :)

Android Studio version: 0.8.12
buildToolsVersion 21.0.1
Gradle 1.11

to...@gmail.com <to...@gmail.com> #7Nov 29, 2022 06:40PM

There is already an option in dx allowing to force generation of smaller dex files:
--set-max-idx-number=<value>
Unfortunately changing the default is not a solution since the linearAlloc limit can be reached at very different levels depending on the classes hierarchy and other criteria.

In addition for most applications, moving to multidex will only help to workaround the linearalloc limit for the installation. But the application will still crash against the same limit at execution. The only working use case where I know multidex can help with linearalloc is when the apk does not contains one application but distinct pieces running in separate process.

to...@gmail.com <to...@gmail.com> #8Nov 29, 2022 07:16PM

Thanks for your quick response.

It's nice to know about that command line option. I do not see it in the output of 'dx --help', might be good to add that.

I'm not very familiar with the 'linearAlloc limit' issue outside of the context of the dexopt step. My sample app is able to run once the lower idx value is set, although I do not actually call into any of the library code that is bundled with the app. I assume it's undefined when/if the 'linearAlloc limit' will be hit in a large application on gb.

I'm a bit confused as to the platform compatibility of multidex given the 'linearAlloc limit' bug. What specific versions of Android are supported? The multidex code implies back to v4 (

https://android.googlesource.com/platform/frameworks/multidex/+/master/library/src/android/support/multidex/MultiDex.java) but it would seem that ICS is the earliest supported platform. Is this correct?

da...@gmail.com <da...@gmail.com> #9Nov 29, 2022 08:14PM

The option is not documented in --help because it was designed for testing and we're not capable of documenting a reliable way to use it as a workaround of the linearalloc limit.

The linearalloc limit is reached when loading classes. At install time dexopt is loading all classes contained in the dex so it's facing the limit immediately. At execution the limit may be reached after some delay dependending of the usage you have of the packaged classes. If you face it at install time but not at execution, this means you never trigger the loading of some classes. In a real application those never loaded classes should have been shrinked away manually or by Proguard. The exception is when there are different groups of classes in the dex files used in separate process.

About multidex library supported versions I've merged recently a change to try to be clearer

https://android-review.googlesource.com/#/c/108023/
The summary is that the library should work down to API 4 (Donut), but below ICS applications will probably be hit by the linearalloc limit

da...@gmail.com <da...@gmail.com> #10Nov 30, 2022 10:02PM

for Android studio use:
dexOptions {
additionalParameters = ['--multi-dex', '--set-max-idx-number=40000']
}

to...@gmail.com <to...@gmail.com> #11Dec 1, 2022 06:42AM

I still have this issue and it's driving me nuts

je...@google.com <je...@google.com> #12Dec 1, 2022 10:29PM

Status: Assigned (reopened)

smgshantokhan55698@gmail.com

sp...@google.com <sp...@google.com> Dec 1, 2022 11:49PM

Accepted by sp...@google.com.

sp...@google.com <sp...@google.com> #13Dec 2, 2022 06:44PM

Assigned to be...@google.com.

https://twitter.com/Shanto59597264?t=AcggXWk2PPhi4bU9UC3YHA&s=09 @shantokhan59597264

to...@gmail.com <to...@gmail.com> #14Dec 2, 2022 06:51PM

https://github.com/android/performance-samples/tree/agp8 is the link for #3

Is there any logs I can provide from the build to help figure out?

sp...@google.com <sp...@google.com> Dec 2, 2022 06:56PM

Reassigned to sp...@google.com.

to...@gmail.com <to...@gmail.com> #15Dec 2, 2022 07:23PM

For the record also tested with A9 and there's the result on Windows.

Image is content of the aab (res and BUNDLE-METADATA)

And the result of a search on all the app folder including all the build dirs after the build

PS D:\_Gradle\Symfonik> Get-Childitem -Include *baseline* -Recurse

    Directory: D:\_Gradle\Symfonik\app\src\main

Mode                 LastWriteTime         Length Name
----                 -------------         ------ ----
-a---          29/11/2022    10:58        2114655 baseline-prof.txt

    Directory: D:\_Gradle\Symfonik\benchmark\src\main\java\app\symfonik\benchmark

Mode                 LastWriteTime         Length Name
----                 -------------         ------ ----
d----          29/11/2022    10:48                baselineprofile

    Directory: D:\_Gradle\Symfonik\benchmark\src\main\java\app\symfonik\benchmark\baselineprofile

Mode                 LastWriteTime         Length Name
----                 -------------         ------ ----
-a---          29/11/2022    10:48           1231 BaselineProfileGenerator.kt

Reverting to A7 generates an aab that is 15k larger (the size of the baseline)

And the search after the build gives:

PS D:\_Gradle\Symfonik> Get-Childitem -Include *baseline* -Recurse

    Directory: D:\_Gradle\Symfonik\app\build\intermediates\binary_art_profile\release

Mode                 LastWriteTime         Length Name
----                 -------------         ------ ----
-a---          02/12/2022    20:17          14796 baseline.prof

    Directory: D:\_Gradle\Symfonik\app\build\intermediates\binary_art_profile_metadata\release

Mode                 LastWriteTime         Length Name
----                 -------------         ------ ----
-a---          02/12/2022    20:17           1805 baseline.profm

    Directory: D:\_Gradle\Symfonik\app\build\intermediates\merged_art_profile\release

Mode                 LastWriteTime         Length Name
----                 -------------         ------ ----
-a---          02/12/2022    20:12        2303810 baseline-prof.txt

    Directory: D:\_Gradle\Symfonik\app\src\main

Mode                 LastWriteTime         Length Name
----                 -------------         ------ ----
-a---          29/11/2022    10:58        2114655 baseline-prof.txt

    Directory: D:\_Gradle\Symfonik\benchmark\src\main\java\app\symfonik\benchmark

Mode                 LastWriteTime         Length Name
----                 -------------         ------ ----
d----          29/11/2022    10:48                baselineprofile

    Directory: D:\_Gradle\Symfonik\benchmark\src\main\java\app\symfonik\benchmark\baselineprofile

Mode                 LastWriteTime         Length Name
----                 -------------         ------ ----
-a---          29/11/2022    10:48           1231 BaselineProfileGenerator.kt

So the files are properly generated in binary_art_profile for A7 and completely missing in A8 / A9. This does not sound like a packaging issue (Same behavior without the options from #8) but more a missing generation step.

This is a full compose app, no jetifier, minsdk 28, no png generation, ultra optimized everywhere I can, so maybe the build step depends on a step that is missing now?

Message last modified on Dec 2, 2022 07:24PM

baseline.png

21 KB

View

Download

baseline-a7.png

6.8 KB

View

Download

sp...@google.com <sp...@google.com> #16Dec 2, 2022 07:25PM

Thanks. I'm able to repro now with the correct link

sp...@google.com <sp...@google.com> #17Dec 3, 2022 12:16AM

It looks like this was caused by Change-Id: I68ab3a6f342327cfb4c5477f85941fa3a6434a81. When I revert that change, the issue goes away. Working on a fix...

to...@gmail.com <to...@gmail.com> #18Dec 3, 2022 08:03AM

Thanks, is AGP not in AOSP? Can't find that change https://android-review.googlesource.com/q/I68ab3a6f342327cfb4c5477f85941fa3a6434a81 for my personal culture.

sp...@google.com <sp...@google.com> #19Dec 3, 2022 03:38PM

AGP is not in AOSP. You can see that change here. I have a pending fix for this bug.

sp...@google.com <sp...@google.com> #20Dec 5, 2022 04:01AM

Marked as fixed.

This will be fixed in AGP 8.0.0-beta02 (Change-Id: Icb1a29bcd0c60a8ee6228a5ee05e708624c319c0)

to...@gmail.com <to...@gmail.com> #21Dec 5, 2022 06:50AM

Thanks a lot, just to be sure this was also tested with both options from #8?

to...@gmail.com <to...@gmail.com> #22Dec 28, 2022 09:50AM

So updated to AGP 8.0 A10 and the profiles are back but still in com.android.tools.build.profiles this contradicts #6 is this normal/expected will it change in a future 8.0 build?

sp...@google.com <sp...@google.com> #23Dec 28, 2022 05:27PM

Re #22, please disregard #6... that only applies to APKs, not AABs.

ma...@google.com <ma...@google.com> #24Jan 17, 2023 09:58PM

Is there an alpha that includes this fix?

sp...@google.com <sp...@google.com> #25Jan 17, 2023 10:04PM

The fix will be in AGP 8.0.0-beta02 and AGP 8.1.0-alpha01