AGP 8.0.0 A8 no more compress dex files in the APK [259832799]

WAI

Bug

Status Update

No update yet.

Description

to...@gmail.com

created issue #1

Nov 21, 2022 11:28AM

DESCRIBE THE ISSUE IN DETAIL:

STEPS TO REPRODUCE:

Build an APK via gradle (release)
Inspect the APK the .dex is not compressed leading to bigger APKs
Revert to A7 the .dex is properly compressed and the APK have normal size.

While this is not an issue when distributing via Play Store, this is problematic for other channel distributions. (For my app the .APK double it's size 6MB to 12MB).

If this is a wanted change to improve differential updates or needed by Play Store, it would be nice if this was guarded by a parameter to allow to keep previous way.

Studio Build: Flaming A8 Version of Gradle Plugin: 8.0.0 A8 Version of Gradle: 7.6-rc-3 Version of Java: 11 OS: Windows

Comments

jo...@google.com <jo...@google.com> Nov 21, 2022 05:21PM

Assigned to an...@google.com.

ri...@google.com <ri...@google.com> #2Nov 22, 2022 08:20AM

Reassigned to ga...@google.com.

I am not sure why this was not done a long time ago, on most newer phones art can use the dex directly from an mmapped apk if it is stored uncompressed, which means that you save a copy on the device since it will not extract a copy. This is mostly much more important than the size in transit (which for play store will already be compressed over the wire and diffed using file by file diffing if this is a update).
It is actually not R8 doing the packing, so cc gavra@ on why this happened now

Message last modified on Nov 22, 2022 08:21AM

to...@gmail.com <to...@gmail.com> #3Nov 22, 2022 08:31AM

I know it's not D8 that does the packing unfortunately most of the sections are not writable by devs and triage probably just do what it can. In this case he saw dex he selected D8 :) (At least it was triaged to a responsive team)

Wanted to attribute to AGP tracker part.

Anyway thanks for explaining what the OS can do uncompressed (Can you clarify if it's tied to Android version or OEM could have difference too), but this is still a change that needs to be documented and possibly optioned for distribution on self hosting where BW have impact.

Would be nice to also know if this is the case for debug builds when ran on older devices that requires ADB upload in slow mode as it impact dev times too.

ri...@google.com <ri...@google.com> #4Nov 22, 2022 08:44AM

I think this is from android O, at least according to discussions here:

https://b.corp.google.com/issues/231903117
Maybe you can use:

https://developer.android.com/reference/tools/gradle-api/7.1/com/android/build/api/dsl/DexPackagingOptions#useLegacyPackaging:kotlin.Boolean
(could be that we changed the default - Ivan to validate that)

ri...@google.com <ri...@google.com> #5Nov 22, 2022 08:45AM

External link for issue mentioned in #4

https://issuetracker.google.com/231903117

to...@gmail.com <to...@gmail.com> #6Nov 22, 2022 08:51AM

Ok thanks for the details that explains all :(

If null, dex files will be uncompressed when minSdk >= 28.

And I've just migrated to that in that app, was completely unable to find that info by myself :(

Thanks a lot, this can be closed then, not related to the AGP update just a bad coincidence.

ri...@google.com <ri...@google.com> Nov 22, 2022 08:53AM

Status: Won't Fix (Intended Behavior)