Setting JVM toolchain does not affect JavaCompile targetCompatibility value [260059413]

Fixed

Bug

Status Update

No update yet.

Description

eg...@gmail.com

created issue #1

Nov 22, 2022 04:24PM

When Gradle JVM toolchain is configured in Android project, I see it properly configures Kotlin compilation with jvmTarget value equals to toolchain JDK. Though JavaCompile targetCompatability stays as JavaVersion.VERSION_1_8. In the logs I see JavaCompile uses JDK from configured toolchain.

Toolchain should behave the same as in JVM-only project and configure JavaCompile.targetCompatibility value.

Issue is related to this one

Workaround is to specify these values explicitly in android extension:

android {
   compileOptions {
       sourceCompatibility JavaVersion.VERSION_..
       targetCompatibility JavaVersion.VERSION_..
   }
}

STEPS TO REPRODUCE:

Use AGP 7.4.0-beta02 in project
Also apply "org.jetbrains.kotlin.android" plugin version 1.7.20
Configure toolchain via following configuration:

kotlin {
    jvmToolchain {
        languageVersion.set(JavaLanguageVersion.of(17))
    }
}

Run build compilation via :assembleDebug and observe following warning in :compileKotlin task output:

'compileDebugJavaWithJavac' task (current target is 1.8) and 'compileDebugKotlin' task (current target is 17) jvm target compatibility should be set to the same Java version.

Comments

em...@google.com <em...@google.com> Nov 22, 2022 07:29PM

Assigned to an...@google.com.

je...@google.com <je...@google.com> Nov 29, 2022 06:37PM

Reassigned to ga...@google.com.

ga...@google.com <ga...@google.com> Jan 5, 2023 02:44PM

Reassigned to bi...@google.com.

ga...@google.com <ga...@google.com> #2Jan 5, 2023 03:45PM

This was broken by 3bca759a5ff08352de831bb1e9b61b1ec2b3362d.
Fix (pending) is I2c2dc7b600603ee430fd0d91b23d52ea8aa29ca9.

pa...@gmail.com <pa...@gmail.com> #3Jan 16, 2023 11:44AM

Almost 2 months later and this is still broken

Message last modified on Jan 16, 2023 11:44AM

ja...@google.com <ja...@google.com> #4Feb 3, 2023 08:56PM

Since there is no progression, I wanted to share our quick-fix for the issue.

#sdkmanager --package_file=${PATH_WORKSPACE}/packages
while read p; do echo "y" | sdkmanager "${p}"; done <${PATH_WORKSPACE}/packages

pa...@gmail.com <pa...@gmail.com> #5Feb 3, 2023 10:08PM

jb...@google.com What is the update on this?

At...@web.de <At...@web.de> #6Feb 4, 2023 02:05AM

What is the status of this item?

bi...@google.com <bi...@google.com> Feb 6, 2023 04:33PM

Accepted by bi...@google.com.

bi...@google.com <bi...@google.com> #7Feb 11, 2023 01:30AM

This has been fixed on master today (internal ref: ag/2945015) and will be available in the next SDK release.

Message last modified on Feb 11, 2023 01:35AM

pa...@gmail.com <pa...@gmail.com> #8Feb 11, 2023 09:13AM

Any ETA on next release?

bi...@google.com <bi...@google.com> #9Feb 13, 2023 07:57PM

Still broken and not updated? --package_file argument is not usable in it's current form on 26.1.1 straight from the developer site.

hu...@google.com <hu...@google.com> #10Mar 7, 2023 02:16PM

Comfirmed that this seems to still be broken. Can we have an update please?

```
(15:58:11) C02W513SHTD8:files aso$ /opt/android-sdk-macosx/tools/bin/sdkmanager --version
26.1.1

(15:58:17) C02W513SHTD8:files aso$ /opt/android-sdk-macosx/tools/bin/sdkmanager --install --package_file=package_file
Warning: Unknown argument --package_file=package_file
```

bi...@google.com <bi...@google.com> #11Mar 7, 2023 05:09PM

Marked as fixed.

Hi, is there any update to this issue? Thanks.

hu...@google.com <hu...@google.com> #12Mar 7, 2023 05:59PM

Hi Google. You claim it's been fixed on master, but we haven't had a new release since the broken version 26.1.1. Can you please release the fix?

cl...@vippsmobilepay.com <cl...@vippsmobilepay.com> #13Oct 3, 2024 09:11AM

Yeah, still not fixed --'

pa...@gmail.com <pa...@gmail.com> #14Oct 3, 2024 11:01AM

Can't believe this still isn't fixed 2 years later for a command line utility that sits on the main dev site.

hu...@google.com <hu...@google.com> #15Oct 7, 2024 11:14AM

Any updates on this? The help for this command clearly states this argument is supported.

cl...@vippsmobilepay.com <cl...@vippsmobilepay.com> #16Oct 7, 2024 11:45AM

Has anyone re-tried it? We switched back to RUN sdkmanager --package_file=$ANDROID_HOME/packages.txt in our Dockerfile back in March of 2021.

hu...@google.com <hu...@google.com> #17Oct 7, 2024 01:19PM

For what it's worth, I did a quick test with the latest CLI: 11076708 (https://developer.android.com/studio#downloads) on OSX and tried it with a simple:

./sdkmanager --sdk_root="../sdk" --package_file=deps.txt

Deps.txt:

platform-tools
extras;google;instantapps
build-tools;35.0.0-rc3

So perhaps this is now resolved? I haven't tried it with more packages

Message last modified on Oct 7, 2024 01:24PM

pa...@gmail.com <pa...@gmail.com> #18Oct 7, 2024 06:27PM

Is that close enough to delay fixing the current state?

hu...@google.com <hu...@google.com> #19Oct 8, 2024 11:10AM

I've filed Issue 372185847 to discuss this.