Feature Request: Optin tracing for WorkManager [260214125]

Bug

Status Update

No update yet.

Description

yu...@schimke.ee

created issue #1

Nov 23, 2022 03:53PM

Component used: workmanager + androidx.tracing:tracing-ktx
Version used: 2.7.1
Devices/Android versions reproduced on: Emulator + Wear

Apps using WorkManager under benchmarking would benefit from almost automatic tracing of WorkManager executions.

Particularly with libraries like androidx.media3:media3-exoplayer-workmanager, the actual implementations may not be in app code, so it's hard to add manual tracing.

Ideally some additional dependency similar to compose runtime tracing, that when included outputs tracing that will show up in perfetto automatically, explaining app behaviour during the profiling window.

Comments

ra...@google.com <ra...@google.com> #2Nov 28, 2022 06:51PM

Assigned to ra...@google.com.

https://android-review.googlesource.com/c/platform/frameworks/support/+/1092870

ra...@google.com <ra...@google.com> #3Dec 2, 2022 10:29PM

Thank you for the quick fix.
Is there an ETA for the next release?

19...@gmail.com <19...@gmail.com> #4Mar 2, 2023 03:13PM

2.2.0-rc01 should be out this week.

yu...@schimke.ee <yu...@schimke.ee> #5May 2, 2023 06:59PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit a1957df3709a06f4e6482fb0e4d39ded4f230a70
Author: Rahul Ravikumar <rahulrav@google.com>
Date: Mon Jul 29 09:48:05 2019

Workaround NPE in PersistableBundle.getExtras().

Test: Existing unit tests pass. Ran integration test app.
Fixes:

b/138441699

Change-Id: I0b48e0009a7d83c343a3d26112b94c057470c281

M work/workmanager/src/main/java/androidx/work/impl/background/systemjob/SystemJobService.java

https://android-review.googlesource.com/1092870

https://goto.google.com/android-sha1/a1957df3709a06f4e6482fb0e4d39ded4f230a70

ra...@google.com <ra...@google.com> #6May 2, 2023 09:15PM

Reassigned to se...@google.com.

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6206758647365632/#/cherrypickHistory/all)
Created: 2019-07-29 19:41:55.445144+00:00
Changes: aosp/1092870

ys...@google.com <ys...@google.com> #7Nov 14, 2023 11:16PM

ping.

se...@google.com <se...@google.com> #8Nov 15, 2023 10:56AM

Yeah, it is in the state of "one of the top features that we want to enable", but with scarce resources didn't get around to actually do it.

ap...@google.com <ap...@google.com> #9Apr 4, 2024 08:19PM

Project: platform/frameworks/support
Branch: androidx-main

commit ba07ebdc49528ac69613916f852eaffabd2404ff
Author: Rahul Ravikumar <rahulrav@google.com>
Date: Wed Apr 03 17:42:25 2024

Add the ability to automatically emit perfetto traces for WorkRequest execution.

Bug: 260214125
Test: Updated WorkerWrapperTest
Relnote: Added the ability to emit trace spans via a configurable @RestrictTo `Tracer` in WorkManager.
Change-Id: I17d7f0ec2b1947d09d568ca1f69ea6fee64c713c

M work/work-multiprocess/src/main/java/androidx/work/multiprocess/parcelable/ParcelableWorkRequest.java
M work/work-runtime/api/current.txt
M work/work-runtime/api/restricted_current.txt
M work/work-runtime/build.gradle
M work/work-runtime/src/androidTest/java/androidx/work/impl/WorkerWrapperTest.java
M work/work-runtime/src/main/java/androidx/work/Configuration.kt
A work/work-runtime/src/main/java/androidx/work/Tracer.kt
M work/work-runtime/src/main/java/androidx/work/WorkRequest.kt
M work/work-runtime/src/main/java/androidx/work/impl/WorkDatabase.kt
M work/work-runtime/src/main/java/androidx/work/impl/WorkerWrapper.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkSpec.kt
A work/work-runtime/src/schemas/androidx.work.impl.WorkDatabase/23.json

https://android-review.googlesource.com/2835705

is...@google.com <is...@google.com> Oct 7, 2024 09:05AM

Status: New