Bug P3
Status Update
Comments
ra...@google.com <ra...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
https://android-review.googlesource.com/1123258
https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
ra...@google.com <ra...@google.com> #3
19...@gmail.com <19...@gmail.com> #4
Project: platform/frameworks/support
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically ( b/140759491 ).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
https://android-review.googlesource.com/1288456
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
yu...@schimke.ee <yu...@schimke.ee> #5
Is this still moving forward?
ra...@google.com <ra...@google.com> #6
Reassigning this to sergeyv@, so he can prioritize.
ys...@google.com <ys...@google.com> #7
ping.
se...@google.com <se...@google.com> #8
Yeah, it is in the state of "one of the top features that we want to enable", but with scarce resources didn't get around to actually do it.
ap...@google.com <ap...@google.com> #9
Project: platform/frameworks/support
Branch: androidx-main
commit ba07ebdc49528ac69613916f852eaffabd2404ff
Author: Rahul Ravikumar <rahulrav@google.com>
Date: Wed Apr 03 17:42:25 2024
Add the ability to automatically emit perfetto traces for WorkRequest execution.
Bug: 260214125
Test: Updated WorkerWrapperTest
Relnote: Added the ability to emit trace spans via a configurable @RestrictTo `Tracer` in WorkManager.
Change-Id: I17d7f0ec2b1947d09d568ca1f69ea6fee64c713c
M work/work-multiprocess/src/main/java/androidx/work/multiprocess/parcelable/ParcelableWorkRequest.java
M work/work-runtime/api/current.txt
M work/work-runtime/api/restricted_current.txt
M work/work-runtime/build.gradle
M work/work-runtime/src/androidTest/java/androidx/work/impl/WorkerWrapperTest.java
M work/work-runtime/src/main/java/androidx/work/Configuration.kt
A work/work-runtime/src/main/java/androidx/work/Tracer.kt
M work/work-runtime/src/main/java/androidx/work/WorkRequest.kt
M work/work-runtime/src/main/java/androidx/work/impl/WorkDatabase.kt
M work/work-runtime/src/main/java/androidx/work/impl/WorkerWrapper.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkSpec.kt
A work/work-runtime/src/schemas/androidx.work.impl.WorkDatabase/23.json
https://android-review.googlesource.com/2835705
Branch: androidx-main
commit ba07ebdc49528ac69613916f852eaffabd2404ff
Author: Rahul Ravikumar <rahulrav@google.com>
Date: Wed Apr 03 17:42:25 2024
Add the ability to automatically emit perfetto traces for WorkRequest execution.
Bug: 260214125
Test: Updated WorkerWrapperTest
Relnote: Added the ability to emit trace spans via a configurable @RestrictTo `Tracer` in WorkManager.
Change-Id: I17d7f0ec2b1947d09d568ca1f69ea6fee64c713c
M work/work-multiprocess/src/main/java/androidx/work/multiprocess/parcelable/ParcelableWorkRequest.java
M work/work-runtime/api/current.txt
M work/work-runtime/api/restricted_current.txt
M work/work-runtime/build.gradle
M work/work-runtime/src/androidTest/java/androidx/work/impl/WorkerWrapperTest.java
M work/work-runtime/src/main/java/androidx/work/Configuration.kt
A work/work-runtime/src/main/java/androidx/work/Tracer.kt
M work/work-runtime/src/main/java/androidx/work/WorkRequest.kt
M work/work-runtime/src/main/java/androidx/work/impl/WorkDatabase.kt
M work/work-runtime/src/main/java/androidx/work/impl/WorkerWrapper.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkSpec.kt
A work/work-runtime/src/schemas/androidx.work.impl.WorkDatabase/23.json
Description
Version used: 2.7.1
Devices/Android versions reproduced on: Emulator + Wear
Apps using WorkManager under benchmarking would benefit from almost automatic tracing of WorkManager executions.
Particularly with libraries like androidx.media3:media3-exoplayer-workmanager, the actual implementations may not be in app code, so it's hard to add manual tracing.
Ideally some additional dependency similar to compose runtime tracing, that when included outputs tracing that will show up in perfetto automatically, explaining app behaviour during the profiling window.